From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!.POSTED!not-for-mail From: Alan Third Newsgroups: gmane.emacs.bugs Subject: bug#33126: 26.1; xpm2 broken in MacOSX Date: Wed, 24 Oct 2018 12:17:36 +0100 Message-ID: <20181024111736.GC40431@breton.holly.idiocy.org> References: NNTP-Posting-Host: blaine.gmane.org Mime-Version: 1.0 Content-Type: multipart/mixed; boundary="6c2NcOVqGQ03X4Wi" Content-Transfer-Encoding: 8bit X-Trace: blaine.gmane.org 1540379771 17949 195.159.176.226 (24 Oct 2018 11:16:11 GMT) X-Complaints-To: usenet@blaine.gmane.org NNTP-Posting-Date: Wed, 24 Oct 2018 11:16:11 +0000 (UTC) User-Agent: Mutt/1.10.1 (2018-07-13) Cc: 33126@debbugs.gnu.org To: Devon Sean McCullough Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Wed Oct 24 13:16:07 2018 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane.org Original-Received: from lists.gnu.org ([208.118.235.17]) by blaine.gmane.org with esmtp (Exim 4.84_2) (envelope-from ) id 1gFH8w-0004Zs-GD for geb-bug-gnu-emacs@m.gmane.org; Wed, 24 Oct 2018 13:16:06 +0200 Original-Received: from localhost ([::1]:47576 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1gFHB2-0003dt-Sw for geb-bug-gnu-emacs@m.gmane.org; Wed, 24 Oct 2018 07:18:16 -0400 Original-Received: from eggs.gnu.org ([2001:4830:134:3::10]:41381) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1gFHAv-0003dm-SO for bug-gnu-emacs@gnu.org; Wed, 24 Oct 2018 07:18:10 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1gFHAq-0007lw-9z for bug-gnu-emacs@gnu.org; Wed, 24 Oct 2018 07:18:08 -0400 Original-Received: from debbugs.gnu.org ([208.118.235.43]:34867) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1gFHAo-0007lA-Ob for bug-gnu-emacs@gnu.org; Wed, 24 Oct 2018 07:18:04 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1gFHAo-0004FQ-JN for bug-gnu-emacs@gnu.org; Wed, 24 Oct 2018 07:18:02 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Alan Third Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Wed, 24 Oct 2018 11:18:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 33126 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: Original-Received: via spool by 33126-submit@debbugs.gnu.org id=B33126.154037986816307 (code B ref 33126); Wed, 24 Oct 2018 11:18:02 +0000 Original-Received: (at 33126) by debbugs.gnu.org; 24 Oct 2018 11:17:48 +0000 Original-Received: from localhost ([127.0.0.1]:39125 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1gFHAZ-0004Ex-OE for submit@debbugs.gnu.org; Wed, 24 Oct 2018 07:17:47 -0400 Original-Received: from mail-wm1-f48.google.com ([209.85.128.48]:50305) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1gFHAX-0004Ek-Er for 33126@debbugs.gnu.org; Wed, 24 Oct 2018 07:17:46 -0400 Original-Received: by mail-wm1-f48.google.com with SMTP id i8-v6so4951855wmg.0 for <33126@debbugs.gnu.org>; Wed, 24 Oct 2018 04:17:45 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=googlemail.com; s=20161025; h=sender:date:from:to:cc:subject:message-id:references:mime-version :content-disposition:content-transfer-encoding:in-reply-to :user-agent; bh=0Wls94q45z3TouVFEhHf8OC8ogFZDzaHh36g/XC91oA=; b=nJUB5aXD04HNw0DYLdWnmgXiWC8syjd5sFBWzHK5KP/YwNSdyRjvc5EO34SovAUA6O Y0BeCXh5VrNRqOGBMEo/pJd+kaURsXEdysaubp4FmXkxR3G8DpcCz/P8kn/wmmXJMx4g jK0f8DkNvNR9U5Gb22fuuO9BcIn2I2uyxyHdgZQgaShP8f9wUM9Yyf7uaVOMn/HXYB8R ETzjRCFYEEsQ2Z4tQqocDK1Q6OW4wXVAVWMyPHgbBwQrtpufHX7BOp8T/tQ+ppckSHEH hYhm4cdIIiOcBP7vMtZ0jtw+ICfaz/zOVSn0lcOND94OgMvAxZZzS9hSy/06dif/P+5U yDOA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:sender:date:from:to:cc:subject:message-id :references:mime-version:content-disposition :content-transfer-encoding:in-reply-to:user-agent; bh=0Wls94q45z3TouVFEhHf8OC8ogFZDzaHh36g/XC91oA=; b=re5fnSqVTFaK/GFTbXYzan5uqccbm8O/19LUABgTE3432FXxOWzVUt1riNQyiOfDbL ppP7xESP2BeM5kYa7ZGVUEgGjAAuMfDSSsD9JzlPLNB43Jtb26Fkq/Xk6kWbB1nHZ8Pm eR3qZpbDDz4iR1V2d2djInHFDuE4s2OsYXgiduUv4rPfGKXJWa3UdJuIqcXrMw6jFOpj OgxEgUQpPcanZDRfGIJV6FTZQzIQdvpR1tGc/4Y0529NIRNHia79Req1XzfTb3sfK1VE 3aXT62f9eGQCNJd+3XMKqiQ3JViNFwzJMlTQ1YnYciE09qWlR07r5ig47lt22/XXHO83 TrYg== X-Gm-Message-State: AGRZ1gKaViG3n+QwiaczAR4B725+9dIUqT0Xe5E550bRgUNKb7krJfiF 9HAyuB2XoDiMlhrIupT/hGz/4mBG X-Google-Smtp-Source: AJdET5cyqbT8Cv051hFGjwSqe6bVYVOoufITba+5foUZD6QbsJN6KY8YIkVsopg4KzvwKZEgHVRryQ== X-Received: by 2002:a1c:88cd:: with SMTP id k196-v6mr2146055wmd.17.1540379859474; Wed, 24 Oct 2018 04:17:39 -0700 (PDT) Original-Received: from breton.holly.idiocy.org (ip6-2001-08b0-03f8-8129-a9a7-73e3-89ce-d96b.holly.idiocy.org. [2001:8b0:3f8:8129:a9a7:73e3:89ce:d96b]) by smtp.gmail.com with ESMTPSA id a13-v6sm2288080wrs.73.2018.10.24.04.17.38 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Wed, 24 Oct 2018 04:17:38 -0700 (PDT) Content-Disposition: inline In-Reply-To: X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 208.118.235.43 X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.org gmane.emacs.bugs:151547 Archived-At: --6c2NcOVqGQ03X4Wi Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit On Tue, Oct 23, 2018 at 10:02:06PM +0800, Devon Sean McCullough wrote: > ; This code inserts four images > ; 1 - a correct checkerboard > ; 2 - an incorrect blank image of the wrong size > ; 3 - a correct "blarg" > ; 4 - a correct checkerboard > ; but the middle two images should look identical. Confirmed. I found this in image.c: /* XPM support functions for NS where libxpm is not available. Only XPM version 3 (without any extensions) is supported. */ I suppose to get xpm2 support you’ll have to find a version of libxpm somewhere. There is an error logged in *Messages*, perhaps it should specify XPM3 per the attached patch. -- Alan Third --6c2NcOVqGQ03X4Wi Content-Type: text/plain; charset=us-ascii Content-Disposition: attachment; filename="0001-Improve-XPM-load-failure-message-bug-33126.patch" >From 9d9b85529bbd560305e4bcc3823aad23e393ee74 Mon Sep 17 00:00:00 2001 From: Alan Third Date: Wed, 24 Oct 2018 12:15:16 +0100 Subject: [PATCH] Improve XPM load failure message (bug#33126) * src/image.c (xpm_load_image): Only XPM3 is supported, so make that explicit. --- src/image.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/image.c b/src/image.c index 767979e63b..a6b2d9060b 100644 --- a/src/image.c +++ b/src/image.c @@ -4308,7 +4308,7 @@ xpm_load_image (struct frame *f, return 1; failure: - image_error ("Invalid XPM file (%s)", img->spec); + image_error ("Invalid XPM3 file (%s)", img->spec); x_destroy_x_image (ximg); x_destroy_x_image (mask_img); x_clear_image (f, img); -- 2.18.0 --6c2NcOVqGQ03X4Wi--