From: Alan Third <alan@idiocy.org>
To: Devon Sean McCullough <Emacs-Hacker2018@jovi.net>
Cc: 33126@debbugs.gnu.org
Subject: bug#33126: 26.1; xpm2 broken in MacOSX
Date: Wed, 24 Oct 2018 12:17:36 +0100 [thread overview]
Message-ID: <20181024111736.GC40431@breton.holly.idiocy.org> (raw)
In-Reply-To: <BF7268AB-C3A1-4FBA-9030-E300CB169FAC@jovi.net>
[-- Attachment #1: Type: text/plain, Size: 658 bytes --]
On Tue, Oct 23, 2018 at 10:02:06PM +0800, Devon Sean McCullough wrote:
> ; This code inserts four images
> ; 1 - a correct checkerboard
> ; 2 - an incorrect blank image of the wrong size
> ; 3 - a correct "blarg"
> ; 4 - a correct checkerboard
> ; but the middle two images should look identical.
Confirmed. I found this in image.c:
/* XPM support functions for NS where libxpm is not available.
Only XPM version 3 (without any extensions) is supported. */
I suppose to get xpm2 support you’ll have to find a version of libxpm
somewhere.
There is an error logged in *Messages*, perhaps it should specify XPM3
per the attached patch.
--
Alan Third
[-- Attachment #2: 0001-Improve-XPM-load-failure-message-bug-33126.patch --]
[-- Type: text/plain, Size: 758 bytes --]
From 9d9b85529bbd560305e4bcc3823aad23e393ee74 Mon Sep 17 00:00:00 2001
From: Alan Third <alan@idiocy.org>
Date: Wed, 24 Oct 2018 12:15:16 +0100
Subject: [PATCH] Improve XPM load failure message (bug#33126)
* src/image.c (xpm_load_image): Only XPM3 is supported, so make that
explicit.
---
src/image.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/src/image.c b/src/image.c
index 767979e63b..a6b2d9060b 100644
--- a/src/image.c
+++ b/src/image.c
@@ -4308,7 +4308,7 @@ xpm_load_image (struct frame *f,
return 1;
failure:
- image_error ("Invalid XPM file (%s)", img->spec);
+ image_error ("Invalid XPM3 file (%s)", img->spec);
x_destroy_x_image (ximg);
x_destroy_x_image (mask_img);
x_clear_image (f, img);
--
2.18.0
next prev parent reply other threads:[~2018-10-24 11:17 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-10-23 14:02 bug#33126: 26.1; xpm2 broken in MacOSX Devon Sean McCullough
2018-10-24 11:17 ` Alan Third [this message]
2018-10-24 15:06 ` Eli Zaretskii
2018-10-25 10:04 ` Alan Third
2018-10-25 13:20 ` Eli Zaretskii
2018-10-25 15:15 ` Alan Third
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20181024111736.GC40431@breton.holly.idiocy.org \
--to=alan@idiocy.org \
--cc=33126@debbugs.gnu.org \
--cc=Emacs-Hacker2018@jovi.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this external index
https://git.savannah.gnu.org/cgit/emacs.git
https://git.savannah.gnu.org/cgit/emacs/org-mode.git
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.