From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!.POSTED!not-for-mail From: Alan Mackenzie Newsgroups: gmane.emacs.devel Subject: Re: [Emacs-diffs] master 7cfe2dc: In edebug in GUIs, move focus to the selected frame. Date: Fri, 19 Oct 2018 18:49:17 +0000 Message-ID: <20181019184916.GA6639@ACM> References: <20181019175416.10874.88992@vcs0.savannah.gnu.org> <20181019175418.27D6920407@vcs0.savannah.gnu.org> NNTP-Posting-Host: blaine.gmane.org Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii X-Trace: blaine.gmane.org 1539975381 17187 195.159.176.226 (19 Oct 2018 18:56:21 GMT) X-Complaints-To: usenet@blaine.gmane.org NNTP-Posting-Date: Fri, 19 Oct 2018 18:56:21 +0000 (UTC) User-Agent: Mutt/1.10.1 (2018-07-13) Cc: emacs-devel@gnu.org To: Stefan Monnier Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Fri Oct 19 20:56:16 2018 Return-path: Envelope-to: ged-emacs-devel@m.gmane.org Original-Received: from lists.gnu.org ([208.118.235.17]) by blaine.gmane.org with esmtp (Exim 4.84_2) (envelope-from ) id 1gDZwV-0004Lw-Tk for ged-emacs-devel@m.gmane.org; Fri, 19 Oct 2018 20:56:16 +0200 Original-Received: from localhost ([::1]:52241 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1gDZyc-0005xM-5S for ged-emacs-devel@m.gmane.org; Fri, 19 Oct 2018 14:58:26 -0400 Original-Received: from eggs.gnu.org ([2001:4830:134:3::10]:54711) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1gDZy1-00052j-5m for emacs-devel@gnu.org; Fri, 19 Oct 2018 14:57:49 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1gDZxw-0004rP-3x for emacs-devel@gnu.org; Fri, 19 Oct 2018 14:57:49 -0400 Original-Received: from colin.muc.de ([193.149.48.1]:24596 helo=mail.muc.de) by eggs.gnu.org with smtp (Exim 4.71) (envelope-from ) id 1gDZxv-0004Wl-9p for emacs-devel@gnu.org; Fri, 19 Oct 2018 14:57:44 -0400 Original-Received: (qmail 71211 invoked by uid 3782); 19 Oct 2018 18:57:37 -0000 Original-Received: from acm.muc.de (p5B147207.dip0.t-ipconnect.de [91.20.114.7]) by colin.muc.de (tmda-ofmipd) with ESMTP; Fri, 19 Oct 2018 20:57:36 +0200 Original-Received: (qmail 5834 invoked by uid 1000); 19 Oct 2018 18:49:17 -0000 Content-Disposition: inline In-Reply-To: X-Delivery-Agent: TMDA/1.1.12 (Macallan) X-Primary-Address: acm@muc.de X-detected-operating-system: by eggs.gnu.org: FreeBSD 9.x [fuzzy] X-Received-From: 193.149.48.1 X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Original-Sender: "Emacs-devel" Xref: news.gmane.org gmane.emacs.devel:230503 Archived-At: Hello, Stefan. On Fri, Oct 19, 2018 at 13:58:44 -0400, Stefan Monnier wrote: > Hi Alan, > > (edebug-pop-to-buffer edebug-buffer) > > + (edebug-focus-frame (window-frame (selected-window))) > [...] > > - (edebug-pop-to-buffer edebug-buffer (car edebug-window-data))))) > > + (edebug-pop-to-buffer edebug-buffer (car edebug-window-data)) > > + (edebug-focus-frame (window-frame (selected-window)))))) > [...] > > - (edebug-pop-to-buffer edebug-eval-buffer)) > > + (edebug-pop-to-buffer edebug-eval-buffer) > > + (edebug-focus-frame (window-frame (selected-window)))) > Maybe edebug-pop-to-buffer should call edebug-focus-frame? I thought about that, but in the end decided that could be a bit heavy for when information is only being displayed, i.e. in edebug-trace-display. Maybe putting the call in e-pop-to-buffer would indeed be better. But I think edebug-trace-display would have then to call edebug-focus-frame explicitly after re-selecting the original window. This bit of the code surely originates from the time before frames were implemented. > Stefan -- Alan Mackenzie (Nuremberg, Germany).