all messages for Emacs-related lists mirrored at yhetil.org
 help / color / mirror / code / Atom feed
From: Alan Mackenzie <acm@muc.de>
To: Eli Zaretskii <eliz@gnu.org>
Cc: 32848@debbugs.gnu.org, andlind@gmail.com, darkfeline@felesatra.moe
Subject: bug#32848: 26.1; follow-mode cursor move breaks with frame-resize-pixelwise
Date: Mon, 15 Oct 2018 09:23:41 +0000	[thread overview]
Message-ID: <20181015092341.GA5623@ACM> (raw)
In-Reply-To: <8336tp4w3y.fsf@gnu.org>

Hello, Eli.

It's been a couple of weeks since your last post, which I'm only just now
answering, so here's a quick summary:

1. Original bug: in follow mode, moving point into a partially displayed
line at end-of-window, then onto the next line, caused the LH window to
scroll up rather than point being moved into the RH window.

2. I wrote a patch to follow-mode (now installed on the emacs-26 branch)
which would move point away from that critical line, allowing follow-mode
to work.

3. You wrote a patch to the C code (now installed on master) whereby
make-cursor-line-fully-visible can be a function.  I wrote a function for
this (not yet installed) which returned nil for non-last follow windows.

4. The strategy in 3. was problematic, since C-x o into a follow window
where point was on the partially displayed last line wouldn't work -
follow-mode moved the cursor back into the original window.

5. I suggested that we use the solution in 2. for master, too, discarding
3.  You countered by asking what would happen if a window's first line is
taller than the window.  (See below.)

On Mon, Oct 01, 2018 at 16:47:29 +0300, Eli Zaretskii wrote:
> > Date: Mon, 1 Oct 2018 12:33:36 +0000
> > Cc: 32848@debbugs.gnu.org, andlind@gmail.com, darkfeline@felesatra.moe
> > From: Alan Mackenzie <acm@muc.de>

> > > But on master, I think we need both this patch and a special function
> > > that sets make-cursor-line-fully-visible nil in non-last windows under
> > > follow-mode, because that's definitely what follow-mode wants.

> > I don't understand what this would be for.  With my patch from the last
> > post, I don't think any window's point would ever be left by follow-mode
> > in a partially displayed line.  Maybe the function I've written
> > (follow-make-cursor-line-fully-visible-p) might be useful sometime in
> > the future.

> Did you try a buffer whose first line is very tall, taller than the
> window?

I've tried a few ways of getting such a window, but without luck.  Emacs
is very good at making sure a window is no smaller than one line tall.
;-)

Is it possible to create such a line in a window, probably with lisp?  Or
was your question more a prompt to me to handle this unlikely situation
gracefully?

-- 
Alan Mackenzie (Nuremberg, Germany).





  reply	other threads:[~2018-10-15  9:23 UTC|newest]

Thread overview: 29+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-09-26 22:49 bug#32848: 26.1; follow-mode cursor move breaks with frame-resize-pixelwise Allen Li
2018-09-27  6:04 ` Eli Zaretskii
2018-09-27  8:06 ` Eli Zaretskii
2018-09-28 20:31   ` Alan Mackenzie
2018-09-28 21:27     ` Eli Zaretskii
2018-09-29  8:35       ` Alan Mackenzie
2018-09-29 10:26         ` Eli Zaretskii
2018-09-29 11:25           ` Alan Mackenzie
2018-09-29 13:47             ` Eli Zaretskii
2018-09-29 13:56               ` Eli Zaretskii
2018-09-29 14:48               ` Alan Mackenzie
2018-09-29 15:06                 ` Eli Zaretskii
2018-09-29 20:25                   ` Alan Mackenzie
2018-09-30  5:30                     ` Eli Zaretskii
2018-09-30 11:16                       ` Eli Zaretskii
2018-09-30 12:16                         ` Alan Mackenzie
2018-09-30 12:56                           ` Eli Zaretskii
2018-09-30 14:09                             ` Alan Mackenzie
2018-09-30 17:00                               ` Eli Zaretskii
2018-10-01 12:33                                 ` Alan Mackenzie
2018-10-01 13:47                                   ` Eli Zaretskii
2018-10-15  9:23                                     ` Alan Mackenzie [this message]
2018-10-15 15:07                                       ` Eli Zaretskii
2018-10-15 17:26                                         ` Alan Mackenzie
2018-10-15 18:02                                           ` Eli Zaretskii
2018-09-30 11:02   ` Alan Mackenzie
2018-09-30 11:24     ` Eli Zaretskii
2018-09-30 13:55       ` Alan Mackenzie
2018-10-17 10:17   ` Alan Mackenzie

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20181015092341.GA5623@ACM \
    --to=acm@muc.de \
    --cc=32848@debbugs.gnu.org \
    --cc=andlind@gmail.com \
    --cc=darkfeline@felesatra.moe \
    --cc=eliz@gnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this external index

	https://git.savannah.gnu.org/cgit/emacs.git
	https://git.savannah.gnu.org/cgit/emacs/org-mode.git

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.