From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!.POSTED!not-for-mail From: "T.V Raman" Newsgroups: gmane.emacs.devel Subject: shr-copy-url: arg misnamed? Date: Sat, 22 Sep 2018 09:12:18 -0700 (PDT) Message-ID: <20180922161218.BA963C20207@raman-glaptop.localdomain> NNTP-Posting-Host: blaine.gmane.org X-Trace: blaine.gmane.org 1537633257 17442 195.159.176.226 (22 Sep 2018 16:20:57 GMT) X-Complaints-To: usenet@blaine.gmane.org NNTP-Posting-Date: Sat, 22 Sep 2018 16:20:57 +0000 (UTC) To: emacs-devel@gnu.org Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Sat Sep 22 18:20:53 2018 Return-path: Envelope-to: ged-emacs-devel@m.gmane.org Original-Received: from lists.gnu.org ([208.118.235.17]) by blaine.gmane.org with esmtp (Exim 4.84_2) (envelope-from ) id 1g3keL-0004Vw-M9 for ged-emacs-devel@m.gmane.org; Sat, 22 Sep 2018 18:20:53 +0200 Original-Received: from localhost ([::1]:35964 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1g3kgS-0000w9-Bu for ged-emacs-devel@m.gmane.org; Sat, 22 Sep 2018 12:23:04 -0400 Original-Received: from eggs.gnu.org ([2001:4830:134:3::10]:42493) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1g3kfb-0000fy-6W for emacs-devel@gnu.org; Sat, 22 Sep 2018 12:22:14 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1g3kW7-0001ix-Pg for emacs-devel@gnu.org; Sat, 22 Sep 2018 12:12:27 -0400 Original-Received: from mail-pg1-x52e.google.com ([2607:f8b0:4864:20::52e]:38069) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1g3kW7-0001h0-J1 for emacs-devel@gnu.org; Sat, 22 Sep 2018 12:12:23 -0400 Original-Received: by mail-pg1-x52e.google.com with SMTP id r77-v6so2243656pgr.5 for ; Sat, 22 Sep 2018 09:12:23 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20161025; h=from:to:subject:message-id:date; bh=XeRmO/wOx1uQ5B4aEKlKCVwGnoOU8zlIeJTv+AtWVJI=; b=SbRtulXxH6nSTap8mcc+PLurJWMSsMeKdWAaXzwk2yzsZuyLMfK10k9fFxnw3Oaxtt aS1dw9XGpICX9e065xh8cEyCj/CzTiejyujRQP7ynRw1gl+OFcGhJ3I6EMHLM20xCaX+ UgyR80yLpCfWnDrNz2Ayqcj7Cb/4yhLDkKJwpstsA3EaoYmxzMQ0O2wEFVmYJkPJv0MZ z/W67JTdbJSaVAFuEovPR4KMDoUZJ+/7ActGDTapSc3yr0eDjnWHgz0+4f9AIYTvuXOV df0KRbtLHKIRtG637qFSN0creh4SAErlT/DfdiwZZ1x5lJAXLg1d33N1WDYGAP4/ihf6 3Kyw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:subject:message-id:date; bh=XeRmO/wOx1uQ5B4aEKlKCVwGnoOU8zlIeJTv+AtWVJI=; b=YnrornE1Bp2swbqrk037+LraU/AnALxZ5PSf7n3ac9Rov6QNGel1TB8jFQXj43CnzX /3h+tsiU7d7+whP9YgSKcBGgeR7B2vFeKzPW02hie0PV6A6XLrIWwMt5wz9JWxNAIa9s kQNXgFUwtAZmuegnwIics4KCQSST5qh9NgERHc6Bk0NBPOsDWY25TX1GX/YgVWK6vZh0 zTqUPcfeB63d6ezd2El1SX/GCvTQGBMIEyRtQbqg1SxBSw5kcHnMg5BDgMGgAawB3AwQ n3R0dBbb100oGv8PqDE20vmcP9SIEE1hPs8FWMs8E1K79ZQfoWsn6QP81CE5Pji94cbU wZIQ== X-Gm-Message-State: APzg51A6tPw+l+vcXNLuFavBB3h3x8XZfczqmr6aG/Bs1G7Rczr3Z2Da sMms0CJ1ApsVhQOdZIrG5ecIB5rbSCE= X-Google-Smtp-Source: ANB0VdY4DtJMGaaY8FOMsYs/e8SCtWHBbEuAl3coi8teBG3IZa9zGHgWDGaNyUd38sFJuYr/y3WDwA== X-Received: by 2002:a62:9894:: with SMTP id d20-v6mr3123619pfk.186.1537632741235; Sat, 22 Sep 2018 09:12:21 -0700 (PDT) Original-Received: from raman-glaptop.localdomain (c-24-4-174-65.hsd1.ca.comcast.net. [24.4.174.65]) by smtp.gmail.com with ESMTPSA id s85-v6sm51965662pfa.116.2018.09.22.09.12.20 (version=TLS1_2 cipher=ECDHE-RSA-CHACHA20-POLY1305 bits=256/256); Sat, 22 Sep 2018 09:12:20 -0700 (PDT) Original-Received: by raman-glaptop.localdomain (Postfix, from userid 13930) id BA963C20207; Sat, 22 Sep 2018 09:12:18 -0700 (PDT) X-detected-operating-system: by eggs.gnu.org: Genre and OS details not recognized. X-Received-From: 2607:f8b0:4864:20::52e X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Original-Sender: "Emacs-devel" Xref: news.gmane.org gmane.emacs.devel:229994 Archived-At: Should the arg in this function be renamed? The name "url" is confusing, and is likely being shadowed (defun shr-copy-url (url) "Copy the URL under point to the kill ring. If IMAGE-URL (the prefix) is non-nil, or there is no link under point, but there is an image under point then copy the URL of the image under point instead." (interactive (list (shr-url-at-point current-prefix-arg))) (if (not url) (message "No URL under point") (setq url (url-encode-url url)) (kill-new url) (message "Copied %s" url))) -- --