From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!.POSTED!not-for-mail From: Tak Kunihiro Newsgroups: gmane.emacs.bugs Subject: bug#31905: detection of edge of highlighted text by mouse-drag-and-drop-region Date: Wed, 20 Jun 2018 08:25:41 +0900 (JST) Message-ID: <20180620.082541.1223268284350863328.tkk@misasa.okayama-u.ac.jp> NNTP-Posting-Host: blaine.gmane.org Mime-Version: 1.0 Content-Type: Multipart/Mixed; boundary="--Next_Part(Wed_Jun_20_08_25_41_2018_724)--" Content-Transfer-Encoding: 7bit X-Trace: blaine.gmane.org 1529452085 24926 195.159.176.226 (19 Jun 2018 23:48:05 GMT) X-Complaints-To: usenet@blaine.gmane.org NNTP-Posting-Date: Tue, 19 Jun 2018 23:48:05 +0000 (UTC) Cc: tkk@misasa.okayama-u.ac.jp To: 31905@debbugs.gnu.org Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Wed Jun 20 01:48:01 2018 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane.org Original-Received: from lists.gnu.org ([208.118.235.17]) by blaine.gmane.org with esmtp (Exim 4.84_2) (envelope-from ) id 1fVQLx-0006N0-0W for geb-bug-gnu-emacs@m.gmane.org; Wed, 20 Jun 2018 01:48:01 +0200 Original-Received: from localhost ([::1]:45397 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1fVQO4-0004So-2l for geb-bug-gnu-emacs@m.gmane.org; Tue, 19 Jun 2018 19:50:12 -0400 Original-Received: from eggs.gnu.org ([2001:4830:134:3::10]:46697) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1fVQNx-0004Sh-KC for bug-gnu-emacs@gnu.org; Tue, 19 Jun 2018 19:50:06 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1fVQNu-00052n-FQ for bug-gnu-emacs@gnu.org; Tue, 19 Jun 2018 19:50:05 -0400 Original-Received: from debbugs.gnu.org ([208.118.235.43]:48833) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1fVQNu-00052M-BA for bug-gnu-emacs@gnu.org; Tue, 19 Jun 2018 19:50:02 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1fVQNt-0008Gc-VF for bug-gnu-emacs@gnu.org; Tue, 19 Jun 2018 19:50:02 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Tak Kunihiro Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Tue, 19 Jun 2018 23:50:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: report 31905 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: X-Debbugs-Original-To: bug-gnu-emacs@gnu.org Original-Received: via spool by submit@debbugs.gnu.org id=B.152945215131717 (code B ref -1); Tue, 19 Jun 2018 23:50:01 +0000 Original-Received: (at submit) by debbugs.gnu.org; 19 Jun 2018 23:49:11 +0000 Original-Received: from localhost ([127.0.0.1]:56730 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1fVQN4-0008FU-Oc for submit@debbugs.gnu.org; Tue, 19 Jun 2018 19:49:10 -0400 Original-Received: from eggs.gnu.org ([208.118.235.92]:55118) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1fVQN3-0008FI-2M for submit@debbugs.gnu.org; Tue, 19 Jun 2018 19:49:09 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1fVQMx-0004JD-2z for submit@debbugs.gnu.org; Tue, 19 Jun 2018 19:49:03 -0400 Original-Received: from lists.gnu.org ([2001:4830:134:3::11]:42774) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_256_CBC_SHA1:32) (Exim 4.71) (envelope-from ) id 1fVQMw-0004J6-U8 for submit@debbugs.gnu.org; Tue, 19 Jun 2018 19:49:02 -0400 Original-Received: from eggs.gnu.org ([2001:4830:134:3::10]:46078) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1fVQMv-0003uA-Jz for bug-gnu-emacs@gnu.org; Tue, 19 Jun 2018 19:49:02 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1fVQMs-0004F5-Gb for bug-gnu-emacs@gnu.org; Tue, 19 Jun 2018 19:49:01 -0400 Original-Received: from mxl069v66.mxlogic.net ([208.81.69.66]:26951 helo=s18p02o143.mxlogic.net) by eggs.gnu.org with esmtps (TLS1.0:DHE_RSA_AES_256_CBC_SHA1:32) (Exim 4.71) (envelope-from ) id 1fVQMr-0004Ab-RQ for bug-gnu-emacs@gnu.org; Tue, 19 Jun 2018 19:48:58 -0400 Original-Received: from unknown [42.127.236.175] (EHLO mlsec.cc.okayama-u.ac.jp) by s18p02o143.mxlogic.net(mxl_mta-8.5.0-1953) with ESMTP id 966992b5.7faf057fb700.416470.00-564.756057.s18p02o143.mxlogic.net (envelope-from ); Tue, 19 Jun 2018 17:48:57 -0600 (MDT) X-MXL-Hash: 5b2996693b30865c-e11ca90bb90a539478e9b9fc488c853fdc04a249 Original-Received: from unknown [42.127.236.175] (EHLO mlsec.cc.okayama-u.ac.jp) by s18p02o143.mxlogic.net(mxl_mta-8.5.0-1953) over TLS secured channel with ESMTP id 5f0992b5.0.416139.00-376.755423.s18p02o143.mxlogic.net (envelope-from ); Tue, 19 Jun 2018 17:25:47 -0600 (MDT) X-MXL-Hash: 5b2990fb553c7aa6-f51494041f9323114a29b508eda37924b96f7e7a Original-Received: from alml002.ouadm.okayama-u.ac.jp (unknown [42.127.236.168]) by mlsec.cc.okayama-u.ac.jp with smtp id 37d9_136c_7084dd2e_03f9_4d98_9466_dcea0c412d67; Wed, 20 Jun 2018 08:25:39 +0900 Original-Received: from localhost (vesta.misasa.okayama-u.ac.jp [150.46.48.154]) by alml002.ouadm.okayama-u.ac.jp (Postfix) with ESMTPSA id 90D534C0A58; Wed, 20 Jun 2018 08:25:39 +0900 (JST) X-Mailer: Mew version 6.7 on Emacs 26 / Mule 6.0 (HANACHIRUSATO) X-NAI-Spam-Flag: NO X-NAI-Spam-Threshold: 11 X-NAI-Spam-Score: 0 X-NAI-Spam-Rules: 4 Rules triggered EDT_SA_AU_PASS=0, EDT_SA_DN_PASS=0, EDT_SA_TS_PASS=0, RV6311=0 X-NAI-Spam-Version: 2.3.0.9418 : core <6311> : inlines <6704> : streams <1790178> : uri <2660994> X-AnalysisOut: [v=2.2 cv=QMAYfkDL c=1 sm=1 tr=0 a=8LLPK8U+aGQ6qN8QlyMYtQ==] X-AnalysisOut: [:117 a=8LLPK8U+aGQ6qN8QlyMYtQ==:17 a=7mUfYlMuFuIA:10 a=jZS] X-AnalysisOut: [YtAv4R9s3N80Ab0QA:9 a=CjuIK1q_8ugA:10 a=OotNiglPQKemMJqdKi] X-AnalysisOut: [EA:9] X-Spam: [F=0.5000000000; CM=0.500; MH=0.500(2018061916); S=0.200(2015072901)] X-MAIL-FROM: X-SOURCE-IP: [42.127.236.175] X-detected-operating-system: by eggs.gnu.org: GNU/Linux 3.x [fuzzy] X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.6.x X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 208.118.235.43 X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.org gmane.emacs.bugs:147635 Archived-At: ----Next_Part(Wed_Jun_20_08_25_41_2018_724)-- Content-Type: Text/Plain; charset=us-ascii Content-Transfer-Encoding: 7bit I found bug on `mouse-drag-and-drop-region'. The `mouse-drag-and-drop-region' does not recognize the beginning and the end of highlighted text as pre existing region. 1: emacs -Q 2: (setq mouse-drag-and-drop-region 'meta) 2: Select text on a buffer and have a region. Let's assume `This buffer' is highlighted. 3: Drag and drop the text onto the first character of the region, that is `T'. 4: Then the text `This buffer' would be disappeared. I attach a patch to fix the bug. This patch is relative to 26.1.50. * Commit log Author: Tak Kunihiro Fix bug of 'mouse-drag-and-drop-region' to detect edges of region * lisp/mouse.el (mouse-drag-and-drop-region): Detect both the beginning and the end of character of region during dragging text. ----Next_Part(Wed_Jun_20_08_25_41_2018_724)-- Content-Type: Text/X-Patch; charset=us-ascii Content-Transfer-Encoding: 7bit Content-Disposition: inline; filename="mouse.el.diff" diff --git a/lisp/mouse.el b/lisp/mouse.el index 5c9056fb43..f749d12054 100644 --- a/lisp/mouse.el +++ b/lisp/mouse.el @@ -2515,9 +2515,9 @@ mouse-drag-and-drop-region (setq drag-but-negligible (and (eq (overlay-buffer mouse-drag-and-drop-overlay) buffer-to-paste) - (< (overlay-start mouse-drag-and-drop-overlay) + (<= (overlay-start mouse-drag-and-drop-overlay) point-to-paste) - (< point-to-paste + (<= point-to-paste (overlay-end mouse-drag-and-drop-overlay))))) ;; Show a tooltip. ----Next_Part(Wed_Jun_20_08_25_41_2018_724)----