bug#31905: detection of edge of highlighted text by mouse-drag-and-drop-region

bug#31905: detection of edge of highlighted text by mouse-drag-and-drop-region

[Tak Kunihiro]

[-- Attachment #1: Type: Text/Plain, Size: 797 bytes --]

I found bug on `mouse-drag-and-drop-region'.  The
`mouse-drag-and-drop-region' does not recognize the beginning and the
end of highlighted text as pre existing region.

1: emacs -Q
2: (setq mouse-drag-and-drop-region 'meta)
2: Select text on a buffer and have a region. Let's assume `This buffer' is highlighted.
3: Drag and drop the text onto the first character of the region, that is `T'.
4: Then the text `This buffer' would be disappeared.

I attach a patch to fix the bug.  This patch is relative to 26.1.50.

* Commit log

Author: Tak Kunihiro <tkk@misasa.okayama-u.ac.jp>

    Fix bug of 'mouse-drag-and-drop-region' to detect edges of region
    
    * lisp/mouse.el
    (mouse-drag-and-drop-region): Detect both the beginning and the
    end of character of region during dragging text.

[-- Attachment #2: mouse.el.diff --]
[-- Type: Text/X-Patch, Size: 701 bytes --]

diff --git a/lisp/mouse.el b/lisp/mouse.el
index 5c9056fb43..f749d12054 100644
--- a/lisp/mouse.el
+++ b/lisp/mouse.el
@@ -2515,9 +2515,9 @@ mouse-drag-and-drop-region
             (setq drag-but-negligible
                   (and (eq (overlay-buffer mouse-drag-and-drop-overlay)
                            buffer-to-paste)
-                       (< (overlay-start mouse-drag-and-drop-overlay)
+                       (<= (overlay-start mouse-drag-and-drop-overlay)
                           point-to-paste)
-                       (< point-to-paste
+                       (<= point-to-paste
                           (overlay-end mouse-drag-and-drop-overlay)))))
 
           ;; Show a tooltip.

bug#31905: detection of edge of highlighted text by mouse-drag-and-drop-region

[martin rudalics]

 > I found bug on `mouse-drag-and-drop-region'.  The
 > `mouse-drag-and-drop-region' does not recognize the beginning and the
 > end of highlighted text as pre existing region.
 >
 > 1: emacs -Q
 > 2: (setq mouse-drag-and-drop-region 'meta)
 > 2: Select text on a buffer and have a region. Let's assume `This buffer' is highlighted.
 > 3: Drag and drop the text onto the first character of the region, that is `T'.
 > 4: Then the text `This buffer' would be disappeared.

Indeed.

 > I attach a patch to fix the bug.  This patch is relative to 26.1.50.

I verified that it corrects the behavior and applied it to the release
branch.  Please countercheck and close the bug if everything is right.

Thank you, martin

bug#31905: Re: detection of edge of highlighted text by mouse-drag-and-drop-region

[Tak Kunihiro]

tags 31905 fixed
close 31905 26.2
quit

From: martin rudalics <rudalics@gmx.at>
Subject: Re: detection of edge of highlighted text by mouse-drag-and-drop-region
Date: Wed, 20 Jun 2018 09:42:47 +0200

>> I found bug on `mouse-drag-and-drop-region'.  The
>> `mouse-drag-and-drop-region' does not recognize the beginning and the
>> end of highlighted text as pre existing region.
>>
>> 1: emacs -Q
>> 2: (setq mouse-drag-and-drop-region 'meta)
>> 2: Select text on a buffer and have a region. Let's assume `This
>> buffer' is highlighted.
>> 3: Drag and drop the text onto the first character of the region, that
>> is `T'.
>> 4: Then the text `This buffer' would be disappeared.
> 
> Indeed.
> 
>> I attach a patch to fix the bug.  This patch is relative to 26.1.50.
> 
> I verified that it corrects the behavior and applied it to the release
> branch.  Please countercheck and close the bug if everything is right.
> 
> Thank you, martin