From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!.POSTED!not-for-mail From: Alan Third Newsgroups: gmane.emacs.bugs Subject: bug#31440: Can't redefine parent-frame on NS Date: Sun, 13 May 2018 10:40:54 +0100 Message-ID: <20180513094054.GA15823@breton.holly.idiocy.org> NNTP-Posting-Host: blaine.gmane.org Mime-Version: 1.0 Content-Type: multipart/mixed; boundary="AhhlLboLdkugWU4S" Content-Transfer-Encoding: 8bit X-Trace: blaine.gmane.org 1526204405 7272 195.159.176.226 (13 May 2018 09:40:05 GMT) X-Complaints-To: usenet@blaine.gmane.org NNTP-Posting-Date: Sun, 13 May 2018 09:40:05 +0000 (UTC) User-Agent: Mutt/1.9.3 (2018-01-21) To: 31440@debbugs.gnu.org Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Sun May 13 11:40:01 2018 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane.org Original-Received: from lists.gnu.org ([208.118.235.17]) by blaine.gmane.org with esmtp (Exim 4.84_2) (envelope-from ) id 1fHnU0-0001ji-Jz for geb-bug-gnu-emacs@m.gmane.org; Sun, 13 May 2018 11:40:00 +0200 Original-Received: from localhost ([::1]:55812 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1fHnW6-0004TV-6t for geb-bug-gnu-emacs@m.gmane.org; Sun, 13 May 2018 05:42:10 -0400 Original-Received: from eggs.gnu.org ([2001:4830:134:3::10]:38063) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1fHnVy-0004MB-UF for bug-gnu-emacs@gnu.org; Sun, 13 May 2018 05:42:03 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1fHnVy-0008Vm-5F for bug-gnu-emacs@gnu.org; Sun, 13 May 2018 05:42:02 -0400 Original-Received: from debbugs.gnu.org ([208.118.235.43]:52289) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1fHnVy-0008Vi-0x for bug-gnu-emacs@gnu.org; Sun, 13 May 2018 05:42:02 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1fHnVx-00049N-Nq for bug-gnu-emacs@gnu.org; Sun, 13 May 2018 05:42:01 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Alan Third Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Sun, 13 May 2018 09:42:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: report 31440 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: X-Debbugs-Original-To: bug-gnu-emacs@gnu.org Original-Received: via spool by submit@debbugs.gnu.org id=B.152620447015893 (code B ref -1); Sun, 13 May 2018 09:42:01 +0000 Original-Received: (at submit) by debbugs.gnu.org; 13 May 2018 09:41:10 +0000 Original-Received: from localhost ([127.0.0.1]:60186 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1fHnV8-00048H-8a for submit@debbugs.gnu.org; Sun, 13 May 2018 05:41:10 -0400 Original-Received: from eggs.gnu.org ([208.118.235.92]:46824) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1fHnV6-000485-E3 for submit@debbugs.gnu.org; Sun, 13 May 2018 05:41:08 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1fHnV0-00089q-Fg for submit@debbugs.gnu.org; Sun, 13 May 2018 05:41:03 -0400 Original-Received: from lists.gnu.org ([2001:4830:134:3::11]:59897) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_256_CBC_SHA1:32) (Exim 4.71) (envelope-from ) id 1fHnV0-00089V-At for submit@debbugs.gnu.org; Sun, 13 May 2018 05:41:02 -0400 Original-Received: from eggs.gnu.org ([2001:4830:134:3::10]:37793) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1fHnUz-0005hH-1u for bug-gnu-emacs@gnu.org; Sun, 13 May 2018 05:41:02 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1fHnUy-000888-1V for bug-gnu-emacs@gnu.org; Sun, 13 May 2018 05:41:01 -0400 Original-Received: from mail-wr0-x231.google.com ([2a00:1450:400c:c0c::231]:38974) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1fHnUx-00087t-OJ for bug-gnu-emacs@gnu.org; Sun, 13 May 2018 05:40:59 -0400 Original-Received: by mail-wr0-x231.google.com with SMTP id q3-v6so9260951wrj.6 for ; Sun, 13 May 2018 02:40:59 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=googlemail.com; s=20161025; h=sender:date:from:to:subject:message-id:mime-version :content-disposition:content-transfer-encoding:user-agent; bh=oaZV7ONT+H58NMDyGXMm+oYb+Qa5RoTwKPIjR6XFBTA=; b=JKZmTEIUoHbZdroJkwHkcYj7BEOgZI5GWhi/0RiPGfxsQkY+nxW0XlI50Z9bCuco6c w15hQZAG0N0x+kKDGYooCLdcxBJjmFOeDCYlfpLeNUAjLbxzifLmb+VTY8NlBCZTJl6z TgOpL3Btk9/yvtRafzKQomhGF94lZqIjl9oeUmz9amEu+11nS+px0CA6+GwqCpr0OeCy DTwBUAfuOAaCrVJEmZ+R9Uqf0WijwbzKwTR/YYXFLAvcQKQMZLLoj8uRgS3c+OLvEDzD 6RHML4cuFSbyFM1dgxyfe4PHsB+simLJDq9pY9Ntlv+Q9hKr7KIoCy+8dqcvNR3VtoOz /BTQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:sender:date:from:to:subject:message-id :mime-version:content-disposition:content-transfer-encoding :user-agent; bh=oaZV7ONT+H58NMDyGXMm+oYb+Qa5RoTwKPIjR6XFBTA=; b=OIB+UUZzNSD2sfoZMB22V4nt1ZU8yehEE9RTXysSCWCbPHqSSFGeuJHJXlFjBhdWF5 un7Bjb7ohCXNylz4s7ULZYlsDhIQl4Ro8x40q2Xp2fvVpitNUlbcISU0Ez7IY44Qj/Zb Q68PEaRdgXL01Kl0TIZndwPPVIwt35sp9oESEo9l1dLuglPSRgbIJ2CCJXbpUEoMYJLY sJq4zGshysqYehn76BeqZPgWz8xwtxNarBTjUBxlCXshCkvmUMOVCmU6D35jKkNuqlAS Tuu8JLmNcfxicW4i+11oQ8f2czzHrh9HMPZo04cwEWOoeS0UA1nbgksCsChDoBTkOT2H /jkw== X-Gm-Message-State: ALKqPwdCkFkxtalscQBgwifRbzvEP4RPuURhFz/XLKSfHH1Rdb2XuRXL So915OwrybKAqIKViMxm1bJGOZx0 X-Google-Smtp-Source: AB8JxZpybB3FeIO6/MR/Cp1NlBwvzr4NtPhTE6ZPQx3MdbeChJer9sdpAy6FXSGAUzasN1ykQZBAyw== X-Received: by 2002:adf:a075:: with SMTP id l50-v6mr4262142wrl.227.1526204458156; Sun, 13 May 2018 02:40:58 -0700 (PDT) Original-Received: from breton.holly.idiocy.org (ip6-2001-08b0-03f8-8129-3195-ed66-b02d-6c9f.holly.idiocy.org. [2001:8b0:3f8:8129:3195:ed66:b02d:6c9f]) by smtp.gmail.com with ESMTPSA id q34-v6sm8898757wrb.27.2018.05.13.02.40.56 for (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Sun, 13 May 2018 02:40:56 -0700 (PDT) Content-Disposition: inline X-detected-operating-system: by eggs.gnu.org: Genre and OS details not recognized. X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.6.x X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 208.118.235.43 X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.org gmane.emacs.bugs:146143 Archived-At: --AhhlLboLdkugWU4S Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit from emacs -Q: set up three frames, a, b and c: (set-frame-parameter c 'parent-frame a) c becomes child of a. (set-frame-parameter c 'parent-frame b) expected: c becomes child of b and is no longer child of a. actual: c remains child of a, and b now cannot be raised above a and b. (set-frame-parameter c 'parent-frame nil) expected: c ceases to be a child frame. actual: emacs crashes. Patch attached. If this is too late for 26.1 I don’t think that will be a huge issue as it seems redefining parent-frame is not something people want to do, and it’s unlikely to be something a user does by accident. -- Alan Third --AhhlLboLdkugWU4S Content-Type: text/plain; charset=us-ascii Content-Disposition: attachment; filename="0001-Fix-redefinition-of-child-frames-on-NS.patch" >From a33d6248a7369fc18111e42b6157a6bf84c5578a Mon Sep 17 00:00:00 2001 From: Alan Third Date: Sun, 13 May 2018 10:33:44 +0100 Subject: [PATCH] Fix redefinition of child frames on NS * src/nsterm.m (x_set_parent_frame): If the NSWindow has an existing parent frame, remove it. --- src/nsterm.m | 16 ++++++++++++---- 1 file changed, 12 insertions(+), 4 deletions(-) diff --git a/src/nsterm.m b/src/nsterm.m index c8ae31abc0..df883346de 100644 --- a/src/nsterm.m +++ b/src/nsterm.m @@ -1958,12 +1958,20 @@ so some key presses (TAB) are swallowed by the system. */ if (p != FRAME_PARENT_FRAME (f)) { - parent = [FRAME_NS_VIEW (p) window]; + block_input (); child = [FRAME_NS_VIEW (f) window]; - block_input (); - [parent addChildWindow: child - ordered: NSWindowAbove]; + if ([child parentWindow] != nil) + [[child parentWindow] removeChildWindow:child]; + + if (!NILP (new_value)) + { + parent = [FRAME_NS_VIEW (p) window]; + + [parent addChildWindow: child + ordered: NSWindowAbove]; + } + unblock_input (); fset_parent_frame (f, new_value); -- 2.16.1 --AhhlLboLdkugWU4S--