From mboxrd@z Thu Jan 1 00:00:00 1970
Path: news.gmane.org!.POSTED!not-for-mail
From: Philipp Stephani
Newsgroups: gmane.emacs.devel
Subject: [PATCH 2/3] Don't print "process finished" into the stderr buffer.
Date: Wed, 4 Apr 2018 14:02:17 +0200
Message-ID: <20180404120218.257212-2-phst@google.com>
References: <20180404120218.257212-1-phst@google.com>
NNTP-Posting-Host: blaine.gmane.org
X-Trace: blaine.gmane.org 1522843362 30166 195.159.176.226 (4 Apr 2018 12:02:42 GMT)
X-Complaints-To: usenet@blaine.gmane.org
NNTP-Posting-Date: Wed, 4 Apr 2018 12:02:42 +0000 (UTC)
Cc: Philipp Stephani
To: emacs-devel@gnu.org
Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Wed Apr 04 14:02:38 2018
Return-path:
Envelope-to: ged-emacs-devel@m.gmane.org
Original-Received: from lists.gnu.org ([208.118.235.17])
by blaine.gmane.org with esmtp (Exim 4.84_2)
(envelope-from )
id 1f3h7d-0007hz-S2
for ged-emacs-devel@m.gmane.org; Wed, 04 Apr 2018 14:02:37 +0200
Original-Received: from localhost ([::1]:52941 helo=lists.gnu.org)
by lists.gnu.org with esmtp (Exim 4.71)
(envelope-from )
id 1f3h9h-0003Fi-MJ
for ged-emacs-devel@m.gmane.org; Wed, 04 Apr 2018 08:04:45 -0400
Original-Received: from eggs.gnu.org ([2001:4830:134:3::10]:40383)
by lists.gnu.org with esmtp (Exim 4.71)
(envelope-from ) id 1f3h8B-0002Js-Gk
for emacs-devel@gnu.org; Wed, 04 Apr 2018 08:03:17 -0400
Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
(envelope-from ) id 1f3h8A-0000RG-GU
for emacs-devel@gnu.org; Wed, 04 Apr 2018 08:03:11 -0400
Original-Received: from mail-wm0-x22b.google.com ([2a00:1450:400c:c09::22b]:38909)
by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16)
(Exim 4.71) (envelope-from )
id 1f3h8A-0000Qc-A5
for emacs-devel@gnu.org; Wed, 04 Apr 2018 08:03:10 -0400
Original-Received: by mail-wm0-x22b.google.com with SMTP id i3so18015454wmf.3
for ; Wed, 04 Apr 2018 05:03:10 -0700 (PDT)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025;
h=from:to:cc:subject:date:message-id:in-reply-to:references;
bh=rqqQJgu6RWpnMai8b/zB/HtpAL3H5v6usbZ7oLyFR0E=;
b=sUSFvs7rjbZjFLQsNsL6IAwqW1TEC44dVs3wAPjrpw+CbIipyzd28WYTJNkPDcQVag
Fx5Ozkfdg4uf1s6uZEqFj024PMW24BhcXlRA+w/YDCXWnXDDqJ0l4V2y3F3YNcoGeFbI
1Z9zOqcU1Uh3kDPzNx0tP0W8rnGTCaBNhdfGTaUgfQW1wywMiPGm7YtmnUYLoQ+0ErNh
63gDROenToY0RB5vYBYVWXSan6WZmSI3rStDpZl4jcHbRlaMcpaFV111GrQZYZ/g9B5J
0WxXzg7/qsjCF4jRxshnvzwiMpP5oORYynhzyCgA67Vctpn/OrBmpDq7ABj2KXa8u14K
brfQ==
X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
d=1e100.net; s=20161025;
h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to
:references;
bh=rqqQJgu6RWpnMai8b/zB/HtpAL3H5v6usbZ7oLyFR0E=;
b=OMTV1tFST0AuvXpMuMvdYOfogb9N05SIX8yOzckx9jBhl1N7bB+qctEfwCL1K+ptOV
nZFveSslkjzCgW1FXHktqveWgr7EHsvPYVHEAuIg2i6ik/89sxrkewD0VNDyYqdXc8dv
P2RnpQqynnDGlbQnBkOGpeTlqknQmUdFmBdeqevvn+PkGTycGbzpB3w1EgLQUqFneChe
tVHKnpYCMtFu1P+TzMVLuoQtgWdtNfkDLeETmi54hYvNbzHPnQKXeVopqkUrpdoKitSz
NM8rXUVi7nxtuD6wccmy87UXhUruxq+8nfiy+Le5LEU2q6yeRjA8jT14yO/fcK5FFZDJ
uiKA==
X-Gm-Message-State: AElRT7FPE55w4l+5h2QLhWHW1Chn1JNt9lFYGxBIh751ZKbaW60ale9o
Mb4LKgLvABXFBJqT86R3EwM4Zbsp
X-Google-Smtp-Source: AIpwx4/dQnSuBTNR7b2TDkV+oBxseV2V4BaQetu415TXy9UAkOqEKkDACU6IJe9ovFvnsCXuerkY8g==
X-Received: by 10.28.191.131 with SMTP id o3mr6534515wmi.73.1522843388905;
Wed, 04 Apr 2018 05:03:08 -0700 (PDT)
Original-Received: from phst-glaptop.cm.cablesurf.de
([2001:4c50:25c:c900:2a16:adff:fe49:52c8])
by smtp.gmail.com with ESMTPSA id
n143sm4848233wmd.29.2018.04.04.05.03.07
(version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128);
Wed, 04 Apr 2018 05:03:08 -0700 (PDT)
X-Google-Original-From: Philipp Stephani
X-Mailer: git-send-email 2.17.0.484.g0c8726318c-goog
In-Reply-To: <20180404120218.257212-1-phst@google.com>
X-detected-operating-system: by eggs.gnu.org: Genre and OS details not
recognized.
X-Received-From: 2a00:1450:400c:c09::22b
X-BeenThere: emacs-devel@gnu.org
X-Mailman-Version: 2.1.21
Precedence: list
List-Id: "Emacs development discussions."
List-Unsubscribe: ,
List-Archive:
List-Post:
List-Help:
List-Subscribe: ,
Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org
Original-Sender: "Emacs-devel"
Xref: news.gmane.org gmane.emacs.devel:224314
Archived-At:
* src/process.c (syms_of_process): Add 'ignore' symbol.
(Fmake_process): Use it as sentinel for the standard error pipe
process.
* test/src/process-tests.el (make-process/stderr-sentinel): New unit
test.
---
src/process.c | 5 ++++-
test/src/process-tests.el | 18 ++++++++++++++++++
2 files changed, 22 insertions(+), 1 deletion(-)
diff --git a/src/process.c b/src/process.c
index c357a8bdc3..dcc9dcb31e 100644
--- a/src/process.c
+++ b/src/process.c
@@ -1714,7 +1714,9 @@ usage: (make-process &rest ARGS) */)
QCbuffer,
Fget_buffer_create (xstderr),
QCnoquery,
- query_on_exit ? Qnil : Qt);
+ query_on_exit ? Qnil : Qt,
+ QCsentinel,
+ Qignore);
}
proc = make_process (name);
@@ -8184,6 +8186,7 @@ syms_of_process (void)
"internal-default-process-sentinel");
DEFSYM (Qinternal_default_process_filter,
"internal-default-process-filter");
+ DEFSYM (Qignore, "ignore");
#endif
DEFSYM (Qpri, "pri");
DEFSYM (Qnice, "nice");
diff --git a/test/src/process-tests.el b/test/src/process-tests.el
index b1b4665c3c..838ba78acb 100644
--- a/test/src/process-tests.el
+++ b/test/src/process-tests.el
@@ -199,5 +199,23 @@ process-test-sentinel-wait-function-working-p
(should (eq (process-exit-status process) 0))
(should (equal (buffer-string) "stdout\nstderr\n")))))
+(ert-deftest make-process/stderr-sentinel ()
+ "Check that `make-process' doesn't install the default sentinel for stderr."
+ (skip-unless (executable-find shell-file-name))
+ (with-temp-buffer
+ (let ((process (make-process
+ :name "stderr-sentinel"
+ :command (list shell-file-name shell-command-switch
+ "echo stderr >&2")
+ :buffer nil
+ :stderr (current-buffer)
+ :noquery t
+ :connection-type 'pipe)))
+ (while (process-live-p process)
+ (accept-process-output process))
+ (should (eq (process-status process) 'exit))
+ (should (eq (process-exit-status process) 0))
+ (should (equal (buffer-string) "stderr\n")))))
+
(provide 'process-tests)
;; process-tests.el ends here.
--
2.17.0.484.g0c8726318c-goog