From: Valery Ushakov <uwe@stderr.spb.ru>
To: Paul Eggert <eggert@cs.ucla.edu>
Cc: 30738@debbugs.gnu.org
Subject: bug#30738: Invalid timezone (tzalloc failure) treated as out-of-memory
Date: Mon, 19 Mar 2018 23:24:25 +0300 [thread overview]
Message-ID: <20180319202425.GO3278@pony.stderr.spb.ru> (raw)
In-Reply-To: <f6cae525-994b-5e2c-872e-a8e542a2eb9d@cs.ucla.edu>
On Thu, Mar 15, 2018 at 09:43:20 -0700, Paul Eggert wrote:
> On 03/12/2018 12:10 PM, Valery Ushakov wrote:
> > - else if (EQ (zone, Qt))
> > + else if (EQ (zone, Qt)
> > + || (INTEGERP (zone) && XINT (zone) == 0))
>
> Thanks for diagnosing the problem. If I understand things correctly, we can
> do a more-general fix, which should work for any used-in-practice time zone
> that is an integer hour offset from UTC. I installed the attached patch into
> master; please give it a try. I don't have easy access to NetBSD and would
> appreciate your testing it on NetBSD 6 and 7.
I've tested it and this patch also needs to #include <sys/param.h>
where __NetBSD_Version__ is defined.
PS: As an aside, that %+ made me realize that tzbuf_format can
probably drop that artisanal &"-"[...] and its corresponding %s, and
just pass -hour instead.
-uwe
next prev parent reply other threads:[~2018-03-19 20:24 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <1370cc81-6aea-ed58-fcc0-1adc32f4252c@cs.ucla.edu>
2018-03-11 8:33 ` bug#30738: Invalid timezone (tzalloc failure) treated as out-of-memory Paul Eggert
2018-03-12 19:10 ` Valery Ushakov
2018-03-15 16:43 ` Paul Eggert
2018-03-19 16:29 ` Valery Ushakov
2018-03-19 23:55 ` Paul Eggert
2018-03-19 20:24 ` Valery Ushakov [this message]
2018-03-06 22:53 Valery Ushakov
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20180319202425.GO3278@pony.stderr.spb.ru \
--to=uwe@stderr.spb.ru \
--cc=30738@debbugs.gnu.org \
--cc=eggert@cs.ucla.edu \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this external index
https://git.savannah.gnu.org/cgit/emacs.git
https://git.savannah.gnu.org/cgit/emacs/org-mode.git
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.