From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!.POSTED!not-for-mail From: Alan Third Newsgroups: gmane.emacs.devel Subject: Re: bug#26323: 25.1; Closing frames (in fullscreen) under Mac OS cause immediate crash Date: Sun, 18 Mar 2018 11:30:04 +0000 Message-ID: <20180318113004.GB917@breton.holly.idiocy.org> References: <20180316104753.GA85186@breton.holly.idiocy.org> <6C685A44-3E4E-4CE9-B7CA-CD16627950B2@gmail.com> <20180318111522.GA917@breton.holly.idiocy.org> NNTP-Posting-Host: blaine.gmane.org Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit X-Trace: blaine.gmane.org 1521372493 18664 195.159.176.226 (18 Mar 2018 11:28:13 GMT) X-Complaints-To: usenet@blaine.gmane.org NNTP-Posting-Date: Sun, 18 Mar 2018 11:28:13 +0000 (UTC) User-Agent: Mutt/1.9.3 (2018-01-21) Cc: Matthew Bauer , emacs-devel@gnu.org To: David Reitter Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Sun Mar 18 12:28:09 2018 Return-path: Envelope-to: ged-emacs-devel@m.gmane.org Original-Received: from lists.gnu.org ([208.118.235.17]) by blaine.gmane.org with esmtp (Exim 4.84_2) (envelope-from ) id 1exWTx-0004kh-4t for ged-emacs-devel@m.gmane.org; Sun, 18 Mar 2018 12:28:09 +0100 Original-Received: from localhost ([::1]:37170 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1exWVz-0008Cu-Pk for ged-emacs-devel@m.gmane.org; Sun, 18 Mar 2018 07:30:15 -0400 Original-Received: from eggs.gnu.org ([2001:4830:134:3::10]:49922) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1exWVu-0008Ck-3W for emacs-devel@gnu.org; Sun, 18 Mar 2018 07:30:11 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1exWVt-0007XF-63 for emacs-devel@gnu.org; Sun, 18 Mar 2018 07:30:10 -0400 Original-Received: from mail-wm0-x231.google.com ([2a00:1450:400c:c09::231]:54732) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1exWVs-0007Wz-Uc for emacs-devel@gnu.org; Sun, 18 Mar 2018 07:30:09 -0400 Original-Received: by mail-wm0-x231.google.com with SMTP id h76so10465436wme.4 for ; Sun, 18 Mar 2018 04:30:08 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=googlemail.com; s=20161025; h=sender:date:from:to:cc:subject:message-id:references:mime-version :content-disposition:content-transfer-encoding:in-reply-to :user-agent; bh=jOHW/KvHDytxG/doB0rW7GQhRUkqZypebytcY0HaaHQ=; b=KQGFv4IZiUV5Tmp4zGkjj3gnZk+y7d7dQS72JPRJIpygeztktvL3QFS3O3qXMrW6iC NJlalM0TaEJR8QgJOKbYyx5CuwzP6w9rssBmccxvN+MDSLOvGjmVaG6CRzimFiDlLvC9 2D9mTYXPxPXG3GHkiOuZPWMh6/EZ27j6s/L3KXIP6860d62E22n5mp7j1kkXXSoUygK8 n/9ttr/v96RBnzPUDUARgysYnsFqO97pQNpXSCaGDzSwcUijosG2wsV9v4ePfjATQgGg ntp6XCjcpQcLoe9KCcs8qk10+BOQxXke2dDU+1F06CLmmUJFz15gXhb1yhHoWnMeRvpN JCRw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:sender:date:from:to:cc:subject:message-id :references:mime-version:content-disposition :content-transfer-encoding:in-reply-to:user-agent; bh=jOHW/KvHDytxG/doB0rW7GQhRUkqZypebytcY0HaaHQ=; b=AjBhtiJG5DxVZs/Z9QRq9JehGOPUtQfQNwAlVDoj5BOOxtreZw09b1x/r+8sXnLgye xjd7C9unMlZfMAZYMOIi6IyFxv3QSYBluCjKEMbLMYLEkezTDmOi23SPyaAs4npCkIdR X1NSinnspVf3HriaZZDYt/ccSm4jGNgOdGb32uQB9zC5pWPU+LQyrC/deUpXnadj8UEW kJ/TA01wJLrV4N2OwmubQMMS6LHHnTjKWp5pz3dYWtkK8OLrD2dPDMG6bCzbYGVLKQoU BPz1zTk5P7hRHXpnrIuF1slXizmnbU82W3SGSMe+xoolZo1rNv2DKAGbfyVxUHh81mOt tYAQ== X-Gm-Message-State: AElRT7FdCtW3yRrwj42GHZQl7jO3K7pzXYyKuHhR9lCFnXfDvPegAz6l Yi3JihhxqpUdHy+wE1muxtk= X-Google-Smtp-Source: AG47ELsfaw+huZgV2ELWBLjSAWZZrG73PQgbDksvQd4LQ+fFVxEvOwP79uTrjeq7EcuuAnBYrJcuRg== X-Received: by 10.28.92.208 with SMTP id q199mr5677865wmb.91.1521372607804; Sun, 18 Mar 2018 04:30:07 -0700 (PDT) Original-Received: from breton.holly.idiocy.org (ip6-2001-08b0-03f8-8129-2808-e7a7-12fd-18a9.holly.idiocy.org. [2001:8b0:3f8:8129:2808:e7a7:12fd:18a9]) by smtp.gmail.com with ESMTPSA id f14sm13611606wmi.11.2018.03.18.04.30.06 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Sun, 18 Mar 2018 04:30:07 -0700 (PDT) Content-Disposition: inline In-Reply-To: X-detected-operating-system: by eggs.gnu.org: Genre and OS details not recognized. X-Received-From: 2a00:1450:400c:c09::231 X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Original-Sender: "Emacs-devel" Xref: news.gmane.org gmane.emacs.devel:223786 Archived-At: On Sun, Mar 18, 2018 at 07:17:34AM -0400, David Reitter wrote: > On Mar 18, 2018, at 7:15 AM, Alan Third wrote: > > >> It reproduced in a mid-2016 build, and in a current build (based on the 25 branch). > > > > It was fixed after that. I can’t reproduce it in Emacs 26. > > Is this going to be backported to 25? No, I’m pretty sure it isn’t. > > I want to know how Matthew got his copy of Emacs as the code to turn > > off Sierra tab support is only included when built on Sierra+ or when > > using the right build options. > > That suggests the “fix” is to turn off tab support - is that right? I’m not sure, to be honest, but Matthew said he could only reproduce the problem with tab support on. I have tab support on in the OS and can’t reproduce it. The relevant code is: /* macOS Sierra automatically enables tabbed windows. We can't allow this to be enabled until it's available on a Free system. Currently it only happens by accident and is buggy anyway. */ #if defined (NS_IMPL_COCOA) \ && MAC_OS_X_VERSION_MAX_ALLOWED >= 101200 #if MAC_OS_X_VERSION_MIN_REQUIRED < 101200 if ([win respondsToSelector: @selector(setTabbingMode:)]) #endif [win setTabbingMode: NSWindowTabbingModeDisallowed]; #endif at the bottom of initFrameFromEmacs in nsterm.m. It’s possible we need to include similar code for fullscreen (I can’t remember if the fullscreen code uses initFrameFromEmacs), but it seems OK here. -- Alan Third