From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!.POSTED!not-for-mail From: Alan Third Newsgroups: gmane.emacs.devel Subject: Re: Preview: portable dumper Date: Sat, 17 Feb 2018 12:09:10 +0000 Message-ID: <20180217120910.GA40209@breton.holly.idiocy.org> References: <83bmwuogfb.fsf@gnu.org> <878trydrbo.fsf@red-bean.com> <87d15jo39q.fsf@ritchie.wxcvbn.org> <26497701-9de7-b91e-7ac3-4fb5949b436e@dancol.org> <83po58yhew.fsf@gnu.org> NNTP-Posting-Host: blaine.gmane.org Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit X-Trace: blaine.gmane.org 1518869230 9066 195.159.176.226 (17 Feb 2018 12:07:10 GMT) X-Complaints-To: usenet@blaine.gmane.org NNTP-Posting-Date: Sat, 17 Feb 2018 12:07:10 +0000 (UTC) User-Agent: Mutt/1.9.3 (2018-01-21) Cc: Eli Zaretskii , dancol@dancol.org, emacs-devel@gnu.org To: "Charles A. Roelli" Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Sat Feb 17 13:07:06 2018 Return-path: Envelope-to: ged-emacs-devel@m.gmane.org Original-Received: from lists.gnu.org ([208.118.235.17]) by blaine.gmane.org with esmtp (Exim 4.84_2) (envelope-from ) id 1en1GR-0000mR-FS for ged-emacs-devel@m.gmane.org; Sat, 17 Feb 2018 13:06:47 +0100 Original-Received: from localhost ([::1]:42791 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1en1IR-0004T1-Ej for ged-emacs-devel@m.gmane.org; Sat, 17 Feb 2018 07:08:51 -0500 Original-Received: from eggs.gnu.org ([2001:4830:134:3::10]:59445) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1en1IH-0004SU-TX for emacs-devel@gnu.org; Sat, 17 Feb 2018 07:08:42 -0500 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1en1IH-0000MO-4j for emacs-devel@gnu.org; Sat, 17 Feb 2018 07:08:41 -0500 Original-Received: from mail-wr0-x231.google.com ([2a00:1450:400c:c0c::231]:44910) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1en1IF-0000LU-PG; Sat, 17 Feb 2018 07:08:39 -0500 Original-Received: by mail-wr0-x231.google.com with SMTP id v65so5247917wrc.11; Sat, 17 Feb 2018 04:08:39 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=googlemail.com; s=20161025; h=sender:date:from:to:cc:subject:message-id:references:mime-version :content-disposition:content-transfer-encoding:in-reply-to :user-agent; bh=UJDoO/ZlgpLLG6LsYHO7yEKRVQkA1ulFZ+D/MDWXxLM=; b=Sb4pHpbaa/b6TRSAW44MZlrsqKZxnd2GA5EgaNrBF6qeszgbQHwhl8dNwFpqhvWtkg c10TT44FRPsix/mHqAEH3RZz7a+8c4GLsgDY5uKRBXSNcod9sSApixLKZeihyInSomE1 +VLPLXGgFv3S8wsmsGDRt/Rc9iDZnXHKnvNnTENOKVdalKULJNtgM7jz4kwApedNZxyM xLzxONi02u2AfiY05XZru96ckmsAwO6YmQvXeOdwtiurA9xDgsk8t1ipcDXhAaW5D96L UW+msJzBxoVDtUNNmwXfTuhSJuLbaNaZALJnS46Ax4sWXxj6hPAE5+/0A061Sw+UB85L LzaA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:sender:date:from:to:cc:subject:message-id :references:mime-version:content-disposition :content-transfer-encoding:in-reply-to:user-agent; bh=UJDoO/ZlgpLLG6LsYHO7yEKRVQkA1ulFZ+D/MDWXxLM=; b=t3tzyCjXWaZrZx0eAbhV2tZu7wFkkUI2xOmB2FScYyoHwZmdbx3X8rpLTEmDuilFhG +iFhhEeWBr156rVbk7nHk++pnZSAcgpVeiqvKuvKguBIWnUbrklMExc8lIbww5JD5Asa 0pwR8ogGcSsBoXSyBqRpAG6L9LuzUqCqQ4iDsVzd9QcuU0vbZdm+wDGSpFNX34vsxC8u DYFSpRfkewz9A91xB1LTG+UcmZHTg6e+dwckakVGJZeKJtRe28xoCUlZw155PYNoHFe5 jxJA+DjwHPXTSwluKRk+ODr+zRnij4Clb4IIfGJ2MX60AqYmZYxpZ6P35VW1HmLml66O 6oxw== X-Gm-Message-State: APf1xPCoO2bT5Tz4dPnpYp+xPyMP4Gx/mmDBmimsblKRWO8hJ06+Ue0g gAbdg/NSqPUIUdm8U4ax9IEyBafu X-Google-Smtp-Source: AH8x225fHg5BgCx7Mktxkut7JxdiIkg7WD6cVX0/3tJ3reb7olgkQFe07vIMBjYI9C/4ovmZ06T8xw== X-Received: by 10.223.187.68 with SMTP id x4mr7635720wrg.80.1518869318300; Sat, 17 Feb 2018 04:08:38 -0800 (PST) Original-Received: from breton.holly.idiocy.org (ip6-2001-08b0-03f8-8129-39a3-5d19-344b-9f69.holly.idiocy.org. [2001:8b0:3f8:8129:39a3:5d19:344b:9f69]) by smtp.gmail.com with ESMTPSA id 5sm19716472wre.35.2018.02.17.04.08.36 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Sat, 17 Feb 2018 04:08:37 -0800 (PST) Content-Disposition: inline In-Reply-To: X-detected-operating-system: by eggs.gnu.org: Genre and OS details not recognized. X-Received-From: 2a00:1450:400c:c0c::231 X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Original-Sender: "Emacs-devel" Xref: news.gmane.org gmane.emacs.devel:222858 Archived-At: On Sat, Feb 17, 2018 at 12:53:48PM +0100, Charles A. Roelli wrote: > On Apple's version of FSF GCC, I saw these kinds of errors: > > CC pdumper.o > pdumper.c:63: warning: unknown option after ‘#pragma GCC diagnostic’ kind > pdumper.c: In function ‘dump_reloc_set_offset’: > pdumper.c:289: error: #pragma GCC diagnostic not allowed inside functions > pdumper.c:289: error: #pragma GCC diagnostic not allowed inside functions > pdumper.c:291: error: #pragma GCC diagnostic not allowed inside functions > > They're fixed locally with this patch: > > diff --git a/src/pdumper.c b/src/pdumper.c > index a05b2c4..844ec25 100644 > --- a/src/pdumper.c > +++ b/src/pdumper.c > @@ -54,7 +54,10 @@ > > #ifdef HAVE_PDUMPER > > -#ifdef __GNUC__ > +#if defined(__GNUC__) && !defined(__APPLE__) /* Apple's old GCC (based > + on FSF's GCC) does not > + support pragmas in > + functions. */ > # pragma GCC diagnostic error "-Wconversion" > # pragma GCC diagnostic error "-Wshadow" > # define ALLOW_IMPLICIT_CONVERSION \ I’m pretty sure this will disable these pragmas for more recent clang versions on macOS, and probably any newer version of GCC people have compiled themselves.. -- Alan Third