From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!.POSTED!not-for-mail From: Alan Third Newsgroups: gmane.emacs.devel Subject: Re: Emacs 26 MacOS bugs Date: Sun, 11 Feb 2018 21:06:00 +0000 Message-ID: <20180211210600.GB45738@breton.holly.idiocy.org> References: <20180206190518.f43jsoughhlsi22y@adversary.org> <20180206222722.5uf43fd56p44dk5z@adversary.org> <20180207004331.q4cll6nyldse2bin@adversary.org> <20180207021301.zpvpexdkewztqxo4@adversary.org> <20180207225505.GB1066@breton.holly.idiocy.org> NNTP-Posting-Host: blaine.gmane.org Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit X-Trace: blaine.gmane.org 1518383127 5893 195.159.176.226 (11 Feb 2018 21:05:27 GMT) X-Complaints-To: usenet@blaine.gmane.org NNTP-Posting-Date: Sun, 11 Feb 2018 21:05:27 +0000 (UTC) User-Agent: Mutt/1.9.3 (2018-01-21) Cc: Ben McGinnes , Emacs developers , Noam Postavsky To: Philipp Stephani Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Sun Feb 11 22:05:22 2018 Return-path: Envelope-to: ged-emacs-devel@m.gmane.org Original-Received: from lists.gnu.org ([208.118.235.17]) by blaine.gmane.org with esmtp (Exim 4.84_2) (envelope-from ) id 1ekyoJ-00011P-EN for ged-emacs-devel@m.gmane.org; Sun, 11 Feb 2018 22:05:19 +0100 Original-Received: from localhost ([::1]:55355 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1ekyqL-0004LI-0E for ged-emacs-devel@m.gmane.org; Sun, 11 Feb 2018 16:07:25 -0500 Original-Received: from eggs.gnu.org ([2001:4830:134:3::10]:46570) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1ekyp4-0004J4-Ms for emacs-devel@gnu.org; Sun, 11 Feb 2018 16:06:07 -0500 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1ekyp3-0003Db-PZ for emacs-devel@gnu.org; Sun, 11 Feb 2018 16:06:06 -0500 Original-Received: from mail-wm0-x22d.google.com ([2a00:1450:400c:c09::22d]:51040) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1ekyp3-0003D0-I4 for emacs-devel@gnu.org; Sun, 11 Feb 2018 16:06:05 -0500 Original-Received: by mail-wm0-x22d.google.com with SMTP id f71so6275857wmf.0 for ; Sun, 11 Feb 2018 13:06:05 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=googlemail.com; s=20161025; h=sender:date:from:to:cc:subject:message-id:references:mime-version :content-disposition:content-transfer-encoding:in-reply-to :user-agent; bh=z8cyeov5zY+UG4fF+OYILfJgyEFtSH7ECHFQCIU9AM8=; b=B0a/lSEn7vt9tOuFj7VVGkYLkzeM/oHGbxwRaeVHdrpQjhML1ONHfdmZFRbLUeiVGh /nPTq0BVKPW+rjzNzUp9C2FA4NpWKYS+iraj78MB8b4d4S1d/3v27QqJHt3yk5lpPbMp i2dqnjPGkd5hqORpb0VocY+bZRA7bpUDDIRLYP/VTi228YeLqn6OjgipqADvgXWsVEQo m3juvJF6cAO2wPPwxNZBYhBmdPnpy85QaU6IUk+vS+1JmbWwkJvoYJVSM/3j1deGk+UL LA9p44Y48+sRLDeTA0dzajC95b/xvsn/7M0U1DhOJuPYWhmHag8Hhv8Mnyo678mtLWy+ 9ypA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:sender:date:from:to:cc:subject:message-id :references:mime-version:content-disposition :content-transfer-encoding:in-reply-to:user-agent; bh=z8cyeov5zY+UG4fF+OYILfJgyEFtSH7ECHFQCIU9AM8=; b=quyBh6VEq/vyjVDAXEzDusLA5f4Td+fe9hZ2O9nVZPm3vhMHeiy3rirnrgcqQdceJg Job3ZniW+4RIVEPh4ZFvH0GiU2frt2mwedbG9ZIAzuVlg+0EkGqQdXp0/H6vk7k+YKCF 4z75vOBfwv/t2+sQxpiPO/Y6z57yhGhRzBY7Q8BagnzvBr1mj6yTjoGbGejdcM8AqU0r FPW3zSInyOHuS09kZcVqeooJQsEG5m0Fwj8GwCty8hiSusD9YDVXVfovcEm+PgDd4urp W+viLcc12ZIKuqVqRe/uL+gJdeaFvJgtDgX2rNcZ3ktv/5Ix6Gtisr0ZNvjNP2eJLOI2 gp0w== X-Gm-Message-State: APf1xPBXx0ckf22e5tq/VPjZsa3prvoc9vnAaEjZil/9fMWl/Zg2LJTR xg5cPcd0UgUeepy87MiSyFc= X-Google-Smtp-Source: AH8x226OHEp/+I9xliG7Ff9mNLusVnN3ieXkLH4gVWiUkJ7EQrAWecQbOMxyid03ohPL5XuUJVLcqA== X-Received: by 10.28.234.93 with SMTP id i90mr1962991wmh.112.1518383164471; Sun, 11 Feb 2018 13:06:04 -0800 (PST) Original-Received: from breton.holly.idiocy.org (ip6-2001-08b0-03f8-8129-f814-4849-ba41-6e05.holly.idiocy.org. [2001:8b0:3f8:8129:f814:4849:ba41:6e05]) by smtp.gmail.com with ESMTPSA id t5sm7999099wra.47.2018.02.11.13.06.02 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Sun, 11 Feb 2018 13:06:03 -0800 (PST) Content-Disposition: inline In-Reply-To: X-detected-operating-system: by eggs.gnu.org: Genre and OS details not recognized. X-Received-From: 2a00:1450:400c:c09::22d X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Original-Sender: "Emacs-devel" Xref: news.gmane.org gmane.emacs.devel:222669 Archived-At: On Sun, Feb 11, 2018 at 01:53:10PM +0000, Philipp Stephani wrote: > Alan Third schrieb am Mi., 7. Feb. 2018 um 23:55 Uhr: > > > On Wed, Feb 07, 2018 at 01:13:01PM +1100, Ben McGinnes wrote: > > > > Philipp, it seems that EV_MODIFIERS2 was quite, quite broken. I’ve > > split it into various parts and tried to fix it. > > > > Additionally the fn key has some strange interactions with ‘function’ > > keys, like the Fx keys, arrows, tab and so on. The old code simply > > didn’t set its modifier when those keys were used, so I’ve followed > > that lead and am XORing it out of emacs_event->modifiers. > > > > > Sounds good, feel free to install the patch. > Is there some documentation for the strange interactions? If so, please add > it to the comment. I’ve pushed it to master. I don’t have any documentation, but I did add a bit more information to the comment. Simply put, the system sometimes reports the fn key being pressed at times when you wouldn’t expect it to, but only when ‘function’ keys like , or are being used. It also reports the fn key being pressed when you’re using it to turn something like into . We clearly don’t want that. (i.e. fn‐ gives fn‐ instead of just .) -- Alan Third