From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!.POSTED!not-for-mail From: Alan Third Newsgroups: gmane.emacs.bugs Subject: bug#30327: 27.0.50; Failures in files-tests.el on macOS Date: Sat, 3 Feb 2018 16:13:11 +0000 Message-ID: <20180203161311.GA17938@breton.holly.idiocy.org> References: <87inbfxd5o.fsf@gmx.de> <20180202230441.GA9047@breton.holly.idiocy.org> <87zi4qfwum.fsf@users.sourceforge.net> NNTP-Posting-Host: blaine.gmane.org Mime-Version: 1.0 Content-Type: text/plain; charset=iso-8859-1 Content-Transfer-Encoding: 8bit X-Trace: blaine.gmane.org 1517674364 23637 195.159.176.226 (3 Feb 2018 16:12:44 GMT) X-Complaints-To: usenet@blaine.gmane.org NNTP-Posting-Date: Sat, 3 Feb 2018 16:12:44 +0000 (UTC) User-Agent: Mutt/1.9.3 (2018-01-21) Cc: Philipp Stephani , Michael Albinus , 30327@debbugs.gnu.org To: Noam Postavsky Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Sat Feb 03 17:12:40 2018 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane.org Original-Received: from lists.gnu.org ([208.118.235.17]) by blaine.gmane.org with esmtp (Exim 4.84_2) (envelope-from ) id 1ei0QH-0004DS-BF for geb-bug-gnu-emacs@m.gmane.org; Sat, 03 Feb 2018 17:12:13 +0100 Original-Received: from localhost ([::1]:47272 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1ei0SI-0004UX-Jj for geb-bug-gnu-emacs@m.gmane.org; Sat, 03 Feb 2018 11:14:18 -0500 Original-Received: from eggs.gnu.org ([2001:4830:134:3::10]:56372) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1ei0S6-0004S5-Vl for bug-gnu-emacs@gnu.org; Sat, 03 Feb 2018 11:14:07 -0500 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1ei0S2-0006Wx-65 for bug-gnu-emacs@gnu.org; Sat, 03 Feb 2018 11:14:06 -0500 Original-Received: from debbugs.gnu.org ([208.118.235.43]:47919) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1ei0S2-0006Wt-0X for bug-gnu-emacs@gnu.org; Sat, 03 Feb 2018 11:14:02 -0500 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1ei0S1-0005Y9-Qn for bug-gnu-emacs@gnu.org; Sat, 03 Feb 2018 11:14:01 -0500 X-Loop: help-debbugs@gnu.org Resent-From: Alan Third Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Sat, 03 Feb 2018 16:14:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 30327 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: Original-Received: via spool by 30327-submit@debbugs.gnu.org id=B30327.151767440221282 (code B ref 30327); Sat, 03 Feb 2018 16:14:01 +0000 Original-Received: (at 30327) by debbugs.gnu.org; 3 Feb 2018 16:13:22 +0000 Original-Received: from localhost ([127.0.0.1]:55816 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1ei0RO-0005XC-Fw for submit@debbugs.gnu.org; Sat, 03 Feb 2018 11:13:22 -0500 Original-Received: from mail-wm0-f51.google.com ([74.125.82.51]:54399) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1ei0RL-0005Wy-Vl for 30327@debbugs.gnu.org; Sat, 03 Feb 2018 11:13:20 -0500 Original-Received: by mail-wm0-f51.google.com with SMTP id i186so18333973wmi.4 for <30327@debbugs.gnu.org>; Sat, 03 Feb 2018 08:13:19 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=googlemail.com; s=20161025; h=sender:date:from:to:cc:subject:message-id:references:mime-version :content-disposition:content-transfer-encoding:in-reply-to :user-agent; bh=JzL85p14+gyvZ7M0oPc2xH1l0BVJkgot+8fsY82wx5A=; b=Jj6uL3GU0gCBDBaEaXgx0CbO7aFN9Om3wnxQB1rkPr/cuwa1vAnV7rAA14RWusdfPH Zfu+gc74B5nVlUmHQ9HNp8TzzC2iziIr3o5neUsZZfpJkmF7Oa1hkdvq5Rw8KHUPLhTk pqpy+NECXz0p24yxXDNNKmSLx4701hFGoiNFssflo5MFXj99OMlLDSumhboQQPby11op FXj9Rv4XNZsqLoa8tShRFiY6Tef2dc6k1Exv3hK0J5vajkz9hwxz+OfOcMSWjWYbr2SH mVvN3ChHCYDf4nFRfpE7aucuGNy0797x3p5YJN4v+RhLFxS2cuc/qsvWZebLBjAAdZo6 W1XQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:sender:date:from:to:cc:subject:message-id :references:mime-version:content-disposition :content-transfer-encoding:in-reply-to:user-agent; bh=JzL85p14+gyvZ7M0oPc2xH1l0BVJkgot+8fsY82wx5A=; b=BG1PLDDK0jBoJnqP2fVocdej3iQZrWXKHzvgHw5ZS+nBO3NRVS4S7RHkfNE4q+3GAZ 7CyOH03GgX84C+Y0SFdLiJEoIk7wiYw+iw7Xc+SXrkfgja76u0PyuS8o0A0iBVmJC9mC XhQyUVYl1sl7zii2zkNuzv5fDEE88mFtsDDJRzloThm6zy4HWEwazlipcABFDdvqhcxF OLx3xQMhwsZaNUeCpMBawRUvO/8sS+KGyXtCcGNTvxXu1h9qdI2VkvOJ+AxkHKbssM1x ia9frkclGhnH0/h0J3c+EFq/efCb0OWPYMxeEeYH4GfoWYTr9ZM3AJrVOGSRLVz9s6w0 4KdA== X-Gm-Message-State: AKwxyteGS19hc4kDbUg+8+bXdGv6j9phFswVREwgZDZvomsUKlmUtHdn KPrIpOpa36JIsTNrt9oqdRo= X-Google-Smtp-Source: AH8x227sfxY8Zt2ZHfc79Q+X9xf+4Pe5Pe32tB4Z9cY4xeqEu71m/BPM1JJ8BUlLhq0KbjyJkcr3jw== X-Received: by 10.28.157.139 with SMTP id g133mr34138150wme.114.1517674394212; Sat, 03 Feb 2018 08:13:14 -0800 (PST) Original-Received: from breton.holly.idiocy.org (ip6-2001-08b0-03f8-8129-647a-d522-92ac-0d5e.holly.idiocy.org. [2001:8b0:3f8:8129:647a:d522:92ac:d5e]) by smtp.gmail.com with ESMTPSA id d73sm4952449wma.16.2018.02.03.08.13.13 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Sat, 03 Feb 2018 08:13:13 -0800 (PST) Content-Disposition: inline In-Reply-To: <87zi4qfwum.fsf@users.sourceforge.net> X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 208.118.235.43 X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.org gmane.emacs.bugs:142848 Archived-At: On Sat, Feb 03, 2018 at 12:47:29AM -0500, Noam Postavsky wrote: > Philipp Stephani writes: > > > The differing element is the last access time. This isn't surprising > > given that reading the directory accesses it. Probably the test > > should simply ignore the fifth element (the access time).  > > Ah, good point. I went through all the different file handlers pretty > quickly when writing these tests, so I missed these details. It passes > for me because I mount with 'relatime'. > > Element 9 is "unspecified", so I think we shouldn't check that either. The patch makes it even worse with two failures now: F files-tests-file-name-non-special-directory-files-and-attributes (void-variable attr-nospecial) F files-tests-file-name-non-special-file-attributes (void-variable attr-nospecial) I tried changing the new function to: (defun files-tests-file-attributes-equal (attr1 attr2) ;; Element 4 is access time, which may be changed by the act of ;; checking the attributes. (setf (nth 4 attr1) nil) (setf (nth 4 attr2) nil) ;; Element 9 is unspecified. (setf (nth 9 attr1) nil) (setf (nth 9 attr2) nil) (equal attr1 attr2)) Which fixes one but still causes the other to fail: F files-tests-file-name-non-special-directory-files-and-attributes (wrong-type-argument consp nil) -- Alan Third