From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!.POSTED!not-for-mail From: Alan Mackenzie Newsgroups: gmane.emacs.bugs Subject: bug#30186: 27.0.50; Password is not hidden in read-passwd Date: Thu, 25 Jan 2018 17:39:38 +0000 Message-ID: <20180125173937.GA3857@ACM> References: <871sikmd6o.fsf@mail.linkov.net> <83zi57qk2w.fsf@gnu.org> <87bmhm7wbw.fsf@mail.linkov.net> <87y3kp8thj.fsf@mail.linkov.net> <87372w8ddp.fsf@mail.linkov.net> NNTP-Posting-Host: blaine.gmane.org Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit X-Trace: blaine.gmane.org 1516902385 14687 195.159.176.226 (25 Jan 2018 17:46:25 GMT) X-Complaints-To: usenet@blaine.gmane.org NNTP-Posting-Date: Thu, 25 Jan 2018 17:46:25 +0000 (UTC) User-Agent: Mutt/1.7.2 (2016-11-26) Cc: 30186@debbugs.gnu.org To: Juri Linkov Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Thu Jan 25 18:46:21 2018 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane.org Original-Received: from lists.gnu.org ([208.118.235.17]) by blaine.gmane.org with esmtp (Exim 4.84_2) (envelope-from ) id 1eelbF-0002mm-Ay for geb-bug-gnu-emacs@m.gmane.org; Thu, 25 Jan 2018 18:46:09 +0100 Original-Received: from localhost ([::1]:54188 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1eeldF-0004qN-Ju for geb-bug-gnu-emacs@m.gmane.org; Thu, 25 Jan 2018 12:48:13 -0500 Original-Received: from eggs.gnu.org ([2001:4830:134:3::10]:41296) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1eeld7-0004pz-Nv for bug-gnu-emacs@gnu.org; Thu, 25 Jan 2018 12:48:06 -0500 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1eeld4-0003XJ-JT for bug-gnu-emacs@gnu.org; Thu, 25 Jan 2018 12:48:05 -0500 Original-Received: from debbugs.gnu.org ([208.118.235.43]:34886) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1eeld4-0003Wr-EG for bug-gnu-emacs@gnu.org; Thu, 25 Jan 2018 12:48:02 -0500 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1eeld4-0005Ub-1y for bug-gnu-emacs@gnu.org; Thu, 25 Jan 2018 12:48:02 -0500 X-Loop: help-debbugs@gnu.org Resent-From: Alan Mackenzie Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Thu, 25 Jan 2018 17:48:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 30186 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: Original-Received: via spool by 30186-submit@debbugs.gnu.org id=B30186.151690245021077 (code B ref 30186); Thu, 25 Jan 2018 17:48:01 +0000 Original-Received: (at 30186) by debbugs.gnu.org; 25 Jan 2018 17:47:30 +0000 Original-Received: from localhost ([127.0.0.1]:42783 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1eelcY-0005Tt-LE for submit@debbugs.gnu.org; Thu, 25 Jan 2018 12:47:30 -0500 Original-Received: from colin.muc.de ([193.149.48.1]:54799 helo=mail.muc.de) by debbugs.gnu.org with smtp (Exim 4.84_2) (envelope-from ) id 1eelcW-0005Tj-0i for 30186@debbugs.gnu.org; Thu, 25 Jan 2018 12:47:28 -0500 Original-Received: (qmail 29715 invoked by uid 3782); 25 Jan 2018 17:47:26 -0000 Original-Received: from acm.muc.de (p548C7553.dip0.t-ipconnect.de [84.140.117.83]) by colin.muc.de (tmda-ofmipd) with ESMTP; Thu, 25 Jan 2018 18:47:25 +0100 Original-Received: (qmail 4126 invoked by uid 1000); 25 Jan 2018 17:39:38 -0000 Content-Disposition: inline In-Reply-To: <87372w8ddp.fsf@mail.linkov.net> X-Delivery-Agent: TMDA/1.1.12 (Macallan) X-Primary-Address: acm@muc.de X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 208.118.235.43 X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.org gmane.emacs.bugs:142513 Archived-At: Hello, Juri. On Tue, Jan 23, 2018 at 23:38:10 +0200, Juri Linkov wrote: > Hi Alan, > Do you agree we could remove the effect of > with-silent-modifications around set-text-properties, > and leave it only on remove-list-of-text-properties? > This will help to fix the reported regression. I'm not sure about this. Doesn't `set-text-properties' need to be "protected", too? I'm not sure why you want to do this. Why do you want to do this? One thing which is puzzling me is that `with-silent-modifications' is a macro which is defined in subr.el, but later in the file. Won't this invocation of w-s-m get compiled as a function call because of this? > >>> Anyway, I bisected it for you, to > >>> c5e89be20a3feba9c67be6855b1dbdc6d8ae5ce2 > >> Here's the discussion reference that should have been in the commit message: > >> http://lists.gnu.org/r/emacs-devel/2015-04/msg00506.html > > I confirm that after removing with-silent-modifications from > > remove-yank-excluded-properties, C-y leaves ‘display’ properties > > in the minibuffer. It's ‘(inhibit-modification-hooks t)’ in > > let-bind of with-silent-modifications that prevents read-passwd > > from calling hide-chars-fun again to put new ‘display’ properties > > after set-text-properties removes old ones. So this patch should > > fix this issue, but I'm not sure if this is right. > > diff --git a/lisp/subr.el b/lisp/subr.el > > index 092850a..8673547 100644 > > --- a/lisp/subr.el > > +++ b/lisp/subr.el > > @@ -3041,7 +3041,8 @@ remove-yank-excluded-properties > > (setq run-start run-end))))) > > (with-silent-modifications > > (if (eq yank-excluded-properties t) > > - (set-text-properties start end nil) > > + (let ((inhibit-modification-hooks nil)) > > + (set-text-properties start end nil)) > > (remove-list-of-text-properties start end yank-excluded-properties))))) > > (defvar yank-undo-function) -- Alan Mackenzie (Nuremberg, Germany).