From: Alan Third <alan@idiocy.org>
To: Michael Albinus <michael.albinus@gmx.de>
Cc: Eli Zaretskii <eliz@gnu.org>,
"emacs-devel@gnu.org" <emacs-devel@gnu.org>,
zhang cc <ccsmile2008@outlook.com>
Subject: Re: auto-revert error on macOS when auto-revert-use-notify is t
Date: Sun, 21 Jan 2018 20:16:46 +0000 [thread overview]
Message-ID: <20180121201646.GA47260@breton.holly.idiocy.org> (raw)
In-Reply-To: <874lngfssx.fsf@gmx.de>
On Sat, Jan 20, 2018 at 04:34:06PM +0100, Michael Albinus wrote:
>
> I've pushed a patch to the master branch. It recreates a file
> notification in autorevert, if a file was deleted and recreated
> afterwards.
>
> Since autorevert watches directories, the solution was simpler than
> expected. The `create' event for the file from the directory is a
> perfect trigger.
>
> Could you, pls, check whether it works for you? I have extended the
> `auto-revert-test02-auto-revert-deleted-file', which runs OK in my
> environment. Testing on macOS (kqueue) is not possible for me.
Hi Michael,
The autorevert test fails on macOS for me:
Running 8 tests (2018-01-21 20:06:51+0000)
Library: `kqueue'
passed 1/8 file-notify-test00-availability
passed 2/8 file-notify-test01-add-watch
passed 3/8 file-notify-test02-rm-watch
passed 4/8 file-notify-test03-events
Reverting buffer `file-notify-test5Qh30O'.
Test file-notify-test04-autorevert backtrace:
signal(ert-test-failed (((should-not auto-revert-use-notify) :form a
ert-fail(((should-not auto-revert-use-notify) :form auto-revert-use-
(if (not (unwind-protect (setq value-208 auto-revert-use-notify) (se
(let (form-description-209) (if (not (unwind-protect (setq value-208
(let ((value-208 (gensym "ert-form-evaluation-aborted-"))) (let (for
(save-current-buffer (set-buffer buf) (let* ((fn-189 (function strin
(progn (advice-add 'vc-refresh-state :around 'ignore) (setq file-not
(unwind-protect (progn (advice-add 'vc-refresh-state :around 'ignore
(let ((timeout (if (file-remote-p temporary-file-directory) 60 10))
(closure (t) nil (let* ((fn-184 (function file-notify--test-local-en
ert--run-test-internal(#s(ert--test-execution-info :test #s(ert-test
ert-run-test(#s(ert-test :name file-notify-test04-autorevert :docume
ert-run-or-rerun-test(#s(ert--stats :selector (not (or (tag :expensi
ert-run-tests((not (or (tag :expensive-test) (tag :unstable))) #f(co
ert-run-tests-batch((not (or (tag :expensive-test) (tag :unstable)))
ert-run-tests-batch-and-exit((not (or (tag :expensive-test) (tag :un
eval((ert-run-tests-batch-and-exit '(not (or (tag :expensive-test) (
command-line-1(("-L" ":." "-l" "ert" "-l" "lisp/filenotify-tests.el"
command-line()
normal-top-level()
Test file-notify-test04-autorevert condition:
(ert-test-failed
((should-not auto-revert-use-notify)
:form auto-revert-use-notify :value t))
FAILED 5/8 file-notify-test04-autorevert
passed 6/8 file-notify-test05-file-validity
passed 7/8 file-notify-test06-dir-validity
passed 8/8 file-notify-test08-backup
Ran 8 tests, 7 results as expected, 1 unexpected (2018-01-21 20:07:14+0000)
1 unexpected results:
FAILED file-notify-test04-autorevert
--
Alan Third
next prev parent reply other threads:[~2018-01-21 20:16 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-12-29 5:08 auto-revert error on macOS when auto-revert-use-notify is t zhang cc
2017-12-29 10:02 ` Michael Albinus
2017-12-29 10:13 ` Eli Zaretskii
2017-12-29 15:45 ` zhang cc
2018-01-02 13:23 ` Michael Albinus
2018-01-05 14:47 ` zhang cc
2018-01-20 15:34 ` Michael Albinus
2018-01-21 11:01 ` zhang cc
2018-01-21 20:16 ` Alan Third [this message]
2018-01-22 8:17 ` Michael Albinus
2018-01-22 23:05 ` Alan Third
2018-03-11 4:26 ` zhang cc
[not found] ` <18101cae-50ff-44a2-af65-f77b9039f461@Spark>
2018-03-11 4:29 ` zhang cc
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20180121201646.GA47260@breton.holly.idiocy.org \
--to=alan@idiocy.org \
--cc=ccsmile2008@outlook.com \
--cc=eliz@gnu.org \
--cc=emacs-devel@gnu.org \
--cc=michael.albinus@gmx.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this external index
https://git.savannah.gnu.org/cgit/emacs.git
https://git.savannah.gnu.org/cgit/emacs/org-mode.git
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.