From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!.POSTED!not-for-mail From: Alan Mackenzie Newsgroups: gmane.emacs.devel Subject: Re: Suboptimal bug fix in CC Mode. Date: Sun, 21 Jan 2018 18:37:13 +0000 Message-ID: <20180121183713.GA19280@ACM> References: <20180115220012.GA4477@ACM> <83bmhty9jf.fsf@gnu.org> NNTP-Posting-Host: blaine.gmane.org Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii X-Trace: blaine.gmane.org 1516560164 19160 195.159.176.226 (21 Jan 2018 18:42:44 GMT) X-Complaints-To: usenet@blaine.gmane.org NNTP-Posting-Date: Sun, 21 Jan 2018 18:42:44 +0000 (UTC) User-Agent: Mutt/1.7.2 (2016-11-26) Cc: emacs-devel@gnu.org To: Eli Zaretskii Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Sun Jan 21 19:42:39 2018 Return-path: Envelope-to: ged-emacs-devel@m.gmane.org Original-Received: from lists.gnu.org ([208.118.235.17]) by blaine.gmane.org with esmtp (Exim 4.84_2) (envelope-from ) id 1edKZR-0003Yz-Co for ged-emacs-devel@m.gmane.org; Sun, 21 Jan 2018 19:42:21 +0100 Original-Received: from localhost ([::1]:42506 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1edKbR-0004Zs-Pc for ged-emacs-devel@m.gmane.org; Sun, 21 Jan 2018 13:44:25 -0500 Original-Received: from eggs.gnu.org ([2001:4830:134:3::10]:45536) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1edKbL-0004Zl-Ct for emacs-devel@gnu.org; Sun, 21 Jan 2018 13:44:20 -0500 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1edKbI-0005r8-Ai for emacs-devel@gnu.org; Sun, 21 Jan 2018 13:44:19 -0500 Original-Received: from colin.muc.de ([193.149.48.1]:60841 helo=mail.muc.de) by eggs.gnu.org with smtp (Exim 4.71) (envelope-from ) id 1edKbH-0005q7-Vm for emacs-devel@gnu.org; Sun, 21 Jan 2018 13:44:16 -0500 Original-Received: (qmail 55812 invoked by uid 3782); 21 Jan 2018 18:44:13 -0000 Original-Received: from acm.muc.de (p548C79BF.dip0.t-ipconnect.de [84.140.121.191]) by colin.muc.de (tmda-ofmipd) with ESMTP; Sun, 21 Jan 2018 19:44:12 +0100 Original-Received: (qmail 19295 invoked by uid 1000); 21 Jan 2018 18:37:13 -0000 Content-Disposition: inline In-Reply-To: <83bmhty9jf.fsf@gnu.org> X-Delivery-Agent: TMDA/1.1.12 (Macallan) X-Primary-Address: acm@muc.de X-detected-operating-system: by eggs.gnu.org: FreeBSD 9.x [fuzzy] X-Received-From: 193.149.48.1 X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Original-Sender: "Emacs-devel" Xref: news.gmane.org gmane.emacs.devel:222127 Archived-At: Hello, Eli. On Tue, Jan 16, 2018 at 19:53:56 +0200, Eli Zaretskii wrote: > > Date: Mon, 15 Jan 2018 22:00:12 +0000 > > Cc: emacs-devel@gnu.org > > From: Alan Mackenzie [ .... ] > > Clearly, analysing the innards of "{ ... }" is not a reliable way to > > distinguish brace blocks from statement/defun blocks. Instead, more > > elaborate analysis of its context needs to be carried out. This fix > > will be quite involved, and will be considerably more extensive than a > > "one-line fix". [ .... ] > I suggest that you revert the fix from the release branch, but leave > it on master, and try to fix it there. Please mark the revert as "not > to be merged to master". I've just committed an attempted fix to master. > Thanks. -- Alan Mackenzie (Nuremberg, Germany).