all messages for Emacs-related lists mirrored at yhetil.org
 help / color / mirror / code / Atom feed
From: Alan Mackenzie <acm@muc.de>
To: Eli Zaretskii <eliz@gnu.org>
Cc: emacs-devel@gnu.org
Subject: Re: Suboptimal bug fix in CC Mode.
Date: Sun, 21 Jan 2018 18:37:13 +0000	[thread overview]
Message-ID: <20180121183713.GA19280@ACM> (raw)
In-Reply-To: <83bmhty9jf.fsf@gnu.org>

Hello, Eli.

On Tue, Jan 16, 2018 at 19:53:56 +0200, Eli Zaretskii wrote:
> > Date: Mon, 15 Jan 2018 22:00:12 +0000
> > Cc: emacs-devel@gnu.org
> > From: Alan Mackenzie <acm@muc.de>

[ .... ]

> > Clearly, analysing the innards of "{ ... }" is not a reliable way to
> > distinguish brace blocks from statement/defun blocks.  Instead, more
> > elaborate analysis of its context needs to be carried out.  This fix
> > will be quite involved, and will be considerably more extensive than a
> > "one-line fix".

[ .... ]

> I suggest that you revert the fix from the release branch, but leave
> it on master, and try to fix it there.  Please mark the revert as "not
> to be merged to master".

I've just committed an attempted fix to master.

> Thanks.

-- 
Alan Mackenzie (Nuremberg, Germany).



      parent reply	other threads:[~2018-01-21 18:37 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-01-15 22:00 Suboptimal bug fix in CC Mode Alan Mackenzie
2018-01-16 17:53 ` Eli Zaretskii
2018-01-18 18:00   ` Alan Mackenzie
2018-01-23  8:50     ` John Wiegley
2018-01-21 18:37   ` Alan Mackenzie [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20180121183713.GA19280@ACM \
    --to=acm@muc.de \
    --cc=eliz@gnu.org \
    --cc=emacs-devel@gnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this external index

	https://git.savannah.gnu.org/cgit/emacs.git
	https://git.savannah.gnu.org/cgit/emacs/org-mode.git

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.