From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!.POSTED!not-for-mail From: Alan Third Newsgroups: gmane.emacs.bugs Subject: bug#29931: 27.0.50; Slightly suboptimal build behavior on macOS Date: Tue, 2 Jan 2018 21:24:59 +0000 Message-ID: <20180102212459.GB848@breton.holly.idiocy.org> References: <20180101145919.GC86834@breton.holly.idiocy.org> <20180101154801.GA53381@breton.holly.idiocy.org> <83zi5wauy2.fsf@gnu.org> <20180102201900.GA848@breton.holly.idiocy.org> NNTP-Posting-Host: blaine.gmane.org Mime-Version: 1.0 Content-Type: multipart/mixed; boundary="UlVJffcvxoiEqYs2" Content-Transfer-Encoding: 8bit X-Trace: blaine.gmane.org 1514928258 1607 195.159.176.226 (2 Jan 2018 21:24:18 GMT) X-Complaints-To: usenet@blaine.gmane.org NNTP-Posting-Date: Tue, 2 Jan 2018 21:24:18 +0000 (UTC) User-Agent: Mutt/1.9.1 (2017-09-22) Cc: Philipp Stephani , 29931@debbugs.gnu.org To: Eli Zaretskii Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Tue Jan 02 22:24:13 2018 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane.org Original-Received: from lists.gnu.org ([208.118.235.17]) by blaine.gmane.org with esmtp (Exim 4.84_2) (envelope-from ) id 1eWU2e-0008SR-M3 for geb-bug-gnu-emacs@m.gmane.org; Tue, 02 Jan 2018 22:24:12 +0100 Original-Received: from localhost ([::1]:56006 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1eWU4d-0001US-UL for geb-bug-gnu-emacs@m.gmane.org; Tue, 02 Jan 2018 16:26:15 -0500 Original-Received: from eggs.gnu.org ([2001:4830:134:3::10]:38759) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1eWU4U-0001Sn-Kd for bug-gnu-emacs@gnu.org; Tue, 02 Jan 2018 16:26:07 -0500 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1eWU4Q-0002xR-FP for bug-gnu-emacs@gnu.org; Tue, 02 Jan 2018 16:26:06 -0500 Original-Received: from debbugs.gnu.org ([208.118.235.43]:53076) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1eWU4Q-0002xF-9l for bug-gnu-emacs@gnu.org; Tue, 02 Jan 2018 16:26:02 -0500 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1eWU4P-000856-SJ for bug-gnu-emacs@gnu.org; Tue, 02 Jan 2018 16:26:01 -0500 X-Loop: help-debbugs@gnu.org Resent-From: Alan Third Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Tue, 02 Jan 2018 21:26:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 29931 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: Original-Received: via spool by 29931-submit@debbugs.gnu.org id=B29931.151492831931016 (code B ref 29931); Tue, 02 Jan 2018 21:26:01 +0000 Original-Received: (at 29931) by debbugs.gnu.org; 2 Jan 2018 21:25:19 +0000 Original-Received: from localhost ([127.0.0.1]:33524 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1eWU3d-000847-TW for submit@debbugs.gnu.org; Tue, 02 Jan 2018 16:25:17 -0500 Original-Received: from mail-wr0-f182.google.com ([209.85.128.182]:35417) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1eWU3Z-00083r-3m for 29931@debbugs.gnu.org; Tue, 02 Jan 2018 16:25:12 -0500 Original-Received: by mail-wr0-f182.google.com with SMTP id l19so37395572wrc.2 for <29931@debbugs.gnu.org>; Tue, 02 Jan 2018 13:25:09 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=googlemail.com; s=20161025; h=sender:date:from:to:cc:subject:message-id:references:mime-version :content-disposition:content-transfer-encoding:in-reply-to :user-agent; bh=jyNBWa74EsMwCSQg2EbYIG6en60MzZKoKys+H6FASmg=; b=po7RA3ldukQFhfJQVfoeMODYOPr6uog0tHkYCGBSflvMm5idXPq3nU/+M4ZlFaxMhG WS6efUUsGb4OYEJdy6pbDdEkhNYZ/dE82W7DnLUcL7GSwpwZAmek06zECmSM3BgSGmIq 2gLwqHY/+gLPbAFwx0D/aQ63CR9PPHt1fp9Z3I9urQpDFzP+N0wawr8pYJQWM4KdG5Ku G/r5dz0lFBxjiPM71XpCgjGumouQsSGCnESeTP4rWoGFzBNXbdUEr6vuej8yVu1JNgIR HBQuHBSn/N6XfRCOyVVSEkG4JNuLyWbeQH/rhBVhja7ZE95iYjtwyYzDBdavWNbXPqNi ++kQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:sender:date:from:to:cc:subject:message-id :references:mime-version:content-disposition :content-transfer-encoding:in-reply-to:user-agent; bh=jyNBWa74EsMwCSQg2EbYIG6en60MzZKoKys+H6FASmg=; b=FYqkwiOwrXKwtWGBcUIrqymvFZgp37iH8eSBg5MAfaPC/Nr75APryPyLG7AZh6mKwG mhXzutKe57+oGIx4ORqGsX6X/P7iC8yLWVmRTI+4p9ymmQ1/zfITv3y5fEOhomYoCGYQ +2Nl+nIlx7kVGdFySJfrO1HEZAcTnCCtSmc5akW6Hz4vVgy9fmafvAo3QbI58eGJHpfJ 1VnNd+m81eNK0KN+HvhY0c9e8Lc1VHhA19YeuX7YK+hxm4mQpjedy93cDY525s7qc4+C NBN2xdoach4z3NalJwFaVYx2MDKJQxuVp8Q/5ygMcGYDYsGLHX7wN8sceEJcxo8KHdjf xf8Q== X-Gm-Message-State: AKGB3mJ/mWolPXsmo+vL8oXdYoFJOnrQ8tor37XYwMB04ceNlRPrClWz lDSjWUfQNb2VFrttPe3KqsI= X-Google-Smtp-Source: ACJfBotihBZAkF+JA1VUyB2558Gu4cterFOqA2zgH2ij9kfDLNZxBpq5N9oIEOAjEbamhNxQjmve+w== X-Received: by 10.223.163.79 with SMTP id d15mr2376344wrb.32.1514928303386; Tue, 02 Jan 2018 13:25:03 -0800 (PST) Original-Received: from breton.holly.idiocy.org (ip6-2001-08b0-03f8-8129-3ca9-c940-779f-ceae.holly.idiocy.org. [2001:8b0:3f8:8129:3ca9:c940:779f:ceae]) by smtp.gmail.com with ESMTPSA id 34sm29392554wry.34.2018.01.02.13.25.01 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Tue, 02 Jan 2018 13:25:02 -0800 (PST) Content-Disposition: inline In-Reply-To: <20180102201900.GA848@breton.holly.idiocy.org> X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 208.118.235.43 X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.org gmane.emacs.bugs:141727 Archived-At: --UlVJffcvxoiEqYs2 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit On Tue, Jan 02, 2018 at 08:19:00PM +0000, Alan Third wrote: > I’m not sure how portable this test needs to be since it should only > run on darwin: > > if test "${opsys}" = darwin && test -z "${MAKEINFO}" && \ > test -x /usr/local/opt/texinfo/bin/makeinfo; then I’ve done some investigation and come up with a version that uses autoconfig macros. I also looked into macports and it seems it always includes everything you’ve installed, unlike homebrew, so we shouldn’t run into this issue with it. -- Alan Third --UlVJffcvxoiEqYs2 Content-Type: text/plain; charset=us-ascii Content-Disposition: attachment; filename="0001-Fix-build-issues-on-macOS-bug-29931.patch" >From b8d2de82a3ee3faa72ad54d68a00cec95370f504 Mon Sep 17 00:00:00 2001 From: Alan Third Date: Mon, 1 Jan 2018 15:44:24 +0000 Subject: [PATCH] Fix build issues on macOS (bug#29931) * configure.ac: On darwin add check for Homebrew texinfo install, and fix incorrect quoting of libxml2 includes. --- configure.ac | 12 ++++++++++-- 1 file changed, 10 insertions(+), 2 deletions(-) diff --git a/configure.ac b/configure.ac index 4c2644b11d..26f01cad13 100644 --- a/configure.ac +++ b/configure.ac @@ -1267,6 +1267,14 @@ AC_DEFUN AC_SUBST([PAXCTL_dumped]) AC_SUBST([PAXCTL_notdumped]) +# Makeinfo on macOS is ancient, check whether there is a more recent +# version installed by Homebrew. +AC_CHECK_PROG(HAVE_BREW, [brew], [yes]) +if test -n "$HAVE_BREW"; then + AC_PATH_PROG([MAKEINFO], [makeinfo], [], + [`brew --prefix 2>/dev/null`/opt/texinfo/bin$PATH_SEPARATOR$PATH]) +fi + ## Require makeinfo >= 4.13 (last of the 4.x series) to build the manuals. if test "${MAKEINFO:=makeinfo}" != "no"; then case `($MAKEINFO --version) 2>/dev/null` in @@ -3881,13 +3889,13 @@ AC_DEFUN xcsdkdir="" ;; esac fi - CPPFLAGS="$CPPFLAGS -I$xcsdkdir/usr/include/libxml2" + CPPFLAGS="$CPPFLAGS -I${xcsdkdir}/usr/include/libxml2" AC_CHECK_HEADER(libxml/HTMLparser.h, [AC_CHECK_DECL(HTML_PARSE_RECOVER, HAVE_LIBXML2=yes, , [#include ])]) CPPFLAGS="$SAVE_CPPFLAGS" if test "${HAVE_LIBXML2}" = "yes"; then - LIBXML2_CFLAGS="-I'$xcsdkdir/usr/include/libxml2'" + LIBXML2_CFLAGS="-I${xcsdkdir}/usr/include/libxml2" LIBXML2_LIBS="-lxml2" fi fi -- 2.14.3 --UlVJffcvxoiEqYs2--