From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!.POSTED!not-for-mail From: Alan Third Newsgroups: gmane.emacs.bugs Subject: bug#29931: 27.0.50; Slightly suboptimal build behavior on macOS Date: Tue, 2 Jan 2018 12:10:07 +0000 Message-ID: <20180102121007.GA47346@breton.holly.idiocy.org> References: <20180101145919.GC86834@breton.holly.idiocy.org> <20180101155359.GB53381@breton.holly.idiocy.org> NNTP-Posting-Host: blaine.gmane.org Mime-Version: 1.0 Content-Type: multipart/mixed; boundary="huq684BweRXVnRxX" Content-Transfer-Encoding: 8bit X-Trace: blaine.gmane.org 1514894960 6396 195.159.176.226 (2 Jan 2018 12:09:20 GMT) X-Complaints-To: usenet@blaine.gmane.org NNTP-Posting-Date: Tue, 2 Jan 2018 12:09:20 +0000 (UTC) User-Agent: Mutt/1.9.1 (2017-09-22) Cc: 29931@debbugs.gnu.org To: Philipp Stephani Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Tue Jan 02 13:09:16 2018 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane.org Original-Received: from lists.gnu.org ([208.118.235.17]) by blaine.gmane.org with esmtp (Exim 4.84_2) (envelope-from ) id 1eWLNY-000183-T3 for geb-bug-gnu-emacs@m.gmane.org; Tue, 02 Jan 2018 13:09:13 +0100 Original-Received: from localhost ([::1]:40538 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1eWLPY-0007Xl-0H for geb-bug-gnu-emacs@m.gmane.org; Tue, 02 Jan 2018 07:11:16 -0500 Original-Received: from eggs.gnu.org ([2001:4830:134:3::10]:53500) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1eWLPO-0007XE-Hg for bug-gnu-emacs@gnu.org; Tue, 02 Jan 2018 07:11:07 -0500 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1eWLPK-00049W-A0 for bug-gnu-emacs@gnu.org; Tue, 02 Jan 2018 07:11:06 -0500 Original-Received: from debbugs.gnu.org ([208.118.235.43]:51877) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1eWLPK-00049O-4p for bug-gnu-emacs@gnu.org; Tue, 02 Jan 2018 07:11:02 -0500 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1eWLPJ-0001iQ-VZ for bug-gnu-emacs@gnu.org; Tue, 02 Jan 2018 07:11:02 -0500 X-Loop: help-debbugs@gnu.org Resent-From: Alan Third Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Tue, 02 Jan 2018 12:11:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 29931 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: Original-Received: via spool by 29931-submit@debbugs.gnu.org id=B29931.15148950216546 (code B ref 29931); Tue, 02 Jan 2018 12:11:01 +0000 Original-Received: (at 29931) by debbugs.gnu.org; 2 Jan 2018 12:10:21 +0000 Original-Received: from localhost ([127.0.0.1]:60558 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1eWLOe-0001hW-VF for submit@debbugs.gnu.org; Tue, 02 Jan 2018 07:10:21 -0500 Original-Received: from mail-wr0-f178.google.com ([209.85.128.178]:45898) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1eWLOb-0001hH-C4 for 29931@debbugs.gnu.org; Tue, 02 Jan 2018 07:10:19 -0500 Original-Received: by mail-wr0-f178.google.com with SMTP id o15so16127301wrf.12 for <29931@debbugs.gnu.org>; Tue, 02 Jan 2018 04:10:17 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=googlemail.com; s=20161025; h=sender:date:from:to:cc:subject:message-id:references:mime-version :content-disposition:content-transfer-encoding:in-reply-to :user-agent; bh=gt7CR9MCaZVFLcKpTflTWcaNTw4CgQRR2cyvjycV1BA=; b=c5nWwONSlpDIRfsiCuMBws/G/teAqSKi6YkympHyzq456I6jKaTrnlf97BibM+Stvo 0iqj/X3bI5UlSDxbj/yzgqYGLEcmHw2fVdGRQ6QVTDqUD1nODqApP7WAAT1LUgLQuamK L75p5W8We2dkBJJ32yIwkU2pIZoJaZBm45TALv46tzsOyDau3KX/jtXLBLdyRmInpPRB i2aYy3hig/OvYC5ifpAxQ5QF9Hx8sZzF6ESP29o4XAovZxUq4yZjEmSVopEGzzKLmZx0 8dwgJk9ubJd6NqEmcojizn4619lSIMngPSg/4A14S7Lk177k2C9HpOHUwvcCV422nB6c oLqw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:sender:date:from:to:cc:subject:message-id :references:mime-version:content-disposition :content-transfer-encoding:in-reply-to:user-agent; bh=gt7CR9MCaZVFLcKpTflTWcaNTw4CgQRR2cyvjycV1BA=; b=f6FPvI0tM/7h2SULaS1i4IGw8h11SHF7gO7P8KXOgzUcYTeThMXmMP8xjtE6HOQWxS BNVHwp4/kSBGa539E5C2yhsiaV2NRa8b5U1/RVpSGHqeFfIxqUlogHglnOiQrljfHKxq NRTINKYYqGT/k1H7S+JF5me3sS+PSLwDh0IHejaQ0UPfxFEEDlfOeJ0mqfK9estrB7oV UMFz+RB4lcZ0Dq/3fZOSoz0GznxsgV4e+4JIYJn9VUMX+/JGcSiB8YCLrfDIjN4Y+K17 3SMAfsC3NbQZ9DHeehjWcyrrNvShemuM96DJHx8um3XazqkIvyA8nyTE7jrVYZ6KgZ+s Swng== X-Gm-Message-State: AKGB3mLhcLWf/iYilKAK+RskDbvlZNhPKJl+W/mMYPQltE0RDpI/MV+D SalDogqGS/D8gbniSrDWvA0= X-Google-Smtp-Source: ACJfBovWUxDMN7APlR9utvrgt1USbN2SsKPJloSU/0PQj9oXymbxJ0kofq/fY4LPJJ1d7akdLYjRxw== X-Received: by 10.223.176.242 with SMTP id j47mr45444642wra.178.1514895011697; Tue, 02 Jan 2018 04:10:11 -0800 (PST) Original-Received: from breton.holly.idiocy.org (ip6-2001-08b0-03f8-8129-e189-cb21-fb46-22b2.holly.idiocy.org. [2001:8b0:3f8:8129:e189:cb21:fb46:22b2]) by smtp.gmail.com with ESMTPSA id 34sm28247330wry.34.2018.01.02.04.10.09 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Tue, 02 Jan 2018 04:10:10 -0800 (PST) Content-Disposition: inline In-Reply-To: <20180101155359.GB53381@breton.holly.idiocy.org> X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 208.118.235.43 X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.org gmane.emacs.bugs:141709 Archived-At: --huq684BweRXVnRxX Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit On Mon, Jan 01, 2018 at 03:53:59PM +0000, Alan Third wrote: > Can you please run > > xcrun --show-sdk-path > > And see if it returns something useful? On my machine it returns > nothing at all, but I don’t have the full xcode installed. Actually, I think I’ve found the bug. I’ve attached a patch that will hopefully fix both your issues. -- Alan Third --huq684BweRXVnRxX Content-Type: text/plain; charset=us-ascii Content-Disposition: attachment; filename="0001-Fix-build-issues-on-macOS-bug-29931.patch" >From aa1600509e188f3423943b4220a1faa210e356a2 Mon Sep 17 00:00:00 2001 From: Alan Third Date: Mon, 1 Jan 2018 15:44:24 +0000 Subject: [PATCH] Fix build issues on macOS (bug#29931) * configure.ac: On darwin add check for Homebrew texinfo install, and fix incorrect quoting of libxml2 includes. --- configure.ac | 11 +++++++++-- 1 file changed, 9 insertions(+), 2 deletions(-) diff --git a/configure.ac b/configure.ac index ec1418b99e..cc514710dc 100644 --- a/configure.ac +++ b/configure.ac @@ -1267,6 +1267,13 @@ AC_DEFUN AC_SUBST([PAXCTL_dumped]) AC_SUBST([PAXCTL_notdumped]) +# Makeinfo on macOS is ancient, check whether there is a more recent +# version installed by Homebrew. +if test "${opsys}" = darwin && test -z ${MAKEINFO} && \ + test -d "/usr/local/opt/texinfo/bin"; then + MAKEINFO=/usr/local/opt/texinfo/bin/makeinfo +fi + ## Require makeinfo >= 4.13 (last of the 4.x series) to build the manuals. if test "${MAKEINFO:=makeinfo}" != "no"; then case `($MAKEINFO --version) 2>/dev/null` in @@ -3881,13 +3888,13 @@ AC_DEFUN xcsdkdir="" ;; esac fi - CPPFLAGS="$CPPFLAGS -I$xcsdkdir/usr/include/libxml2" + CPPFLAGS="$CPPFLAGS -I${xcsdkdir}/usr/include/libxml2" AC_CHECK_HEADER(libxml/HTMLparser.h, [AC_CHECK_DECL(HTML_PARSE_RECOVER, HAVE_LIBXML2=yes, , [#include ])]) CPPFLAGS="$SAVE_CPPFLAGS" if test "${HAVE_LIBXML2}" = "yes"; then - LIBXML2_CFLAGS="-I'$xcsdkdir/usr/include/libxml2'" + LIBXML2_CFLAGS="-I${xcsdkdir}/usr/include/libxml2" LIBXML2_LIBS="-lxml2" fi fi -- 2.14.3 --huq684BweRXVnRxX--