bug#29931: 27.0.50; Slightly suboptimal build behavior on macOS

[Alan Third <alan@idiocy.org>]

[-- Attachment #1: Type: text/plain, Size: 367 bytes --]

On Mon, Jan 01, 2018 at 03:53:59PM +0000, Alan Third wrote:
> Can you please run
> 
>     xcrun --show-sdk-path
> 
> And see if it returns something useful? On my machine it returns
> nothing at all, but I don’t have the full xcode installed.

Actually, I think I’ve found the bug. I’ve attached a patch that will
hopefully fix both your issues.
-- 
Alan Third

[-- Attachment #2: 0001-Fix-build-issues-on-macOS-bug-29931.patch --]
[-- Type: text/plain, Size: 1618 bytes --]

From aa1600509e188f3423943b4220a1faa210e356a2 Mon Sep 17 00:00:00 2001
From: Alan Third <alan@idiocy.org>
Date: Mon, 1 Jan 2018 15:44:24 +0000
Subject: [PATCH] Fix build issues on macOS (bug#29931)

* configure.ac: On darwin add check for Homebrew texinfo install, and
fix incorrect quoting of libxml2 includes.
---
 configure.ac | 11 +++++++++--
 1 file changed, 9 insertions(+), 2 deletions(-)

diff --git a/configure.ac b/configure.ac
index ec1418b99e..cc514710dc 100644
--- a/configure.ac
+++ b/configure.ac
@@ -1267,6 +1267,13 @@ AC_DEFUN
 AC_SUBST([PAXCTL_dumped])
 AC_SUBST([PAXCTL_notdumped])
 
+# Makeinfo on macOS is ancient, check whether there is a more recent
+# version installed by Homebrew.
+if test "${opsys}" = darwin && test -z ${MAKEINFO} && \
+   test -d "/usr/local/opt/texinfo/bin"; then
+  MAKEINFO=/usr/local/opt/texinfo/bin/makeinfo
+fi
+
 ## Require makeinfo >= 4.13 (last of the 4.x series) to build the manuals.
 if test "${MAKEINFO:=makeinfo}" != "no"; then
   case `($MAKEINFO --version) 2>/dev/null` in
@@ -3881,13 +3888,13 @@ AC_DEFUN
 	xcsdkdir="" ;;
       esac
     fi
-    CPPFLAGS="$CPPFLAGS -I$xcsdkdir/usr/include/libxml2"
+    CPPFLAGS="$CPPFLAGS -I${xcsdkdir}/usr/include/libxml2"
     AC_CHECK_HEADER(libxml/HTMLparser.h,
       [AC_CHECK_DECL(HTML_PARSE_RECOVER, HAVE_LIBXML2=yes, ,
 		     [#include <libxml/HTMLparser.h>])])
     CPPFLAGS="$SAVE_CPPFLAGS"
     if test "${HAVE_LIBXML2}" = "yes"; then
-      LIBXML2_CFLAGS="-I'$xcsdkdir/usr/include/libxml2'"
+      LIBXML2_CFLAGS="-I${xcsdkdir}/usr/include/libxml2"
       LIBXML2_LIBS="-lxml2"
     fi
   fi
-- 
2.14.3