bug#29931: 27.0.50; Slightly suboptimal build behavior on macOS

[Alan Third <alan@idiocy.org>]

[-- Attachment #1: Type: text/plain, Size: 867 bytes --]

On Mon, Jan 01, 2018 at 03:05:02PM +0000, Philipp Stephani wrote:
> Alan Third <alan@idiocy.org> schrieb am Mo., 1. Jan. 2018 um 15:59 Uhr:
> 
> > I’d think it’s the user’s responsibility to make sure /usr/local/bin
> > is on their path if they want to use homebrew stuff?
> >
> >
> /usr/local/bin doesn't contain makeinfo when installed via Homebrew. This
> is intentional; `brew info texinfo` says
<snip>
> If you need to have this software first in your PATH run:
>   echo 'export PATH="/usr/local/opt/texinfo/bin:$PATH"' >> ~/.bash_profile
> 
> I can obviously do that or set MAKEINFO explicitly when invoking configure,
> but it would be nice if configure detected this situation automatically.

Ah, I think I must have linked it into /usr/local/bin myself.

Do you have any idea if other packaging tools do similar things?

Patch attached.
-- 
Alan Third

[-- Attachment #2: 0001-Use-Homebrew-installed-makeinfo-if-it-exists-bug-299.patch --]
[-- Type: text/plain, Size: 998 bytes --]

From 6fe03f8c62a063866504ef1c746ac01305b53890 Mon Sep 17 00:00:00 2001
From: Alan Third <alan@idiocy.org>
Date: Mon, 1 Jan 2018 15:44:24 +0000
Subject: [PATCH] Use Homebrew installed makeinfo if it exists (bug#29931)

* configure.ac: Add check for Homebrew texinfo install on darwin.
---
 configure.ac | 7 +++++++
 1 file changed, 7 insertions(+)

diff --git a/configure.ac b/configure.ac
index ec1418b99e..e695e0d791 100644
--- a/configure.ac
+++ b/configure.ac
@@ -1267,6 +1267,13 @@ AC_DEFUN
 AC_SUBST([PAXCTL_dumped])
 AC_SUBST([PAXCTL_notdumped])
 
+# Makeinfo on macOS is ancient, check whether there is a more recent
+# version installed by Homebrew.
+if test "${opsys}" = darwin && test -z ${MAKEINFO} && \
+   test -d "/usr/local/opt/texinfo/bin"; then
+  MAKEINFO=/usr/local/opt/texinfo/bin/makeinfo
+fi
+
 ## Require makeinfo >= 4.13 (last of the 4.x series) to build the manuals.
 if test "${MAKEINFO:=makeinfo}" != "no"; then
   case `($MAKEINFO --version) 2>/dev/null` in
-- 
2.14.3