From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!.POSTED!not-for-mail From: Alan Third Newsgroups: gmane.emacs.bugs Subject: bug#29595: 26.0.90; menu items show incorrect shortcut keys Date: Fri, 22 Dec 2017 15:50:33 +0000 Message-ID: <20171222155033.GA36979@breton.holly.idiocy.org> References: <1512610506.1321010.1196716904.28D41DCB@webmail.messagingengine.com> <1513919792.1032331.1213126968.1E43DDA8@webmail.messagingengine.com> <83o9mrmdet.fsf@gnu.org> <20171222123433.GA36334@breton.holly.idiocy.org> <838tdunc3d.fsf@gnu.org> NNTP-Posting-Host: blaine.gmane.org Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit X-Trace: blaine.gmane.org 1513957773 22262 195.159.176.226 (22 Dec 2017 15:49:33 GMT) X-Complaints-To: usenet@blaine.gmane.org NNTP-Posting-Date: Fri, 22 Dec 2017 15:49:33 +0000 (UTC) User-Agent: Mutt/1.9.1 (2017-09-22) Cc: 29595@debbugs.gnu.org, hello@paulwrankin.com To: Eli Zaretskii Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Fri Dec 22 16:49:29 2017 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane.org Original-Received: from lists.gnu.org ([208.118.235.17]) by blaine.gmane.org with esmtp (Exim 4.84_2) (envelope-from ) id 1eSPZa-0004zZ-0H for geb-bug-gnu-emacs@m.gmane.org; Fri, 22 Dec 2017 16:49:22 +0100 Original-Received: from localhost ([::1]:54964 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1eSPbW-0007zG-Oe for geb-bug-gnu-emacs@m.gmane.org; Fri, 22 Dec 2017 10:51:22 -0500 Original-Received: from eggs.gnu.org ([2001:4830:134:3::10]:46549) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1eSPbE-0007wI-Ou for bug-gnu-emacs@gnu.org; Fri, 22 Dec 2017 10:51:05 -0500 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1eSPbC-0003tO-52 for bug-gnu-emacs@gnu.org; Fri, 22 Dec 2017 10:51:04 -0500 Original-Received: from debbugs.gnu.org ([208.118.235.43]:39534) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1eSPbC-0003t1-1A for bug-gnu-emacs@gnu.org; Fri, 22 Dec 2017 10:51:02 -0500 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1eSPbB-0007oM-QP for bug-gnu-emacs@gnu.org; Fri, 22 Dec 2017 10:51:01 -0500 X-Loop: help-debbugs@gnu.org Resent-From: Alan Third Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Fri, 22 Dec 2017 15:51:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 29595 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: Original-Received: via spool by 29595-submit@debbugs.gnu.org id=B29595.151395784630006 (code B ref 29595); Fri, 22 Dec 2017 15:51:01 +0000 Original-Received: (at 29595) by debbugs.gnu.org; 22 Dec 2017 15:50:46 +0000 Original-Received: from localhost ([127.0.0.1]:48215 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1eSPav-0007nq-6t for submit@debbugs.gnu.org; Fri, 22 Dec 2017 10:50:46 -0500 Original-Received: from mail-wr0-f180.google.com ([209.85.128.180]:39381) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1eSPat-0007nc-03 for 29595@debbugs.gnu.org; Fri, 22 Dec 2017 10:50:43 -0500 Original-Received: by mail-wr0-f180.google.com with SMTP id a41so28231052wra.6 for <29595@debbugs.gnu.org>; Fri, 22 Dec 2017 07:50:42 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=googlemail.com; s=20161025; h=sender:date:from:to:cc:subject:message-id:references:mime-version :content-disposition:content-transfer-encoding:in-reply-to :user-agent; bh=T9GnaEawRoM7EW6cCAycUK+BKWKHO+/IzdIkmZ21yPs=; b=GuxtRcK+gd1I5e1zTZggzerfwj8KXUtoqCYmj3Gm+KYu6f+cMdMeslwqSDfyMpHU3n BqE6SMigCWKpSbPSe5w7cZ8SIquYOLqZPfkHD6uFiD7voe7raw/Ph1K2xkLfvwAaDEOm xFQ9U4Tu7QZgIh0baffnNBpKXCQQVSFqHNiRJ0+qHvifk4YS/gmnrRgFiyy5IGUh7Hey BTGqDkr7buQm0niUnuGLA66DZlatx4eBPyZaVtEdKDyoiN1/L9OCBaMViRC4K2sGaP69 DOyaibQK+q4BoEuplomlkIarycuGQqllRsm7n1VZBN+RndAtoLrfprM++zSvWW1ZpYBK LLvw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:sender:date:from:to:cc:subject:message-id :references:mime-version:content-disposition :content-transfer-encoding:in-reply-to:user-agent; bh=T9GnaEawRoM7EW6cCAycUK+BKWKHO+/IzdIkmZ21yPs=; b=OuVsq7zIpUzeNtUKnyT9mfEPnWS+hnAQHuEX+BHmhG/R6C30IwLxKiJ8wjfMdrD4JD vaUKqj/hHbfph7c1TcinY5j/p2whjklYhxL7LSwHb2FtUXdEkew+lWI5astk/fF/cdhK xOPl0vXguY9GtVuMDtnFRu420kq36zGFA89XmIgBsmJ4tehkXOuRvQ+kJ6xmC7LECOYy n7CPFk0qUAiGifWml7C3VaGOpdwTxytTcsgxJLiFhghH1Bs0tDcHCtidNEa18joiZmQp 0a6ZxJ28buEZhf4JSkj6iEAsTwQWjtnMG01HNFyGBpOjNqRe9I6Hfnml+KP1BK/YyHaC BFlA== X-Gm-Message-State: AKGB3mJ3wlbQxEWIiyhOCS1nc/yuUdZHvrxojv+rwkZBu+zdZtHDtDuk XdcdmpfPrh4bXlJligcCptYbcdOv X-Google-Smtp-Source: ACJfBovZrK0kO/KDyKyeadpcoPwfF/55L6eVTFdOLyduXIwXprFaoah/8dilH3BbHfokkhQCnRyunQ== X-Received: by 10.223.141.133 with SMTP id o5mr16572022wrb.35.1513957837125; Fri, 22 Dec 2017 07:50:37 -0800 (PST) Original-Received: from breton.holly.idiocy.org (ip6-2001-08b0-03f8-8129-2872-d519-1675-2de8.holly.idiocy.org. [2001:8b0:3f8:8129:2872:d519:1675:2de8]) by smtp.gmail.com with ESMTPSA id c2sm21641015wrc.81.2017.12.22.07.50.36 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Fri, 22 Dec 2017 07:50:36 -0800 (PST) Content-Disposition: inline In-Reply-To: <838tdunc3d.fsf@gnu.org> X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 208.118.235.43 X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.org gmane.emacs.bugs:141384 Archived-At: On Fri, Dec 22, 2017 at 03:09:26PM +0200, Eli Zaretskii wrote: > > Date: Fri, 22 Dec 2017 12:34:33 +0000 > > From: Alan Third > > Cc: Paul Rankin , 29595@debbugs.gnu.org > > > > It seems that older macOS versions ignored keyboard shortcuts they > > didn’t understand, but High Sierra appears to use a ‘best effort’ > > attempt which results in it just printing out the first character > > (capital C for ctrl, so shift‐C). > > > > I’ve attached a patch that I hope fixes it. > > Thanks. > > Will this patch work on both old and new versions of macOS? I'd like > to install this on the release branch, but I don't want to cause any > regressions as result of that. Yes. I’m still on the previous macOS version where I can’t see the bug and it makes no difference here. The current code relies on macOS ignoring a string it doesn’t understand, however the documentation explicitly says to use an empty string and the API hasn’t changed. -- Alan Third