all messages for Emacs-related lists mirrored at yhetil.org
 help / color / mirror / code / Atom feed
From: Alan Third <alan@idiocy.org>
To: Eli Zaretskii <eliz@gnu.org>
Cc: 29595@debbugs.gnu.org, hello@paulwrankin.com
Subject: bug#29595: 26.0.90; menu items show incorrect shortcut keys
Date: Fri, 22 Dec 2017 15:50:33 +0000	[thread overview]
Message-ID: <20171222155033.GA36979@breton.holly.idiocy.org> (raw)
In-Reply-To: <838tdunc3d.fsf@gnu.org>

On Fri, Dec 22, 2017 at 03:09:26PM +0200, Eli Zaretskii wrote:
> > Date: Fri, 22 Dec 2017 12:34:33 +0000
> > From: Alan Third <alan@idiocy.org>
> > Cc: Paul Rankin <hello@paulwrankin.com>, 29595@debbugs.gnu.org
> > 
> > It seems that older macOS versions ignored keyboard shortcuts they
> > didn’t understand, but High Sierra appears to use a ‘best effort’
> > attempt which results in it just printing out the first character
> > (capital C for ctrl, so shift‐C).
> > 
> > I’ve attached a patch that I hope fixes it.
> 
> Thanks.
> 
> Will this patch work on both old and new versions of macOS?  I'd like
> to install this on the release branch, but I don't want to cause any
> regressions as result of that.

Yes. I’m still on the previous macOS version where I can’t see the bug
and it makes no difference here.

The current code relies on macOS ignoring a string it doesn’t
understand, however the documentation explicitly says to use an empty
string and the API hasn’t changed.
-- 
Alan Third





  reply	other threads:[~2017-12-22 15:50 UTC|newest]

Thread overview: 11+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2017-12-07  1:35 bug#29595: 26.0.90; menu items show incorrect shortcut keys Paul Rankin
2017-12-07 21:40 ` Alan Third
2017-12-22  5:16 ` Paul Rankin
2017-12-22  7:26   ` Eli Zaretskii
2017-12-22 12:34     ` Alan Third
2017-12-22 13:09       ` Eli Zaretskii
2017-12-22 15:50         ` Alan Third [this message]
2017-12-31  4:03           ` Paul Rankin
2017-12-31 11:40             ` Alan Third
2018-01-01 10:40               ` Paul Rankin
2018-01-01 13:47                 ` Alan Third

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20171222155033.GA36979@breton.holly.idiocy.org \
    --to=alan@idiocy.org \
    --cc=29595@debbugs.gnu.org \
    --cc=eliz@gnu.org \
    --cc=hello@paulwrankin.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this external index

	https://git.savannah.gnu.org/cgit/emacs.git
	https://git.savannah.gnu.org/cgit/emacs/org-mode.git

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.