bug#29712: 26.0.90; Three emacs-26 elisp tests are failing on darwin

[Alan Third <alan@idiocy.org>]

On Thu, Dec 14, 2017 at 08:46:02AM -0800, John Wiegley wrote:
> In order to get the ERT tests to pass on my system, I need to disable the
> following three tests:
> 
> --- i/test/lisp/eshell/em-ls-tests.el
> +++ w/test/lisp/eshell/em-ls-tests.el
> @@ -77,6 +77,7 @@
> 
>  (ert-deftest em-ls-test-bug27844 ()
>    "Test for https://debbugs.gnu.org/27844 ."
> +  (skip-unless (not (eq system-type 'darwin)))
>    (let ((orig eshell-ls-use-in-dired)
>          (dired-use-ls-dired 'unspecified)
>          buf insert-directory-program)

I can’t get this test to fail. Which version of macOS are you running?

> --- i/test/src/fileio-tests.el
> +++ w/test/src/fileio-tests.el
> @@ -48,7 +48,7 @@ fileio-tests--symlink-failure
>    ;; Some Windows versions don't support symlinks, and those which do
>    ;; will pop up UAC elevation prompts, so we disable this test on
>    ;; MS-Windows.
> -  (skip-unless (not (eq system-type 'windows-nt)))
> +  (skip-unless (not (memq system-type '(darwin windows-nt))))
>    (should (equal nil (fileio-tests--symlink-failure))))
> 
>  (ert-deftest fileio-tests--directory-file-name ()

This one fails on the carriage return character. It appears to be
getting converted to a newline character. I can’t work out why, but
I’m sure it’s Emacs that’s doing it.
-- 
Alan Third