bug#23753: 25.0.95; configuration of X client fails to include graphics libraries on Mac OS X 10.6.8

[Alan Third <alan@idiocy.org>]

On Mon, Dec 11, 2017 at 08:16:24PM +0100, Charles A. Roelli wrote:
> > Date: Sun, 10 Dec 2017 22:42:25 +0000
> > From: Alan Third <alan@idiocy.org>
> > 
> > On Sun, Dec 10, 2017 at 04:44:13PM -0500, Richard Stallman wrote:
> > > [[[ To any NSA and FBI agents reading my email: please consider    ]]]
> > > [[[ whether defending the US Constitution against all enemies,     ]]]
> > > [[[ foreign or domestic, requires you to follow Snowden's example. ]]]
> > > 
> > >   > I would think removing this feature from the Emacs sources so that
> > >   > they compile with standard gcc would be a high priority for Emacs.
> > >   > It's surpising this has not come up before.
> > > 
> > > Yes, we must insist on removing them.
> > 
> > Is it acceptable to leave them in when building with Clang? Something like:
> > 
> > #ifdef __clang__
> >  <block>
> > #endif
> > 
> > > Are there any in the Emacs 26 pretest?
> > 
> > Yes, the two in macfont.m.
> > 
> > As for whether there’s any demand for them, I can’t answer that. It
> > might be better to ask the GNUstep people.
> > 
> > Charles, do you know of a better solution than just making them
> > in‐line?
> 
> Nope.  It would also be interesting to find out the performance impact
> on redisplay.  Since the glyph information seems to be cached (?), the
> impact may be negligible.

Yamamoto san, I hope it’s OK to copy you in on this.

In order to make the NS port of Emacs compile on GCC on macOS we need
to remove two instances of Objective‐C blocks in macfont.m. It looks
to me like we can make it run in‐line, i.e. change

      dispatch_group_async (group, queue, ^{
          glyphs[i] = kCGFontIndexInvalid;

          if (default_uvs_offset)
            {
              struct default_uvs_table *default_uvs =
                (struct default_uvs_table *) ((UInt8 *) uvs


to just

      {
          glyphs[i] = kCGFontIndexInvalid;

          if (default_uvs_offset)
            {
              struct default_uvs_table *default_uvs =
                (struct default_uvs_table *) ((UInt8 *) uvs

As far as I can see this will still work, but we’re not sure whether
it will cause any problems. Since this is, I believe, your code, do
you have any thoughts on the matter?
-- 
Alan Third