From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!.POSTED!not-for-mail From: Alan Mackenzie Newsgroups: gmane.emacs.devel Subject: Re: Old-style backquotes Date: Sat, 9 Dec 2017 20:48:31 +0000 Message-ID: <20171209204831.GC15719@ACM> References: <46860d72-9c7e-2c80-5fe3-e17f5ccd6e2d@cs.ucla.edu> <83h8vg1dhy.fsf@gnu.org> <83376ttyji.fsf@gnu.org> <831smdtycz.fsf@gnu.org> <83zi91sigu.fsf@gnu.org> NNTP-Posting-Host: blaine.gmane.org Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit X-Trace: blaine.gmane.org 1512852954 26976 195.159.176.226 (9 Dec 2017 20:55:54 GMT) X-Complaints-To: usenet@blaine.gmane.org NNTP-Posting-Date: Sat, 9 Dec 2017 20:55:54 +0000 (UTC) User-Agent: Mutt/1.7.2 (2016-11-26) Cc: Eli Zaretskii , eggert@cs.ucla.edu, emacs-devel@gnu.org To: Philipp Stephani Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Sat Dec 09 21:55:50 2017 Return-path: Envelope-to: ged-emacs-devel@m.gmane.org Original-Received: from lists.gnu.org ([208.118.235.17]) by blaine.gmane.org with esmtp (Exim 4.84_2) (envelope-from ) id 1eNmA1-0006dr-SM for ged-emacs-devel@m.gmane.org; Sat, 09 Dec 2017 21:55:49 +0100 Original-Received: from localhost ([::1]:42540 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1eNmA3-0007DC-2p for ged-emacs-devel@m.gmane.org; Sat, 09 Dec 2017 15:55:51 -0500 Original-Received: from eggs.gnu.org ([2001:4830:134:3::10]:42191) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1eNm9w-0007Cb-Fb for emacs-devel@gnu.org; Sat, 09 Dec 2017 15:55:45 -0500 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1eNm9t-0002Jx-E6 for emacs-devel@gnu.org; Sat, 09 Dec 2017 15:55:44 -0500 Original-Received: from colin.muc.de ([193.149.48.1]:26176 helo=mail.muc.de) by eggs.gnu.org with smtp (Exim 4.71) (envelope-from ) id 1eNm9t-0002IT-7a for emacs-devel@gnu.org; Sat, 09 Dec 2017 15:55:41 -0500 Original-Received: (qmail 1586 invoked by uid 3782); 9 Dec 2017 20:55:37 -0000 Original-Received: from acm.muc.de (p548C7E8D.dip0.t-ipconnect.de [84.140.126.141]) by colin.muc.de (tmda-ofmipd) with ESMTP; Sat, 09 Dec 2017 21:55:35 +0100 Original-Received: (qmail 19313 invoked by uid 1000); 9 Dec 2017 20:48:31 -0000 Content-Disposition: inline In-Reply-To: X-Delivery-Agent: TMDA/1.1.12 (Macallan) X-Primary-Address: acm@muc.de X-detected-operating-system: by eggs.gnu.org: FreeBSD 9.x [fuzzy] X-Received-From: 193.149.48.1 X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Original-Sender: "Emacs-devel" Xref: news.gmane.org gmane.emacs.devel:220830 Archived-At: Hello, Philipp. On Sat, Dec 09, 2017 at 20:44:35 +0000, Philipp Stephani wrote: > Philipp Stephani schrieb am So., 8. Okt. 2017 um > 18:59 Uhr: > > Eli Zaretskii schrieb am So., 8. Okt. 2017 um 18:38 Uhr: > >> > From: Philipp Stephani > >> > Date: Sun, 08 Oct 2017 16:25:44 +0000 > >> > Cc: eggert@cs.ucla.edu, emacs-devel@gnu.org > >> > Here's a new patch that also fixes the byte compiler tests. > >> Thanks, LGTM, but please mention the NEWS change in the log message. > >> Also, the log message should quote 'like this', not ‘like this’. > > Fixed and pushed as 9613690f6e to master. > I've now fixed the Bovine issue and re-pushed this commit as 8b8197235f to > master. Just as a matter of interest, I think there are still some old style backquotes in advice.el. In master: find . -name '*.el' | xargs grep -n '(` ' produces: ./emacs-lisp/advice.el:1517:;; (` (list (, x)))) ./emacs-lisp/advice.el:1550:;; (` (progn (print (, x)) . Do these need converting? -- Alan Mackenzie (Nuremberg, Germany).