From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!.POSTED!not-for-mail From: Alan Third Newsgroups: gmane.emacs.bugs Subject: bug#29565: [PATCH] Support xwidget webkit for macOS X Date: Mon, 4 Dec 2017 20:59:43 +0000 Message-ID: <20171204205943.GA38879@breton.holly.idiocy.org> References: NNTP-Posting-Host: blaine.gmane.org Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit X-Trace: blaine.gmane.org 1512421321 30312 195.159.176.226 (4 Dec 2017 21:02:01 GMT) X-Complaints-To: usenet@blaine.gmane.org NNTP-Posting-Date: Mon, 4 Dec 2017 21:02:01 +0000 (UTC) User-Agent: Mutt/1.9.1 (2017-09-22) Cc: 29565@debbugs.gnu.org To: Jaesup Kwak Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Mon Dec 04 22:01:55 2017 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane.org Original-Received: from lists.gnu.org ([208.118.235.17]) by blaine.gmane.org with esmtp (Exim 4.84_2) (envelope-from ) id 1eLxs6-0007I8-HJ for geb-bug-gnu-emacs@m.gmane.org; Mon, 04 Dec 2017 22:01:50 +0100 Original-Received: from localhost ([::1]:45213 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1eLxsD-0000v8-Qw for geb-bug-gnu-emacs@m.gmane.org; Mon, 04 Dec 2017 16:01:57 -0500 Original-Received: from eggs.gnu.org ([2001:4830:134:3::10]:45094) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1eLxrO-0000X0-JK for bug-gnu-emacs@gnu.org; Mon, 04 Dec 2017 16:01:09 -0500 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1eLxrK-0004qs-CO for bug-gnu-emacs@gnu.org; Mon, 04 Dec 2017 16:01:06 -0500 Original-Received: from debbugs.gnu.org ([208.118.235.43]:37313) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1eLxrK-0004qj-83 for bug-gnu-emacs@gnu.org; Mon, 04 Dec 2017 16:01:02 -0500 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1eLxrJ-0006vk-Qk for bug-gnu-emacs@gnu.org; Mon, 04 Dec 2017 16:01:01 -0500 X-Loop: help-debbugs@gnu.org Resent-From: Alan Third Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Mon, 04 Dec 2017 21:01:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 29565 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: patch Original-Received: via spool by 29565-submit@debbugs.gnu.org id=B29565.151242120426515 (code B ref 29565); Mon, 04 Dec 2017 21:01:01 +0000 Original-Received: (at 29565) by debbugs.gnu.org; 4 Dec 2017 21:00:04 +0000 Original-Received: from localhost ([127.0.0.1]:45994 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1eLxqJ-0006si-69 for submit@debbugs.gnu.org; Mon, 04 Dec 2017 16:00:04 -0500 Original-Received: from mail-wr0-f175.google.com ([209.85.128.175]:41082) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1eLxqC-0006sO-9C for 29565@debbugs.gnu.org; Mon, 04 Dec 2017 15:59:57 -0500 Original-Received: by mail-wr0-f175.google.com with SMTP id z18so18844644wrb.8 for <29565@debbugs.gnu.org>; Mon, 04 Dec 2017 12:59:52 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=googlemail.com; s=20161025; h=sender:date:from:to:cc:subject:message-id:references:mime-version :content-disposition:content-transfer-encoding:in-reply-to :user-agent; bh=J31WQ6ZynO9ex0CD/XeHkGZmY9axx6MmPqhd79OIr5k=; b=gqmy2eZJaZIhr0lycNr8RnN+PcxpJIvetCxMZ8OMnQaDLmgFti3zb8JZ0nXs7qZ3W7 MuRr19hn51pjND+oaBiiQLaGQQOp0IfWC09aQrUtyH/BS8WW9wB3YGiH80XkoNB3I0WR 5jhGVTTvR+PtYQ54cacr7vtm0R/P2sKPbmU2RkEEX1J9RPV4U49+cMuU/vuxvyHoOHNz og6w8g4HkuUCsc7f0+5//lXFLUZRGQZOlBOxe2cThB53IqG6HXS9euz1c3p5BkuyJRyM K0MQEJCONh9n2+P2v47X0P2opfJ+VqNgv9XCWORPuLmoxfVtdsM6f2gq2paQ2zbjFFRW x4tQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:sender:date:from:to:cc:subject:message-id :references:mime-version:content-disposition :content-transfer-encoding:in-reply-to:user-agent; bh=J31WQ6ZynO9ex0CD/XeHkGZmY9axx6MmPqhd79OIr5k=; b=eF9xftczRSI2PxtMOrLpVOa52+YEZW4xpI1l+a6spYxfTKjNHMcG3BYh9lmmXuEoaS T0IvRUFl8mITiBzynLy6WXNEw7O4u9s1RhSVgrk27iKE11eMovSKwc2upF+i9lmM0Kb1 nufwASz2Puq1VuF0hSoJ5UERxWvhTMVO/Tkk05s3NeIdfkXwCOtQq0NXM1dAPAsdq8M6 CGO6X76vQnmL4Wm9EEmvaxr450G8jQZ5hrmjDzJr/QwbnbKyZ04WCeSHrsOmV+Mbb+VR oW6x6vBCtUxswigNSxJMk0UawsbgjYBYxotpKl9Ko69gzmX8cxqRMJNVZMZuqzXutqjO HDCQ== X-Gm-Message-State: AJaThX7+FoNZqy7WvNsFSk+gsyDoE5h/qV1sFjFJLlIdMUwrEkkP2S3N YP6lVcxFO7O0CirRYPOYFdPSpTZT X-Google-Smtp-Source: AGs4zMZyna1TXATNKO87lu+0g1wAA6CHOLFPQuqeRtWNx21ZMlFilWVc6woMmJMcsyuVUpQZhda0ZA== X-Received: by 10.223.181.150 with SMTP id c22mr16178119wre.0.1512421186380; Mon, 04 Dec 2017 12:59:46 -0800 (PST) Original-Received: from breton.holly.idiocy.org (ip6-2001-08b0-03f8-8129-0862-5dc3-379c-8bbf.holly.idiocy.org. [2001:8b0:3f8:8129:862:5dc3:379c:8bbf]) by smtp.gmail.com with ESMTPSA id k19sm16591975wrk.88.2017.12.04.12.59.45 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Mon, 04 Dec 2017 12:59:45 -0800 (PST) Content-Disposition: inline In-Reply-To: X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 208.118.235.43 X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.org gmane.emacs.bugs:140698 Archived-At: On Tue, Dec 05, 2017 at 01:44:42AM +0900, Jaesup Kwak wrote: > I attached a patch to support xwidget webkit for macOS X, rebased onto the > latest master. Hi, thanks for working on this, it looks really good. I’ve had a quick glance over it and I have a few comments. In configure.ac you’re doing elif test "$window_system" = "nextstep"; then I think instead of that you should be doing elif test "${NS_IMPL_COCOA}" = "yes"; then as nextstep covers GNUstep, but it doesn’t have a webkit implementation (yet). There might be other places where NS_IMPL_COCOA is more appropriate than HAVE_NS, but it builds fine against GNUstep with xwidgets off, so it’s not too important. I notice you’re adding .DS_Store to .gitignore, which is a good idea, but I don’t think it should be done in this patch. It seems a little off‐topic. I’m also a little unsure about this NSAppTransportSecurity NSAllowsArbitraryLoads The comment says ‘uncomment’, but it *is* uncommented. Am I misunderstanding? (Also I think there should be two spaces at the end of comments.) I think we’ll want to add NSTRACE lines in each function, but perhaps we should create a new category for XWidgets. -- Alan Third