From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!.POSTED!not-for-mail From: Alan Third Newsgroups: gmane.emacs.bugs Subject: bug#29353: [PATCH] Add window divider faces to NS (bug#29353) Date: Sun, 19 Nov 2017 23:23:01 +0000 Message-ID: <20171119232301.GB78887@breton.holly.idiocy.org> References: NNTP-Posting-Host: blaine.gmane.org Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit X-Trace: blaine.gmane.org 1511133854 13814 195.159.176.226 (19 Nov 2017 23:24:14 GMT) X-Complaints-To: usenet@blaine.gmane.org NNTP-Posting-Date: Sun, 19 Nov 2017 23:24:14 +0000 (UTC) User-Agent: Mutt/1.9.1 (2017-09-22) Cc: 29353@debbugs.gnu.org To: Keith David Bershatsky Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Mon Nov 20 00:24:08 2017 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane.org Original-Received: from lists.gnu.org ([208.118.235.17]) by blaine.gmane.org with esmtp (Exim 4.84_2) (envelope-from ) id 1eGYwV-0002yE-A9 for geb-bug-gnu-emacs@m.gmane.org; Mon, 20 Nov 2017 00:24:03 +0100 Original-Received: from localhost ([::1]:54702 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1eGYwc-0004V3-M2 for geb-bug-gnu-emacs@m.gmane.org; Sun, 19 Nov 2017 18:24:10 -0500 Original-Received: from eggs.gnu.org ([2001:4830:134:3::10]:45461) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1eGYwX-0004Um-5k for bug-gnu-emacs@gnu.org; Sun, 19 Nov 2017 18:24:06 -0500 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1eGYwT-0002Lr-VG for bug-gnu-emacs@gnu.org; Sun, 19 Nov 2017 18:24:05 -0500 Original-Received: from debbugs.gnu.org ([208.118.235.43]:39359) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1eGYwT-0002Lb-Ql for bug-gnu-emacs@gnu.org; Sun, 19 Nov 2017 18:24:01 -0500 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1eGYwT-0005Co-Lk for bug-gnu-emacs@gnu.org; Sun, 19 Nov 2017 18:24:01 -0500 X-Loop: help-debbugs@gnu.org Resent-From: Alan Third Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Sun, 19 Nov 2017 23:24:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 29353 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: Original-Received: via spool by 29353-submit@debbugs.gnu.org id=B29353.151113379219951 (code B ref 29353); Sun, 19 Nov 2017 23:24:01 +0000 Original-Received: (at 29353) by debbugs.gnu.org; 19 Nov 2017 23:23:12 +0000 Original-Received: from localhost ([127.0.0.1]:48040 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1eGYvg-0005Bi-72 for submit@debbugs.gnu.org; Sun, 19 Nov 2017 18:23:12 -0500 Original-Received: from mail-wm0-f41.google.com ([74.125.82.41]:35930) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1eGYve-0005BW-QD for 29353@debbugs.gnu.org; Sun, 19 Nov 2017 18:23:11 -0500 Original-Received: by mail-wm0-f41.google.com with SMTP id r68so15428613wmr.1 for <29353@debbugs.gnu.org>; Sun, 19 Nov 2017 15:23:10 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=googlemail.com; s=20161025; h=sender:date:from:to:cc:subject:message-id:references:mime-version :content-disposition:content-transfer-encoding:in-reply-to :user-agent; bh=PiYKtio8j6u0L3RCcK5SRLBx4hiNCYEWFj4/OL7CTl0=; b=AMdb8zb0Rq7AwuZP6C+3TmXObHP5MaILkcx5/qAgeiIAp9vSX7YORKPOp0tDJ17+BJ C6FhZPZLrBNKUU6hvKZ3Jy4ixD4XkPiCZKLMZ52IY+G8QdHju23oYEyetvUTC8iw1C+U Nbq6tLxZZ+bsnqZh54C/a4rzAs5U1LdTkGXIaqN4e9wDH61obIEQRPXFDFf6pbVqq2/S vU5vDevaO9ZGqO5gXkXFVmPCCT+Blp0/Tyjr7i+hOmE2gTHkPUpq+jw9wgu9IyKEt6vO W8SkFypBIr36ZpKn3z3bTyy4rnNeXEJYgbsSQVC51ibvGVOmj5sdDb8z7Kb0fWIQdwLS hrpA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:sender:date:from:to:cc:subject:message-id :references:mime-version:content-disposition :content-transfer-encoding:in-reply-to:user-agent; bh=PiYKtio8j6u0L3RCcK5SRLBx4hiNCYEWFj4/OL7CTl0=; b=gbWfOlTDUHINkURceFO8QHCoQ5VxOWHvqi3AXkM1UC5mUZxdEqlQKjNO9gKIB+C5v3 gyWfLSTNXRxRj8m76IucLPXjd/19+xai8VqdMfnDZoc+uuQg5a7Xngd4ag+zrN3NYq7i L2bk16132UeamBOGUoV24AqAKFWmPkZI6BJmY1L8MAZhMJIKjM9T9pMrpDbCEJZ6cCdW ACBJaCuJdE/LVUD3VUQUDNyKglC39EOVXo7f44a3WAL7FINAvx8PVJtfdCsrHBTKx46W VHUdZyy9lsTouXCGabKHo4Fox09xHQrf/7UVVv6Yy5/G1JcYjn2Flz7xiegHsFkzH9b8 Nf6g== X-Gm-Message-State: AJaThX71YXvfGcIBU5Edvl5PM0e2tMSG+eaXqGWe+vJizh46eEqIE/Be ijS9QMMqYkd+zdvtMsnLwQjcHTAY X-Google-Smtp-Source: AGs4zMYNvNGQN3qLgXmfId7Z3rT4aBbfYt0WYnEOB2f3ETJjWAD5gGoeKCJKxjTQ+CYiMkoidvRGQA== X-Received: by 10.80.245.172 with SMTP id u41mr16778984edm.195.1511133785015; Sun, 19 Nov 2017 15:23:05 -0800 (PST) Original-Received: from breton.holly.idiocy.org (ip6-2001-08b0-03f8-8129-d0a1-6256-0ea2-6f72.holly.idiocy.org. [2001:8b0:3f8:8129:d0a1:6256:ea2:6f72]) by smtp.gmail.com with ESMTPSA id 30sm6800536edz.42.2017.11.19.15.23.04 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Sun, 19 Nov 2017 15:23:04 -0800 (PST) Content-Disposition: inline In-Reply-To: X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 208.118.235.43 X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.org gmane.emacs.bugs:140127 Archived-At: On Sun, Nov 19, 2017 at 12:40:09PM -0800, Keith David Bershatsky wrote: > The only issue I observed with the patch applied is when a user > selects a divider width of 3 for right and bottom. In that > situation, the bottom divider is entirely one color -- > window-divider face. I can replicate this. It’s because I copied the code verbatim from xterm.c, and it does a comparison against 3 instead of 2, so this might be a bug in X builds too. > And, the right divider is 2 pixels in the window-divider-first-pixel > face and 1 pixel in the window-divider-last-pixel face. When there > are exactly 3 pixels, both dividers should have the rainbow of all > three available colors in the applicable order. I can’t replicate this. I definitely see three colours in the vertical divider. modified src/nsterm.m @@ -3202,7 +3202,7 @@ Note that CURSOR_WIDTH is meaningful only for (h)bar cursors. [ns_lookup_indexed_color(color_last, f) set]; NSRectFill(NSMakeRect (x1 - 1, y0, 1, y1 - y0)); } - else if (x1 - x0 > y1 - y0 && y1 - y0 > 3) + else if (x1 - x0 > y1 - y0 && y1 - y0 > 2) /* Horizontal. */ { [ns_lookup_indexed_color(color_first, f) set]; -- Alan Third