From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!.POSTED!not-for-mail From: Alan Mackenzie Newsgroups: gmane.emacs.bugs Subject: bug#29349: [Patch] Bug 29349: read_key_sequence is only partially recursive. This is a bug. Date: Sun, 19 Nov 2017 20:41:21 +0000 Message-ID: <20171119204121.GE9922@ACM> References: <20171118093843.GA3819@ACM> <20171119123456.GA4576@ACM> <20171119155908.GB4576@ACM> <83tvxqdwyy.fsf@gnu.org> <20171119174521.GB9922@ACM> <83mv3idu4w.fsf@gnu.org> NNTP-Posting-Host: blaine.gmane.org Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii X-Trace: blaine.gmane.org 1511124316 4551 195.159.176.226 (19 Nov 2017 20:45:16 GMT) X-Complaints-To: usenet@blaine.gmane.org NNTP-Posting-Date: Sun, 19 Nov 2017 20:45:16 +0000 (UTC) User-Agent: Mutt/1.7.2 (2016-11-26) Cc: 29349@debbugs.gnu.org To: Eli Zaretskii Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Sun Nov 19 21:45:10 2017 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane.org Original-Received: from lists.gnu.org ([208.118.235.17]) by blaine.gmane.org with esmtp (Exim 4.84_2) (envelope-from ) id 1eGWSh-0000hg-Uo for geb-bug-gnu-emacs@m.gmane.org; Sun, 19 Nov 2017 21:45:08 +0100 Original-Received: from localhost ([::1]:54334 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1eGWSp-0008CD-Da for geb-bug-gnu-emacs@m.gmane.org; Sun, 19 Nov 2017 15:45:15 -0500 Original-Received: from eggs.gnu.org ([2001:4830:134:3::10]:43035) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1eGWSf-00089M-CK for bug-gnu-emacs@gnu.org; Sun, 19 Nov 2017 15:45:08 -0500 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1eGWSc-0007vT-8t for bug-gnu-emacs@gnu.org; Sun, 19 Nov 2017 15:45:05 -0500 Original-Received: from debbugs.gnu.org ([208.118.235.43]:39300) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1eGWSc-0007vP-4W for bug-gnu-emacs@gnu.org; Sun, 19 Nov 2017 15:45:02 -0500 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1eGWSb-0001ej-U0 for bug-gnu-emacs@gnu.org; Sun, 19 Nov 2017 15:45:01 -0500 X-Loop: help-debbugs@gnu.org Resent-From: Alan Mackenzie Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Sun, 19 Nov 2017 20:45:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 29349 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: Original-Received: via spool by 29349-submit@debbugs.gnu.org id=B29349.15111242646309 (code B ref 29349); Sun, 19 Nov 2017 20:45:01 +0000 Original-Received: (at 29349) by debbugs.gnu.org; 19 Nov 2017 20:44:24 +0000 Original-Received: from localhost ([127.0.0.1]:47981 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1eGWRz-0001dh-OO for submit@debbugs.gnu.org; Sun, 19 Nov 2017 15:44:23 -0500 Original-Received: from ocolin.muc.de ([193.149.48.4]:36909 helo=mail.muc.de) by debbugs.gnu.org with smtp (Exim 4.84_2) (envelope-from ) id 1eGWRy-0001dZ-8S for 29349@debbugs.gnu.org; Sun, 19 Nov 2017 15:44:22 -0500 Original-Received: (qmail 41593 invoked by uid 3782); 19 Nov 2017 20:44:19 -0000 Original-Received: from acm.muc.de (p548C7514.dip0.t-ipconnect.de [84.140.117.20]) by colin.muc.de (tmda-ofmipd) with ESMTP; Sun, 19 Nov 2017 21:44:18 +0100 Original-Received: (qmail 19091 invoked by uid 1000); 19 Nov 2017 20:41:21 -0000 Content-Disposition: inline In-Reply-To: <83mv3idu4w.fsf@gnu.org> X-Delivery-Agent: TMDA/1.1.12 (Macallan) X-Primary-Address: acm@muc.de X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 208.118.235.43 X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.org gmane.emacs.bugs:140120 Archived-At: Hello, Eli. On Sun, Nov 19, 2017 at 20:02:23 +0200, Eli Zaretskii wrote: > > Date: Sun, 19 Nov 2017 17:45:22 +0000 > > Cc: 29349@debbugs.gnu.org > > From: Alan Mackenzie > > In the emacs-26 branch, in a Linux tty with GPM configured and working, > > type: > > C-h c C-mouse-3 mouse-1 mouse-1 > > , without moving the mouse. This will end up clicking on > > "emacs-tutorial". The message printed in the message area is then: > > (translated from > > ) at that spot runs the command > > help-with-tutorial > > . In the "translated from ", the first event, > > C-mouse-3 has been overwritten by mouse-1. This mouse-1 is a mouse-click > > from the menu processing. `describe-key-briefly' can then do nothing > > other than printing a spurious "translated from" message. > > With the patch applied, the C-down-mouse-3 survives in the raw key > > buffer, enabling `describe-key-briefly' to do the Right Thing. It does > > this by collecting the menu processing's mouse events in a separate > > buffer, then copying that buffer to the main one afterwards. > OK, but then (a) please install the patch on master, not on the > release branch, .... I'll do that, but probably not tonight. > .... and (b) why do we need the followup patch -- with the mouse-1 > events injected into the sequence the "translation" looks correct and > even educational. I don't think it looks correct. The C-down-mouse-3 which exists as an essential part of the key sequence has been overwritten in the "translation". The other thing is that if mouse-movements get into the raw event buffer (which I've seen, but for some reason amn't seeing any more) the "translated from" could become objectionably long. I think the "translated from" bit is intended to document a sequence the user is aware of (such as a double click) being translated into a different sequence she's aware of (such as a single click). The mouse-1, I believe, is more part of the user's subconsciousness rather than awareness. > Thanks. -- Alan Mackenzie (Nuremberg, Germany).