From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!.POSTED!not-for-mail From: Alan Mackenzie Newsgroups: gmane.emacs.bugs Subject: bug#29349: [Patch] Bug 29349: read_key_sequence is only partially recursive. This is a bug. Date: Sun, 19 Nov 2017 17:45:22 +0000 Message-ID: <20171119174521.GB9922@ACM> References: <20171118093843.GA3819@ACM> <20171119123456.GA4576@ACM> <20171119155908.GB4576@ACM> <83tvxqdwyy.fsf@gnu.org> NNTP-Posting-Host: blaine.gmane.org Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii X-Trace: blaine.gmane.org 1511113756 31586 195.159.176.226 (19 Nov 2017 17:49:16 GMT) X-Complaints-To: usenet@blaine.gmane.org NNTP-Posting-Date: Sun, 19 Nov 2017 17:49:16 +0000 (UTC) User-Agent: Mutt/1.7.2 (2016-11-26) Cc: 29349@debbugs.gnu.org To: Eli Zaretskii Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Sun Nov 19 18:49:11 2017 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane.org Original-Received: from lists.gnu.org ([208.118.235.17]) by blaine.gmane.org with esmtp (Exim 4.84_2) (envelope-from ) id 1eGTiP-0007eC-TR for geb-bug-gnu-emacs@m.gmane.org; Sun, 19 Nov 2017 18:49:10 +0100 Original-Received: from localhost ([::1]:53869 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1eGTiV-0004h9-DE for geb-bug-gnu-emacs@m.gmane.org; Sun, 19 Nov 2017 12:49:15 -0500 Original-Received: from eggs.gnu.org ([2001:4830:134:3::10]:35413) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1eGTiN-0004go-Di for bug-gnu-emacs@gnu.org; Sun, 19 Nov 2017 12:49:09 -0500 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1eGTiI-00069V-8A for bug-gnu-emacs@gnu.org; Sun, 19 Nov 2017 12:49:07 -0500 Original-Received: from debbugs.gnu.org ([208.118.235.43]:39087) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1eGTiI-000695-44 for bug-gnu-emacs@gnu.org; Sun, 19 Nov 2017 12:49:02 -0500 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1eGTiH-00060V-Tt for bug-gnu-emacs@gnu.org; Sun, 19 Nov 2017 12:49:01 -0500 X-Loop: help-debbugs@gnu.org Resent-From: Alan Mackenzie Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Sun, 19 Nov 2017 17:49:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 29349 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: Original-Received: via spool by 29349-submit@debbugs.gnu.org id=B29349.151111370623050 (code B ref 29349); Sun, 19 Nov 2017 17:49:01 +0000 Original-Received: (at 29349) by debbugs.gnu.org; 19 Nov 2017 17:48:26 +0000 Original-Received: from localhost ([127.0.0.1]:47768 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1eGThh-0005zi-Qa for submit@debbugs.gnu.org; Sun, 19 Nov 2017 12:48:26 -0500 Original-Received: from ocolin.muc.de ([193.149.48.4]:21461 helo=mail.muc.de) by debbugs.gnu.org with smtp (Exim 4.84_2) (envelope-from ) id 1eGThf-0005zZ-Vx for 29349@debbugs.gnu.org; Sun, 19 Nov 2017 12:48:24 -0500 Original-Received: (qmail 91401 invoked by uid 3782); 19 Nov 2017 17:48:20 -0000 Original-Received: from acm.muc.de (p548C7514.dip0.t-ipconnect.de [84.140.117.20]) by colin.muc.de (tmda-ofmipd) with ESMTP; Sun, 19 Nov 2017 18:48:19 +0100 Original-Received: (qmail 10524 invoked by uid 1000); 19 Nov 2017 17:45:22 -0000 Content-Disposition: inline In-Reply-To: <83tvxqdwyy.fsf@gnu.org> X-Delivery-Agent: TMDA/1.1.12 (Macallan) X-Primary-Address: acm@muc.de X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 208.118.235.43 X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.org gmane.emacs.bugs:140106 Archived-At: Hello, Eli. On Sun, Nov 19, 2017 at 19:01:09 +0200, Eli Zaretskii wrote: > > Date: Sun, 19 Nov 2017 15:59:08 +0000 > > From: Alan Mackenzie > > > > In a Linux tty using the GPM mouse package, doing read_key_sequence (the > > > > C function in keyboard.c), when a menu action is activated, > > > > read_key_sequence calls itself recursively to handle all the mouse > > > > manipulation. > > > > Unfortunately, the variable raw_keybuf_count is initialised to 0 in > > > > r_k_s. This includes in the recursive call. This variable indexes the > > > > global buffer raw_keybuf, which accumulates the raw events which make up > > > > the key sequence. > > > > The result of this is that the events in the recursive call overwrite > > > > the stored events of the outer r_k_s call, leaving a mess. > > > > r_k_s is static in keyboard.c and is called from three functions: > > > > command_loop_1, read_menu_command (the one that gives the trouble), and > > > > read_key_sequence_vs. > > > > So I propose as a solution that raw_keybuf_count be initialised to zero > > > > in two of these three functions, but not in read_menu_command (and no > > > > longer in read_key_sequence). I've tried this, and it seems to work. > > > > It has the disadvantage of being ugly, and it makes read_menu_command > > > > only callable as a subfunction of r_k_s. > > > > Has anybody any thoughts on this? > > > Here is how I propose to solve this: > Can you please show a recipe where the current code misbehaves? I've > re-read the thread, and found myself confused wrt the practical > implications of the problem you describe. In the emacs-26 branch, in a Linux tty with GPM configured and working, type: C-h c C-mouse-3 mouse-1 mouse-1 , without moving the mouse. This will end up clicking on "emacs-tutorial". The message printed in the message area is then: (translated from ) at that spot runs the command help-with-tutorial . In the "translated from ", the first event, C-mouse-3 has been overwritten by mouse-1. This mouse-1 is a mouse-click from the menu processing. `describe-key-briefly' can then do nothing other than printing a spurious "translated from" message. With the patch applied, the C-down-mouse-3 survives in the raw key buffer, enabling `describe-key-briefly' to do the Right Thing. It does this by collecting the menu processing's mouse events in a separate buffer, then copying that buffer to the main one afterwards. > Thanks. -- Alan Mackenzie (Nuremberg, Germany).