* bug#29171: nsterm.m - unnecessary definition
@ 2017-11-06 15:13 Riccardo Mottola
2017-11-06 20:08 ` Alan Third
0 siblings, 1 reply; 3+ messages in thread
From: Riccardo Mottola @ 2017-11-06 15:13 UTC (permalink / raw)
To: 29171
Hi,
for GNUstep, the definition:
NSString *NSMenuDidBeginTrackingNotification;
at line 72 of nsterm.m is not needed, actually it results in:
nsterm.m:72:18: error: conflicting type qualifiers for
'NSMenuDidBeginTrackingNotification'
extern NSString *NSMenuDidBeginTrackingNotification;
^
In file included from /System/Library/Headers/AppKit/AppKit.h:90:0,
from nsgui.h:34,
from dispextern.h:76,
from nsterm.h:21,
from nsterm.m:48:
/System/Library/Headers/AppKit/NSMenu.h:823:31: note: previous
declaration of 'NSMenuDidBeginTrackingNotification' was here
APPKIT_EXPORT NSString* const NSMenuDidBeginTrackingNotification;
^
Makefile:381: recipe for target 'nsterm.o' failed
Thus either leave it only for MacOS (e.g. #ifndef GNUSTEP) or remove it
totally if it is not needed on mac.
Thanks - Riccardo
^ permalink raw reply [flat|nested] 3+ messages in thread
* bug#29171: nsterm.m - unnecessary definition
2017-11-06 15:13 bug#29171: nsterm.m - unnecessary definition Riccardo Mottola
@ 2017-11-06 20:08 ` Alan Third
2017-11-06 20:15 ` Alan Third
0 siblings, 1 reply; 3+ messages in thread
From: Alan Third @ 2017-11-06 20:08 UTC (permalink / raw)
To: Riccardo Mottola; +Cc: 29171
On Mon, Nov 06, 2017 at 04:13:32PM +0100, Riccardo Mottola wrote:
> for GNUstep, the definition:
>
> NSString *NSMenuDidBeginTrackingNotification;
>
> at line 72 of nsterm.m is not needed, actually it results in:
We’re not defining that anywhere in our code, and certainly not on
line 72 of nsterm.m which looks like:
#ifdef NS_IMPL_COCOA
> nsterm.m:72:18: error: conflicting type qualifiers for
> 'NSMenuDidBeginTrackingNotification'
> extern NSString *NSMenuDidBeginTrackingNotification;
> ^
> In file included from /System/Library/Headers/AppKit/AppKit.h:90:0,
> from nsgui.h:34,
> from dispextern.h:76,
> from nsterm.h:21,
> from nsterm.m:48:
> /System/Library/Headers/AppKit/NSMenu.h:823:31: note: previous declaration
> of 'NSMenuDidBeginTrackingNotification' was here APPKIT_EXPORT NSString*
> const NSMenuDidBeginTrackingNotification;
> ^
> Makefile:381: recipe for target 'nsterm.o' failed
It looks to me like two different GNUstep headers are defining it.
I can’t reproduce this error myself. What platform are you building on?
--
Alan Third
^ permalink raw reply [flat|nested] 3+ messages in thread
* bug#29171: nsterm.m - unnecessary definition
2017-11-06 20:08 ` Alan Third
@ 2017-11-06 20:15 ` Alan Third
0 siblings, 0 replies; 3+ messages in thread
From: Alan Third @ 2017-11-06 20:15 UTC (permalink / raw)
To: Riccardo Mottola; +Cc: 29171-done
On Mon, Nov 06, 2017 at 08:08:25PM +0000, Alan Third wrote:
> On Mon, Nov 06, 2017 at 04:13:32PM +0100, Riccardo Mottola wrote:
> > for GNUstep, the definition:
> >
> > NSString *NSMenuDidBeginTrackingNotification;
> >
> > at line 72 of nsterm.m is not needed, actually it results in:
>
> We’re not defining that anywhere in our code, and certainly not on
> line 72 of nsterm.m which looks like:
Sorry, spoke too soon. The definition is in Emacs 25, but it’s already
been removed in Emacs 26.
Please try the Emacs 26 pre‐release.
--
Alan Third
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2017-11-06 20:15 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2017-11-06 15:13 bug#29171: nsterm.m - unnecessary definition Riccardo Mottola
2017-11-06 20:08 ` Alan Third
2017-11-06 20:15 ` Alan Third
Code repositories for project(s) associated with this external index
https://git.savannah.gnu.org/cgit/emacs.git
https://git.savannah.gnu.org/cgit/emacs/org-mode.git
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.