From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!.POSTED!not-for-mail From: Alan Third Newsgroups: gmane.emacs.bugs Subject: bug#28872: 26.0.90; non-native-fullscreen does not play well with ns-transparent-titlebar on macOS Date: Wed, 25 Oct 2017 14:38:20 +0100 Message-ID: <20171025133820.GA54299@breton.holly.idiocy.org> References: <20171017142558.GA2460@breton.holly.idiocy.org> <20171019111710.GA12599@breton.holly.idiocy.org> NNTP-Posting-Host: blaine.gmane.org Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit X-Trace: blaine.gmane.org 1508938883 8130 195.159.176.226 (25 Oct 2017 13:41:23 GMT) X-Complaints-To: usenet@blaine.gmane.org NNTP-Posting-Date: Wed, 25 Oct 2017 13:41:23 +0000 (UTC) User-Agent: Mutt/1.9.0 (2017-09-02) Cc: 28872@debbugs.gnu.org To: Aaron Jensen Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Wed Oct 25 15:41:17 2017 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane.org Original-Received: from lists.gnu.org ([208.118.235.17]) by blaine.gmane.org with esmtp (Exim 4.84_2) (envelope-from ) id 1e7Lve-0000Hc-DV for geb-bug-gnu-emacs@m.gmane.org; Wed, 25 Oct 2017 15:41:06 +0200 Original-Received: from localhost ([::1]:48394 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1e7Lvl-00071t-RZ for geb-bug-gnu-emacs@m.gmane.org; Wed, 25 Oct 2017 09:41:13 -0400 Original-Received: from eggs.gnu.org ([2001:4830:134:3::10]:60424) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1e7Lti-0005Z3-Fs for bug-gnu-emacs@gnu.org; Wed, 25 Oct 2017 09:39:07 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1e7Lte-0005yP-61 for bug-gnu-emacs@gnu.org; Wed, 25 Oct 2017 09:39:06 -0400 Original-Received: from debbugs.gnu.org ([208.118.235.43]:52078) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1e7Lte-0005y5-22 for bug-gnu-emacs@gnu.org; Wed, 25 Oct 2017 09:39:02 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1e7Ltd-0006UQ-Le for bug-gnu-emacs@gnu.org; Wed, 25 Oct 2017 09:39:01 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Alan Third Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Wed, 25 Oct 2017 13:39:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 28872 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: Original-Received: via spool by 28872-submit@debbugs.gnu.org id=B28872.150893871024898 (code B ref 28872); Wed, 25 Oct 2017 13:39:01 +0000 Original-Received: (at 28872) by debbugs.gnu.org; 25 Oct 2017 13:38:30 +0000 Original-Received: from localhost ([127.0.0.1]:60759 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1e7Lt8-0006TW-BB for submit@debbugs.gnu.org; Wed, 25 Oct 2017 09:38:30 -0400 Original-Received: from mail-wm0-f44.google.com ([74.125.82.44]:49156) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1e7Lt6-0006TG-Pc for 28872@debbugs.gnu.org; Wed, 25 Oct 2017 09:38:29 -0400 Original-Received: by mail-wm0-f44.google.com with SMTP id b189so1933147wmd.4 for <28872@debbugs.gnu.org>; Wed, 25 Oct 2017 06:38:28 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=googlemail.com; s=20161025; h=sender:date:from:to:cc:subject:message-id:references:mime-version :content-disposition:content-transfer-encoding:in-reply-to :user-agent; bh=Cs8Z6wPEQA6xc6E1yVhPMifYbRLcz6CwsUwb/sr5ZvM=; b=av2UR6lHWqApjoVuOEmmNiJrikb+R5vp85TqSq/jzuYEICcYFMs26j+AaO/zK34++u 253oT77jB64yWKBiE7SuLINmVqKngZvwtfpZx3YD9KACHGdR6PxAtuTRZrDk6zt3BnYp X9c2azQvLL7ziu0o4VikkoltSVmm4N3M6s7qx+W3iCqwoPgou/M8qtI7FH/axJxPtAE+ H3BmrAXRfc/XPo4na15M4SM2MJZi83FJ8zbikAdduUHeKzXMOa20ML2nTmD3rapoIEiN kiwCVf+64Tua/6amgNcN1oc6H5eHNR9GohFy9lULrESAdlxrO9d9iQadIE0C70lJNG4p jZKA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:sender:date:from:to:cc:subject:message-id :references:mime-version:content-disposition :content-transfer-encoding:in-reply-to:user-agent; bh=Cs8Z6wPEQA6xc6E1yVhPMifYbRLcz6CwsUwb/sr5ZvM=; b=nQx2Ge0cH5nX78daTO/3WaHsEPiYO7FfVbgqruPDCNGZC5QS+vjnEbGftt65r6gPkF eBHpFp0y9Rehy62vgn24qgihcvFELO2OpfvrZxOEXzW6NeaVlyUScg8uvA49BPeyVHYQ r6JlC+aeZHshqdqc1sBwsNvLgCSRY5q5uTF70guBFDmvESSgFF7I6OKsaO5afK0hqTh3 kojHI4PHPmbxT8TLHQXIypDUvb1e5haUZhZsq4J5jQCmoQ8muvzdqW9GSAevRcrw31Jz /ENpq1MxRgao8oCr+LjmwB0CBgm6KPqRqD2aNs44EUINoloRmwCcGS5AaGg2iB5onHYC 7HXw== X-Gm-Message-State: AMCzsaWyYv0+IAC4kGk5I8W78s7/o5tI/dtZT2xGt7T+OdTwDWZUVog4 zopXTKZTgvUSw47jMV3AOPw= X-Google-Smtp-Source: ABhQp+QgdkChNCLRvZXeYuviceTj+syyR1BucBkA8TX6qYiBm2PoOYRKsB1ORLbRbACOQ9yytxSnkA== X-Received: by 10.28.67.133 with SMTP id q127mr1983628wma.71.1508938703002; Wed, 25 Oct 2017 06:38:23 -0700 (PDT) Original-Received: from breton.holly.idiocy.org (ip6-2001-08b0-03f8-8129-98d4-f997-58fa-42e9.holly.idiocy.org. [2001:8b0:3f8:8129:98d4:f997:58fa:42e9]) by smtp.gmail.com with ESMTPSA id l80sm2730045wmb.2.2017.10.25.06.38.21 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Wed, 25 Oct 2017 06:38:22 -0700 (PDT) Content-Disposition: inline In-Reply-To: X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 208.118.235.43 X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.org gmane.emacs.bugs:138957 Archived-At: On Fri, Oct 20, 2017 at 07:35:35AM -0400, Aaron Jensen wrote: > On October 19, 2017 at 4:17:13 AM, Alan Third > (alan@idiocy.org(mailto:alan@idiocy.org)) wrote: > > > Non‐native fullscreen uses another NSWindow (like we were discussing > > for undecorated frames), so when it switches back out of fullscreen it > > changes back to the original NSWindow. > > Oh, why is that? I believe that is the time that iTerm2 does not > create a new window. It sets borderless and resizes to full screen. If > that were done instead, would it help with the toolbar issue? Yeah, we could probably do it without creating a new NSWindow for macOS and I think it would be better behaved, but GNUstep doesn’t allow you to change the styleMask at all so it still needs to do the new NSWindow thing. In order to use lisp to do the fullscreen thing we’d need to keep track of various ‘windowed’ frame parameters, ie. undecorated, width, height, origin, maybe others. I assume it would be OK to stick them into the frame-parameters alist under a special key, so we know where they are when we want to switch back. Anyway, I’ve pushed a fix for this particular issue. It does produce another odd bug, though: Set non‐native fullscreen, turn off the toolbar, switch to fullscreen then back to windowed, re‐enable the toolbar and watch a gap appear between the top of the Emacs window and the toolbar. It’s weird, but harder to cause than the current bad behaviour. -- Alan Third