From: Mark Oteiza <mvoteiza@udel.edu>
To: Paul Eggert <eggert@cs.ucla.edu>
Cc: 28921@debbugs.gnu.org
Subject: bug#28921: [PROPOSED] Fix xdg timestamp error on 32-bit Emacs
Date: Sat, 21 Oct 2017 10:26:30 -0400 [thread overview]
Message-ID: <20171021142630.4asr6z7qjfdxonzh@logos.localdomain> (raw)
In-Reply-To: <20171021030455.16035-1-eggert@cs.ucla.edu>
On 20/10/17 at 08:04pm, Paul Eggert wrote:
> * lisp/xdg.el (xdg-thumb-mtime): Return an Emacs timestamp,
> not an integer. This avoids signaling an error on 32-bit
> Emacs, where timestamps typically do not fit into fixnums.
I had the following sitting in my tree, but I don't feel strongly either
way.
diff --git a/lisp/xdg.el b/lisp/xdg.el
index 76106f4258..f57ed5e683 100644
--- a/lisp/xdg.el
+++ b/lisp/xdg.el
@@ -93,8 +93,8 @@ xdg-thumb-name
(concat (md5 (xdg-thumb-uri filename)) ".png"))
(defun xdg-thumb-mtime (filename)
- "Return modification time of FILENAME as integral seconds from the epoch."
- (floor (float-time (nth 5 (file-attributes filename)))))
+ "Return modification time of FILENAME as seconds from the epoch."
+ (ffloor (float-time (nth 5 (file-attributes filename)))))
\f
;; XDG User Directories
prev parent reply other threads:[~2017-10-21 14:26 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-10-21 3:04 bug#28921: [PROPOSED] Fix xdg timestamp error on 32-bit Emacs Paul Eggert
2017-10-21 7:19 ` Eli Zaretskii
2017-10-21 9:11 ` Tino Calancha
2017-10-22 7:41 ` Paul Eggert
2017-10-21 14:26 ` Mark Oteiza [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20171021142630.4asr6z7qjfdxonzh@logos.localdomain \
--to=mvoteiza@udel.edu \
--cc=28921@debbugs.gnu.org \
--cc=eggert@cs.ucla.edu \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this external index
https://git.savannah.gnu.org/cgit/emacs.git
https://git.savannah.gnu.org/cgit/emacs/org-mode.git
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.