From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!.POSTED!not-for-mail From: Mark Oteiza Newsgroups: gmane.emacs.bugs Subject: bug#28809: 26.0.90; Error running timer =?UTF-8?Q?=E2=80=98image-dired-thumb-queue-run=E2=80=99?= Date: Sat, 14 Oct 2017 17:24:59 -0400 Message-ID: <20171014212459.zzzjveby4g32a35i@logos.localdomain> References: <83mv4vjewg.fsf@gnu.org> NNTP-Posting-Host: blaine.gmane.org Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit X-Trace: blaine.gmane.org 1508016374 15928 195.159.176.226 (14 Oct 2017 21:26:14 GMT) X-Complaints-To: usenet@blaine.gmane.org NNTP-Posting-Date: Sat, 14 Oct 2017 21:26:14 +0000 (UTC) User-Agent: NeoMutt/20171006-14-e64a43 Cc: Davor Rotim , 28809@debbugs.gnu.org To: Eli Zaretskii Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Sat Oct 14 23:26:10 2017 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane.org Original-Received: from lists.gnu.org ([208.118.235.17]) by blaine.gmane.org with esmtp (Exim 4.84_2) (envelope-from ) id 1e3Twe-0003BD-D3 for geb-bug-gnu-emacs@m.gmane.org; Sat, 14 Oct 2017 23:26:08 +0200 Original-Received: from localhost ([::1]:55217 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1e3Twk-0008J9-9t for geb-bug-gnu-emacs@m.gmane.org; Sat, 14 Oct 2017 17:26:14 -0400 Original-Received: from eggs.gnu.org ([2001:4830:134:3::10]:54329) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1e3Twd-0008J1-Lz for bug-gnu-emacs@gnu.org; Sat, 14 Oct 2017 17:26:08 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1e3TwY-0008Rp-N2 for bug-gnu-emacs@gnu.org; Sat, 14 Oct 2017 17:26:07 -0400 Original-Received: from debbugs.gnu.org ([208.118.235.43]:60121) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1e3TwY-0008Rg-It for bug-gnu-emacs@gnu.org; Sat, 14 Oct 2017 17:26:02 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1e3TwY-0004TT-CR for bug-gnu-emacs@gnu.org; Sat, 14 Oct 2017 17:26:02 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Mark Oteiza Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Sat, 14 Oct 2017 21:26:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 28809 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: Original-Received: via spool by 28809-submit@debbugs.gnu.org id=B28809.150801630917132 (code B ref 28809); Sat, 14 Oct 2017 21:26:02 +0000 Original-Received: (at 28809) by debbugs.gnu.org; 14 Oct 2017 21:25:09 +0000 Original-Received: from localhost ([127.0.0.1]:40569 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1e3Tvh-0004SG-8y for submit@debbugs.gnu.org; Sat, 14 Oct 2017 17:25:09 -0400 Original-Received: from mail-qt0-f171.google.com ([209.85.216.171]:46368) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1e3Tvf-0004Rq-A4 for 28809@debbugs.gnu.org; Sat, 14 Oct 2017 17:25:07 -0400 Original-Received: by mail-qt0-f171.google.com with SMTP id 1so25384471qtn.3 for <28809@debbugs.gnu.org>; Sat, 14 Oct 2017 14:25:07 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=udel-edu.20150623.gappssmtp.com; s=20150623; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:content-transfer-encoding:in-reply-to :user-agent; bh=N+wyIZOp5Z5gepFJ+DMFiBmydubSjjcn57H2wA1GwuQ=; b=ZASOE/5Iyyt4SINJWJldWYY7RcT8EHwQQG3de4xVxfnAzA+9b936FNJiB39rDB7TQU kUHu3kIOS7xzcu4BuQNR1yNwCxUq9ZkJbMzieyq476PuAKxXgIIRT5Nqe92tqGm+TKb6 tFBVDSAYlHz/jZHuQstKrDR9bN+HC4L5vcYkc8KFF7AZ0qhwvvaH8ZMYoMz4d7Jbpbje w75gfaYZSObLfjDMjRnvzZYYByTzVphGkKXKtUHbTC6M3dqkVnebi0naZcFt9vLnXC71 T88eAHDUMktI1yokgZ8PmV4uG3Oo785y2C4pIpxxtjCchAEJNHseEvojTNiuwBi0h7TA diKA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:content-transfer-encoding :in-reply-to:user-agent; bh=N+wyIZOp5Z5gepFJ+DMFiBmydubSjjcn57H2wA1GwuQ=; b=l0EilibMUO+qdP4JNseSKcTQe+63tUBeoihGN3jOZniW/LEkh9xKLO+ogA5CbIQuuC De2KyySsekzkN2N+boiOZD75n7/bAYjEMTTiiioM1oGT4NP8eU7Ap8JIL+eJaiMIUonW 8ClUom2/SeU54X6c3Z9U4ugFkG2rY2bZUID4pz5C3jtPCqnTfkFYgc4G31AJOWqwC3mh O7JOYGoNJHkC0wNap049zvBCEupe0d8jxGKE+3BE7AbNtJs6/5nZwa+mi7mAfMtnc+sv slezIpbTxNtIqIME7q8FsHQih3oox3y126H+f+yxYz5/lqFdrmgH4oSpYNIBvAkfbfMj a3tw== X-Gm-Message-State: AMCzsaUgDaW1v9Sr5Nr6RlTbivZGR5GuvcdQJMz5iZKx1wyLd1E/djF0 UbVsciwqREL0R1kk6E7P1tpjmw== X-Google-Smtp-Source: ABhQp+SnQScwptlIXgKdVWrqBBfwkOA1OMAdd0l5IQlMSQjrFmF0Ul9ptiAuqE+WhwJDAoxNVqZV3Q== X-Received: by 10.200.47.3 with SMTP id j3mr7911532qta.15.1508016301685; Sat, 14 Oct 2017 14:25:01 -0700 (PDT) Original-Received: from logos.localdomain (pool-173-67-36-61.bltmmd.fios.verizon.net. [173.67.36.61]) by smtp.gmail.com with ESMTPSA id p64sm2385054qkb.47.2017.10.14.14.25.00 (version=TLS1_2 cipher=ECDHE-RSA-CHACHA20-POLY1305 bits=256/256); Sat, 14 Oct 2017 14:25:00 -0700 (PDT) Content-Disposition: inline In-Reply-To: <83mv4vjewg.fsf@gnu.org> X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 208.118.235.43 X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.org gmane.emacs.bugs:138421 Archived-At: On 13/10/17 at 05:33pm, Eli Zaretskii wrote: > > From: Davor Rotim > > Date: Fri, 13 Oct 2017 15:33:24 +0200 > > > > Started with emacs -Q, opened a dired buffer, navigated to an image and pressed C-t . > > on it (image-dired-display-thumb) to generate a thumbnail. That leaves me with only an error message: > > > > Error running timer ‘image-dired-thumb-queue-run’: (range-error "floor" 1505334534.0059688) > > Mark, could you please look at this? You changed the code to use > floor instead of rounding via format "%.0f", but floor returns an > Emacs integer which can overflow on 32-bit hosts for large time > values, as happens here. I think we should use ffloor instead, and if > that produces a decimal point, eliminate it with "%.0f" format. What you propose sounds fine to me.