all messages for Emacs-related lists mirrored at yhetil.org
 help / color / mirror / code / Atom feed
From: Alan Mackenzie <acm@muc.de>
To: Tadeus Prastowo <tadeus.prastowo@unitn.it>
Cc: John Wiegley <jwiegley@gmail.com>, 28623@debbugs.gnu.org
Subject: bug#28623: 27.0.50; lisp/progmodes/cc-engine.el incorrect indentation of C++14 curly-brace initializer list
Date: Wed, 11 Oct 2017 20:32:21 +0000	[thread overview]
Message-ID: <20171011203221.GB7384@ACM> (raw)
In-Reply-To: <CAN-HRFb743gjZS=qwbsDbSMr-J8AkhSYraA90d_MLfyOJso89Q@mail.gmail.com>

Hello, Tadeus.

On Fri, Oct 06, 2017 at 04:59:55 +0200, Tadeus Prastowo wrote:
> On Wed, Oct 4, 2017 at 8:15 PM, Alan Mackenzie <acm@muc.de> wrote:

> Hi Alan!

> [...]

> >> Any better suggestion as to how to fix the problem?

> > Hey, I just love it when people diagnose and fix their own bugs,
> > particularly in some of the more involved bits of CC Mode.  :-)

> To make the maintainer's life easier :-)

> > Just one tiny, tiny, nitpick.  in (looking-at ",\\s *"), isn't the "any
> > amount of space" bit redundant, since we don't use match-end to get the
> > precise position?  In fact, I'm tending towards the simpler (eq
> > (char-after) ?,).

> That is surely better.  Please go with that solution.

> > But, as I say, that's a tiny point in a great piece of debugging.  I
> > will commit this (to the Emacs-26 branch of savannah) soon (from where
> > it will find its way to the master branch due to some public spirited
> > person who arranges these things).

> Thank you very much for your review.

> > Many thanks!

> No problem.  I'm glad to help.

I'm sorry is been a week without any communication from me.  The reason
is I've run into problems with other related cases.  For example, in

1.    auto bad4 = f <3> (
2.                       {3, 4},

L2 needs to be parsed as an arglist-intro and indented as shown.  It's
actually being parsed as a brace-list-open with anchor point on "auto".

What's confusing me is the confusion between a brace list being
recognised by its context (which is what
c-looking-at-or-maybe-in-bracelist mostly does) and by its content.  The
{3, 4} above is a brace list by its content but not by its context.
However, it's being wrongly recognised as a by-context brace list, hence
is being parsed and indented wrongly.

I'm not going to have much time to sort this out over the next week or
two, so please bear with me.  I haven't forgotten about this.

> --
> Best regards,
> Tadeus

-- 
Alan Mackenzie (Nuremberg, Germany).





  reply	other threads:[~2017-10-11 20:32 UTC|newest]

Thread overview: 12+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2017-09-27 17:49 bug#28623: 27.0.50; lisp/progmodes/cc-engine.el incorrect indentation of C++14 curly-brace initializer list Tadeus Prastowo
2017-09-27 19:31 ` John Wiegley
2017-10-04 18:15 ` Alan Mackenzie
2017-10-06  2:59   ` Tadeus Prastowo
2017-10-11 20:32     ` Alan Mackenzie [this message]
2017-10-12 11:38       ` Tadeus Prastowo
2017-11-04 19:56         ` Alan Mackenzie
2017-11-06 22:46           ` Tadeus Prastowo
2017-11-08 19:23             ` Alan Mackenzie
     [not found]             ` <20171108192358.GA4582@ACM>
2017-11-09  9:27               ` Tadeus Prastowo
2017-11-09 18:53                 ` Alan Mackenzie
     [not found]                 ` <20171109185354.GA15085@ACM>
2017-11-10 12:07                   ` Tadeus Prastowo

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20171011203221.GB7384@ACM \
    --to=acm@muc.de \
    --cc=28623@debbugs.gnu.org \
    --cc=jwiegley@gmail.com \
    --cc=tadeus.prastowo@unitn.it \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this external index

	https://git.savannah.gnu.org/cgit/emacs.git
	https://git.savannah.gnu.org/cgit/emacs/org-mode.git

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.