From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!.POSTED!not-for-mail From: Mark Oteiza Newsgroups: gmane.emacs.devel Subject: Re: Flymake refactored Date: Tue, 10 Oct 2017 12:10:22 -0400 Message-ID: <20171010161022.jmmfojjhwm35ygrm@logos.localdomain> References: <87efqh2sud.fsf@udel.edu> <20171006151753.tmdunffovz7olhey@logos.localdomain> <87h8vbx7p3.fsf@gmail.com> <20171007181824.k6pf2ztgxyodmx4a@logos.localdomain> <87376uxb3s.fsf@gmail.com> <20171008125156.q22u2tya5ygfbwja@logos.localdomain> <87mv51w7j0.fsf@gmail.com> <20171010142729.r7mgfmlkk6jvrnt6@logos.localdomain> <87po9v9ghq.fsf@gmail.com> NNTP-Posting-Host: blaine.gmane.org Mime-Version: 1.0 Content-Type: text/plain; charset=iso-8859-1 Content-Transfer-Encoding: 8bit X-Trace: blaine.gmane.org 1507651844 26126 195.159.176.226 (10 Oct 2017 16:10:44 GMT) X-Complaints-To: usenet@blaine.gmane.org NNTP-Posting-Date: Tue, 10 Oct 2017 16:10:44 +0000 (UTC) User-Agent: NeoMutt/20170912-97-b97206-dirty Cc: emacs-devel@gnu.org, Simen =?iso-8859-1?Q?Heggest=F8yl?= , dgutov@yandex.ru, Steve Purcell , sdl.web@gmail.com, monnier@iro.umontreal.ca To: =?iso-8859-1?Q?Jo=E3o_T=E1vora?= Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Tue Oct 10 18:10:39 2017 Return-path: Envelope-to: ged-emacs-devel@m.gmane.org Original-Received: from lists.gnu.org ([208.118.235.17]) by blaine.gmane.org with esmtp (Exim 4.84_2) (envelope-from ) id 1e1x75-0005nm-8A for ged-emacs-devel@m.gmane.org; Tue, 10 Oct 2017 18:10:35 +0200 Original-Received: from localhost ([::1]:35947 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1e1x7C-0004Yi-Dp for ged-emacs-devel@m.gmane.org; Tue, 10 Oct 2017 12:10:42 -0400 Original-Received: from eggs.gnu.org ([2001:4830:134:3::10]:57175) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1e1x73-0004Xe-Bm for emacs-devel@gnu.org; Tue, 10 Oct 2017 12:10:34 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1e1x6x-0008SI-Oh for emacs-devel@gnu.org; Tue, 10 Oct 2017 12:10:33 -0400 Original-Received: from mail-qt0-x230.google.com ([2607:f8b0:400d:c0d::230]:54146) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1e1x6x-0008Rf-J1 for emacs-devel@gnu.org; Tue, 10 Oct 2017 12:10:27 -0400 Original-Received: by mail-qt0-x230.google.com with SMTP id n61so24830594qte.10 for ; Tue, 10 Oct 2017 09:10:27 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=udel-edu.20150623.gappssmtp.com; s=20150623; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:content-transfer-encoding:in-reply-to :user-agent; bh=1aA7cfdrUyVqgNSuvQUBVAZIuE926IQ0X8djfmwT5nI=; b=DHmcaA7cC08H++F01QfiJt7CpvJZvOiz5bHN5bAlJhxTF3mxBsn3WxAdYRe7dPBkD9 6PBUFaYGghk9xRS981mDbgBLFrUwVNTit66Iy3HNLiN0jzBB+3U/1lVCfK8B+nFZbv83 3+EZ9Hz3aQ8Ed4nE9ttS2buT2mWwLBTEBiSbpY+miFKIjjP3+wttAxPT5KKrOdT4ci1I wEHgSW1o9sHc5DNTSDcuqkouMSdhGJlBhNnUp1QQ3SCI9Ui8VJ8FK7yug6cl2plJHap3 WYZWo4SLbMtP4FxXlSazFInxTpHYAXjv79CdloGrFFhSK8y1q87pLeJDl1B0WiKDrZzh 10lQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:content-transfer-encoding :in-reply-to:user-agent; bh=1aA7cfdrUyVqgNSuvQUBVAZIuE926IQ0X8djfmwT5nI=; b=JGTxyn5CC40v69zRC2FghRA5EroourCKJ3Wu3i8aELpRVB99qLlRy19WdlsLBEU8gn U5ahHWHm6aNJI7sdxOKOrv2XLVSnyivFrF+JlaT5qMQ6yDJ4OaInB9Ix/oQwPqjJFLu7 mX2csJ+tABMZjNJkGcOyqaAQresYC12eNpcxz/OJORk+bcxzSDsCAMSjNMZOocbDF5li Fwejqeo4KgmSVq8KiAVJTWHg3RrQP2SLGCBsRd4i5xpCOaJoySNBJyotGN1vdvDfD58P q5BS9UB6UjVSxmrORbpa5Y1UwGDBpJoNztgjnm8ZYqgWwgR4d4ntJ1SR7RuNwaiw4Cpv Zbqg== X-Gm-Message-State: AMCzsaWt+8rcVxNYk5KK00Xl1SLSvMwdySXmgMJIP/3kTU4kjdZXt2zP i4xm+2Nt5ypn1ghyQFHgweuF5g== X-Google-Smtp-Source: AOwi7QDqJl7EYuE1ZrBvmdITStshUbuvwdpl1MoBNcj2nUWXswh4NEjuIKB0DOZZ5aRCAJZkJLlOfQ== X-Received: by 10.55.221.11 with SMTP id n11mr15426748qki.175.1507651825233; Tue, 10 Oct 2017 09:10:25 -0700 (PDT) Original-Received: from logos.localdomain (pool-173-67-36-61.bltmmd.fios.verizon.net. [173.67.36.61]) by smtp.gmail.com with ESMTPSA id k24sm6613565qtk.89.2017.10.10.09.10.22 (version=TLS1_2 cipher=ECDHE-RSA-CHACHA20-POLY1305 bits=256/256); Tue, 10 Oct 2017 09:10:23 -0700 (PDT) Content-Disposition: inline In-Reply-To: <87po9v9ghq.fsf@gmail.com> X-detected-operating-system: by eggs.gnu.org: Genre and OS details not recognized. X-Received-From: 2607:f8b0:400d:c0d::230 X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Original-Sender: "Emacs-devel" Xref: news.gmane.org gmane.emacs.devel:219342 Archived-At: On 10/10/17 at 04:20pm, João Távora wrote: > Mark Oteiza writes: > > > On 09/10/17 at 12:21am, João Távora wrote: > >> Feel free to tweak again and push to the > >> scratch/flymake-diagnostics-buffer branch. > > > > I just added the keymap to the button--did not notice anything else > > wrong with it. > > Remarkably, this breaks the button (at least in my testing) for > mouse-clicks, which is the only reason it is there. Being a button I > think one shouldn't mess with its keymap. > > Rather, this is what is needed unbreak RET on the button (and still keep > mouse-1, mouse-2 and SPC, naturally) Agreed, my mistake.