From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!.POSTED!not-for-mail From: Mark Oteiza Newsgroups: gmane.emacs.devel Subject: Re: Flymake refactored Date: Sat, 7 Oct 2017 14:18:24 -0400 Message-ID: <20171007181824.k6pf2ztgxyodmx4a@logos.localdomain> References: <87h8vmj3tr.fsf@lolita> <1507138648.1972.0@smtp.gmail.com> <874lre2von.fsf@gmail.com> <87mv566yjx.fsf@udel.edu> <87shex276r.fsf@gmail.com> <87efqh2sud.fsf@udel.edu> <20171006151753.tmdunffovz7olhey@logos.localdomain> <87h8vbx7p3.fsf@gmail.com> NNTP-Posting-Host: blaine.gmane.org Mime-Version: 1.0 Content-Type: text/plain; charset=iso-8859-1 Content-Transfer-Encoding: 8bit X-Trace: blaine.gmane.org 1507400324 18148 195.159.176.226 (7 Oct 2017 18:18:44 GMT) X-Complaints-To: usenet@blaine.gmane.org NNTP-Posting-Date: Sat, 7 Oct 2017 18:18:44 +0000 (UTC) User-Agent: NeoMutt/20170912-97-b97206-dirty Cc: emacs-devel@gnu.org, Simen =?iso-8859-1?Q?Heggest=F8yl?= , dgutov@yandex.ru, Steve Purcell , sdl.web@gmail.com, monnier@iro.umontreal.ca To: =?iso-8859-1?Q?Jo=E3o_T=E1vora?= Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Sat Oct 07 20:18:35 2017 Return-path: Envelope-to: ged-emacs-devel@m.gmane.org Original-Received: from lists.gnu.org ([208.118.235.17]) by blaine.gmane.org with esmtp (Exim 4.84_2) (envelope-from ) id 1e0tgH-0003Zn-Uc for ged-emacs-devel@m.gmane.org; Sat, 07 Oct 2017 20:18:34 +0200 Original-Received: from localhost ([::1]:50817 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1e0tgP-00060i-Cn for ged-emacs-devel@m.gmane.org; Sat, 07 Oct 2017 14:18:41 -0400 Original-Received: from eggs.gnu.org ([2001:4830:134:3::10]:60433) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1e0tgG-00060a-EP for emacs-devel@gnu.org; Sat, 07 Oct 2017 14:18:33 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1e0tgC-0006lV-0R for emacs-devel@gnu.org; Sat, 07 Oct 2017 14:18:32 -0400 Original-Received: from mail-qk0-x232.google.com ([2607:f8b0:400d:c09::232]:55335) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1e0tgB-0006l7-QO for emacs-devel@gnu.org; Sat, 07 Oct 2017 14:18:27 -0400 Original-Received: by mail-qk0-x232.google.com with SMTP id x82so10689237qkb.12 for ; Sat, 07 Oct 2017 11:18:27 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=udel-edu.20150623.gappssmtp.com; s=20150623; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:content-transfer-encoding:in-reply-to :user-agent; bh=kNjuNQBYydzs02CfeRRbIOFLpIqv0VeQ2n6smAqWCs8=; b=d0yf1MWD+EfF86mi5co25mzrc6ZcxQFAHWRbRP//sRhgAaVO0QNqaP4TIcrHeeY8bc ch2WhIosZDnbo0w07ipwualNNRUmWhlV+Exiw8YQ2QyYfwjTgELBlA++0zPJPteJA+7h I78xcpRJoYSWi76W4SYB/UShjQuxKQziO6Sbucwkc4Fa/4dT9DsDcVo44/wwBPlo+dYi lUI5wHNP+zDu9gyQN/16BU/V6mcZ4kRa6pnga1hSyJ3VfeQl0Vy9vST3L0C/RZh7u+KD HKSdDM9JjzurFLF3z0xIQ+WtHTY+9fSm26MFyJcgcL7PTh8gSRWB+b2Z3xwoZWpV9w1F sVZg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:content-transfer-encoding :in-reply-to:user-agent; bh=kNjuNQBYydzs02CfeRRbIOFLpIqv0VeQ2n6smAqWCs8=; b=UhwiRtwL7f18aHNh3bnWRl4zdf9Avg/l7toczy5WpzPai+/AtHM7FyFwsiRE7RiONA 0lF1PCHy806cbRsqzCAQ4ssUjFIjV9hVleu36XEScxfZGSx0Ae8hm846pcBcpKGtevjR g+7R9c7/Ik+8uhew8Fs576nCpn4A1BtYpbqcM6A3RkKCJpdFKGEC7KWmLs8S6muOA2oj Z4Al0Ty/Kf43CnaCVE3XUJfVguq+MDyt90sCa3qqui/hyc2RGqqMNDp2tl+ClT2VKgmf D6wolvJL2w5ZAbQenNf86eiREX2QNGMKW3GB9oYEb8x1Wgs4SAjPFggMYuhWh0hO2mXD Yf0w== X-Gm-Message-State: AMCzsaVN265CcVS7kobf8YwjMyAoX6Wf1QaoGkezMNyHOAzgtd40nklA +0zPgvbBD2BqXI8s4P93LWtlkg== X-Google-Smtp-Source: AOwi7QBAJ0ErDiEVP5lfiugGDlHJTG92yEgPDs0/UOaUQXtlLXJrH5GT7fNF/bKDCRDZiMUtcpPvRQ== X-Received: by 10.55.10.18 with SMTP id 18mr3171714qkk.184.1507400306773; Sat, 07 Oct 2017 11:18:26 -0700 (PDT) Original-Received: from logos.localdomain (pool-173-67-36-61.bltmmd.fios.verizon.net. [173.67.36.61]) by smtp.gmail.com with ESMTPSA id n76sm559727qkn.85.2017.10.07.11.18.25 (version=TLS1_2 cipher=ECDHE-RSA-CHACHA20-POLY1305 bits=256/256); Sat, 07 Oct 2017 11:18:25 -0700 (PDT) Content-Disposition: inline In-Reply-To: <87h8vbx7p3.fsf@gmail.com> X-detected-operating-system: by eggs.gnu.org: Genre and OS details not recognized. X-Received-From: 2607:f8b0:400d:c09::232 X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Original-Sender: "Emacs-devel" Xref: news.gmane.org gmane.emacs.devel:219230 Archived-At: On 07/10/17 at 05:07pm, João Távora wrote: > Mark Oteiza writes: > > > Sure, I've been reading flycheck and syntastic (analogous package for > > vim) for reference. > > > > There are some things aside from checkers I think flymake should learn > > from flycheck--may as well list some here: > > [...] > > - popup a special buffer with all the error/warning/info listed > > Please have a look at the scratch/flymake-diagnostics-buffer branch and > tell me what you think (perhaps comparing it to Flycheck's). The command > is flymake-show-diagnostics-buffer. > > It's very naively implemented for now (and seems kinda slow). Looks good, I'd just change from using buttons to having the whole line be usable to navigate to the error. Perhaps the biggest thing is doing like M-x grep and being able to M-g M-{n,p} and follow in the code buffer, but I suspect that ties into the next-error issue. I suspect it's the use of overlays making it slow--I don't think you need overlays at all for this--just store what you need in the tabulated-list id which IIRC gets applied to the whole line as a text property, which you can then use with (tabulated-list-get-id)