From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!.POSTED!not-for-mail From: Mark Oteiza Newsgroups: gmane.emacs.devel Subject: tabulated-list breakage Date: Thu, 5 Oct 2017 10:08:06 -0400 Message-ID: <20171005140806.hf3etzflkjbbt67u@logos.localdomain> NNTP-Posting-Host: blaine.gmane.org Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii X-Trace: blaine.gmane.org 1507213333 17656 195.159.176.226 (5 Oct 2017 14:22:13 GMT) X-Complaints-To: usenet@blaine.gmane.org NNTP-Posting-Date: Thu, 5 Oct 2017 14:22:13 +0000 (UTC) User-Agent: NeoMutt/20170912-58-0c6611-dirty To: emacs-devel@gnu.org Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Thu Oct 05 16:22:09 2017 Return-path: Envelope-to: ged-emacs-devel@m.gmane.org Original-Received: from lists.gnu.org ([208.118.235.17]) by blaine.gmane.org with esmtp (Exim 4.84_2) (envelope-from ) id 1e072H-0003LV-UI for ged-emacs-devel@m.gmane.org; Thu, 05 Oct 2017 16:22:02 +0200 Original-Received: from localhost ([::1]:40088 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1e072P-0008OZ-4f for ged-emacs-devel@m.gmane.org; Thu, 05 Oct 2017 10:22:09 -0400 Original-Received: from eggs.gnu.org ([2001:4830:134:3::10]:58963) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1e06ox-0004vy-KU for emacs-devel@gnu.org; Thu, 05 Oct 2017 10:08:16 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1e06or-0006gV-Ng for emacs-devel@gnu.org; Thu, 05 Oct 2017 10:08:15 -0400 Original-Received: from mail-qk0-x22c.google.com ([2607:f8b0:400d:c09::22c]:55383) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1e06or-0006g9-Hx for emacs-devel@gnu.org; Thu, 05 Oct 2017 10:08:09 -0400 Original-Received: by mail-qk0-x22c.google.com with SMTP id x82so4902181qkb.12 for ; Thu, 05 Oct 2017 07:08:09 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=udel-edu.20150623.gappssmtp.com; s=20150623; h=date:from:to:subject:message-id:mime-version:content-disposition :user-agent; bh=5pp8iPEaIaGoioUj7PkQrnA1cyoZnIAY3q9YtxEMGuc=; b=ftxdLQfQHVR+ke/MRkDV7hqTayAri6wNJgxjDFd+7wwRWTX5vwlDD1QhXHLfJCpVvJ dI8Hlc8RWTD1RJPbvtbLfJRDSMBdppowk9Fza1B96mVKOc5Ps5OQgxA5OdLkLspzFl2B avZKaeJ/hnNuDIL0qhUKSvtyEmVGWPqEsriJvE22Z2G/OoNq+qHxJ/dMCiTA64t3Tj/2 PbAx3SIsRrtGc7hpsl24rPkZ1UzkmZQqtvFYHyyQO2Q5a/p+CD2KOGkxLI+BJDIb/VoB TrNpOiQ3wswINzmMv5dkpSjmA883twPVls9pl9OQlaP0u4vwKidPemJrIwT2IbTAYHT+ j79A== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:subject:message-id:mime-version :content-disposition:user-agent; bh=5pp8iPEaIaGoioUj7PkQrnA1cyoZnIAY3q9YtxEMGuc=; b=D/T2a9N4iu/k9exPRtED0Kty2f/k8Ee6n/LFlUE3ly9SVn/vZZzQV8M/kND2yRLh8G P9hS5Ul1eJaAxyUVFoIUN7Ax2mSj9fw6QgUpi26mvpmpI3GiIrRoew7oY91P8s+hGIfo ryT1nIxW3wvkl+439aOLHA2Ab4cZpj41x4FO0i4K0OiS9HN0ojpLCxOcsJYapaoAkCs7 JVQncdaTRE26uxMZNQXfpLRbRdlQaGgEHRDXFtqDK/UYRo54EfC4n9qF/iVg93ZuZhtn aKMx8J886CLesJiDRdTSdGRNu069T0lgWrCPxXf+ooW7h9T3GQy5suSfZJjv4aMDm2cp ZuiA== X-Gm-Message-State: AMCzsaVZ6+VP4XdDESteKy0U1Lf5CJdgpOVBwnfDnmcgA26p2EGpUvuV SXA2OWjRoGojPl16Dmu7aOrcDtYmLuo= X-Google-Smtp-Source: AOwi7QA03EZDpcoNXEupz/Z4/TMyb2zUWGSllJj1IeIBJ93ike7AQlNtQZUJK/2QAFtk+RlXsc24AA== X-Received: by 10.55.155.79 with SMTP id d76mr15488067qke.288.1507212488637; Thu, 05 Oct 2017 07:08:08 -0700 (PDT) Original-Received: from logos.localdomain (pool-173-67-36-61.bltmmd.fios.verizon.net. [173.67.36.61]) by smtp.gmail.com with ESMTPSA id l188sm11421522qkd.43.2017.10.05.07.08.06 for (version=TLS1_2 cipher=ECDHE-RSA-CHACHA20-POLY1305 bits=256/256); Thu, 05 Oct 2017 07:08:07 -0700 (PDT) Content-Disposition: inline X-detected-operating-system: by eggs.gnu.org: Genre and OS details not recognized. X-Received-From: 2607:f8b0:400d:c09::22c X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Original-Sender: "Emacs-devel" Xref: news.gmane.org gmane.emacs.devel:219122 Archived-At: Hi, Something in the last several commits, 3d8df4d636..c625fb645a, has changed calls to tabulated-list-print-entry. The calling convention was changed in order to account for display-line-numbers, but the added optional INDENT is supposed to be a no-op when line numbers aren't in use, and was correctly null before. However, now the argument is 0 here when line numbers are off and it is breaking things. The following patch demonstrates the issue. diff --git a/lisp/simple.el b/lisp/simple.el index 5ef511ce0a..0685863bd6 100644 --- a/lisp/simple.el +++ b/lisp/simple.el @@ -3911,6 +3911,11 @@ process-menu-mode-map (define-key map [?d] 'process-menu-delete-process) map)) +(defun process-menu-print-entry (id cols) + (tabulated-list-print-entry id cols) + ;; (do other stuff) + ) + (define-derived-mode process-menu-mode tabulated-list-mode "Process Menu" "Major mode for listing the processes called by Emacs." (setq tabulated-list-format [("Process" 15 t) @@ -3921,6 +3926,7 @@ process-menu-mode ("Command" 0 t)]) (make-local-variable 'process-menu-query-only) (setq tabulated-list-sort-key (cons "Process" nil)) + (setq tabulated-list-printer #'process-menu-print-entry) (add-hook 'tabulated-list-revert-hook 'list-processes--refresh nil t)) (defun process-menu-delete-process ()