tabulated-list breakage

tabulated-list breakage

[Mark Oteiza]

Hi,

Something in the last several commits, 3d8df4d636..c625fb645a,
has changed calls to tabulated-list-print-entry.  The calling convention
was changed in order to account for display-line-numbers, but the added
optional INDENT is supposed to be a no-op when line numbers aren't in
use, and was correctly null before.  However, now the argument is 0 here
when line numbers are off and it is breaking things.

The following patch demonstrates the issue.

diff --git a/lisp/simple.el b/lisp/simple.el
index 5ef511ce0a..0685863bd6 100644
--- a/lisp/simple.el
+++ b/lisp/simple.el
@@ -3911,6 +3911,11 @@ process-menu-mode-map
     (define-key map [?d] 'process-menu-delete-process)
     map))
 
+(defun process-menu-print-entry (id cols)
+  (tabulated-list-print-entry id cols)
+  ;; (do other stuff)
+  )
+
 (define-derived-mode process-menu-mode tabulated-list-mode "Process Menu"
   "Major mode for listing the processes called by Emacs."
   (setq tabulated-list-format [("Process" 15 t)
@@ -3921,6 +3926,7 @@ process-menu-mode
 			       ("Command"  0 t)])
   (make-local-variable 'process-menu-query-only)
   (setq tabulated-list-sort-key (cons "Process" nil))
+  (setq tabulated-list-printer #'process-menu-print-entry)
   (add-hook 'tabulated-list-revert-hook 'list-processes--refresh nil t))
 
 (defun process-menu-delete-process ()

Re: tabulated-list breakage

[Eli Zaretskii]

> Date: Thu, 5 Oct 2017 10:08:06 -0400
> From: Mark Oteiza <mvoteiza@udel.edu>
> 
> Something in the last several commits, 3d8df4d636..c625fb645a,
> has changed calls to tabulated-list-print-entry.  The calling convention
> was changed in order to account for display-line-numbers, but the added
> optional INDENT is supposed to be a no-op when line numbers aren't in
> use, and was correctly null before.  However, now the argument is 0 here
> when line numbers are off and it is breaking things.

Sorry, this should be fixed now.

Re: tabulated-list breakage

[Mark Oteiza]

On 05/10/17 at 05:59pm, Eli Zaretskii wrote:
> > Date: Thu, 5 Oct 2017 10:08:06 -0400
> > From: Mark Oteiza <mvoteiza@udel.edu>
> > 
> > Something in the last several commits, 3d8df4d636..c625fb645a,
> > has changed calls to tabulated-list-print-entry.  The calling convention
> > was changed in order to account for display-line-numbers, but the added
> > optional INDENT is supposed to be a no-op when line numbers aren't in
> > use, and was correctly null before.  However, now the argument is 0 here
> > when line numbers are off and it is breaking things.
> 
> Sorry, this should be fixed now.

Thank you!