From: Mark Oteiza <mvoteiza@udel.edu>
To: Paul Eggert <eggert@cs.ucla.edu>
Cc: 22689@debbugs.gnu.org
Subject: bug#22689: [PATCH] Add logcount
Date: Sat, 30 Sep 2017 19:22:33 -0400 [thread overview]
Message-ID: <20170930232233.3dtcrcijapknju45@logos.localdomain> (raw)
In-Reply-To: <484ef24a-8fbe-6e9c-cdb4-ef7c4467ada9@cs.ucla.edu>
On 30/09/17 at 03:48pm, Paul Eggert wrote:
> I looked at this patch after it landed in 'master'. Thanks for contributing it.
>
> A couple of minor improvements. First, the implementation of logcount can
> use the count_one_bits functions already used by Emacs, rather than
> reinventing that wheel; these functions should be just as fast as
> __builtin_popcount etc. when using GCC. Second, logcount should count zero
> bits in negative numbers, for compatibility with Common Lisp. I installed
> the attached two patches to implement these improvements.
Thank you for the improvements--I was not aware of count-one-bits.h but
am pleasantly surprised.
prev parent reply other threads:[~2017-09-30 23:22 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-02-15 23:18 bug#22689: 25.1.50; implement logcount Mark Oteiza
2017-09-29 17:41 ` bug#22689: [PATCH] Add logcount Mark Oteiza
2017-09-30 11:42 ` Eli Zaretskii
2017-09-30 13:16 ` Mark Oteiza
2017-09-30 13:59 ` Eli Zaretskii
2017-09-30 14:55 ` Mark Oteiza
2017-09-30 15:38 ` Eli Zaretskii
2017-09-30 16:03 ` Mark Oteiza
2017-09-30 16:17 ` Eli Zaretskii
2017-09-30 17:07 ` Mark Oteiza
2017-09-30 17:53 ` Eli Zaretskii
2017-09-30 18:18 ` Mark Oteiza
2017-09-30 16:50 ` Benjamin Riefenstahl
2017-09-30 16:59 ` Mark Oteiza
2017-09-30 22:48 ` Paul Eggert
2017-09-30 23:22 ` Mark Oteiza [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20170930232233.3dtcrcijapknju45@logos.localdomain \
--to=mvoteiza@udel.edu \
--cc=22689@debbugs.gnu.org \
--cc=eggert@cs.ucla.edu \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this external index
https://git.savannah.gnu.org/cgit/emacs.git
https://git.savannah.gnu.org/cgit/emacs/org-mode.git
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.