From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!.POSTED!not-for-mail From: Mark Oteiza Newsgroups: gmane.emacs.bugs Subject: bug#22689: [PATCH] Add logcount Date: Sat, 30 Sep 2017 12:03:31 -0400 Message-ID: <20170930160331.ibxxjh626jrlm4ef@logos.localdomain> References: <87h9h9pnof.fsf@udel.edu> <20170929174134.e6uxcr63dtyvd6f4@logos.localdomain> <83mv5c4dl0.fsf@gnu.org> <20170930131636.xe22lbwlea7yqelh@logos.localdomain> <83a81c478s.fsf@gnu.org> <20170930145525.kg2zh3jf5odx6g3s@logos.localdomain> <838tgw42ol.fsf@gnu.org> NNTP-Posting-Host: blaine.gmane.org Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii X-Trace: blaine.gmane.org 1506787452 25052 195.159.176.226 (30 Sep 2017 16:04:12 GMT) X-Complaints-To: usenet@blaine.gmane.org NNTP-Posting-Date: Sat, 30 Sep 2017 16:04:12 +0000 (UTC) User-Agent: NeoMutt/20170912-48-0df7d3-dirty Cc: 22689@debbugs.gnu.org To: Eli Zaretskii Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Sat Sep 30 18:04:07 2017 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane.org Original-Received: from lists.gnu.org ([208.118.235.17]) by blaine.gmane.org with esmtp (Exim 4.84_2) (envelope-from ) id 1dyKFK-0005r0-2E for geb-bug-gnu-emacs@m.gmane.org; Sat, 30 Sep 2017 18:04:06 +0200 Original-Received: from localhost ([::1]:39759 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1dyKFP-0007wV-Pp for geb-bug-gnu-emacs@m.gmane.org; Sat, 30 Sep 2017 12:04:11 -0400 Original-Received: from eggs.gnu.org ([2001:4830:134:3::10]:39993) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1dyKFK-0007wD-Fu for bug-gnu-emacs@gnu.org; Sat, 30 Sep 2017 12:04:07 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1dyKFG-0001X1-GG for bug-gnu-emacs@gnu.org; Sat, 30 Sep 2017 12:04:06 -0400 Original-Received: from debbugs.gnu.org ([208.118.235.43]:60883) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1dyKFG-0001Wh-CV for bug-gnu-emacs@gnu.org; Sat, 30 Sep 2017 12:04:02 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1dyKFF-0007R2-Sb for bug-gnu-emacs@gnu.org; Sat, 30 Sep 2017 12:04:01 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Mark Oteiza Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Sat, 30 Sep 2017 16:04:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 22689 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: Original-Received: via spool by 22689-submit@debbugs.gnu.org id=B22689.150678742128550 (code B ref 22689); Sat, 30 Sep 2017 16:04:01 +0000 Original-Received: (at 22689) by debbugs.gnu.org; 30 Sep 2017 16:03:41 +0000 Original-Received: from localhost ([127.0.0.1]:41331 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1dyKEu-0007QP-QT for submit@debbugs.gnu.org; Sat, 30 Sep 2017 12:03:41 -0400 Original-Received: from mail-qk0-f175.google.com ([209.85.220.175]:51539) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1dyKEs-0007QC-UZ for 22689@debbugs.gnu.org; Sat, 30 Sep 2017 12:03:39 -0400 Original-Received: by mail-qk0-f175.google.com with SMTP id 17so2055517qkq.8 for <22689@debbugs.gnu.org>; Sat, 30 Sep 2017 09:03:38 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=udel-edu.20150623.gappssmtp.com; s=20150623; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to:user-agent; bh=6kbixxeCXss0Zx2vai/4kALdlMpboNYO2/AZV36YA+Y=; b=eQyknp30+ySmXYDmzs93TU/J7POb/wIJvNHymf+s3cN/NO9n/GHzHmKAMcJbJsrnrX CzLGXlN5pZ2whl1T8MJsO7CRWPNaFvX1MAPFml+hm1T9hCS4kTK5J6slI2IUeqh9prVN HsO2AjteMC6Us/gnDngd9iwONtJGICS0C+sPKS9z39fD78FMYCUbXgFHlAFSCgHHcuqL EowEZJsSO+f6AtqDaYCeeLaKGB9cytNy+lriVP49V8hCXpIza33qIts+lS/0mkyDW9YR FclXRZhndXgSz8uIHqep1z4oUmO+liNfMGax/5n2mBfYNJd26wpt3CO+ZlWPdvRfK/H3 K+uw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to:user-agent; bh=6kbixxeCXss0Zx2vai/4kALdlMpboNYO2/AZV36YA+Y=; b=H2noj7PgxGJ312OGl8uUCk+20w9QRqN+2h7rPpA9JDklrnc8ztxHkn1St6EoP+BUNt jxskV2zb9F4INDnJzUMBmSscB0/1M8uTBNzAVn/KGHQBaoFe0izP/YmNNGr6JiBdUeLu ThE9oUJw+CyorZTO9tyuruwtSbGFt4r3X4gBL23p35y4IA0gXoV288bv+ZUuwQ3Va3q1 6K8Q4v3nP42MfiSi2Y4iyYl/l+Zm/HkBD+/V+vhVwx26pS/e8oEEEo9KGi3Wjn1iw9Pz xKdLzn3UmN37So483ma8bq2fL+J/+KpUziuBSeiIkZC/PZxFebzD2m9BNprosS+jQxKX U+og== X-Gm-Message-State: AMCzsaVa6Taqb1CuGrkEdrHZa8rPECNBQxFLY5L5RxJj6xJVdBTsafij /v3AFn8fL+HSb2/fiKaV3PHK6Xryh5g= X-Google-Smtp-Source: AOwi7QAELOJcc+SAH8xkaIoSDhyzGXv/2PRvKGyfLhvxVf9cmlZpUP+4HMtl9tjd/5/K93mlTwxB0A== X-Received: by 10.233.221.3 with SMTP id r3mr7937152qkf.219.1506787413316; Sat, 30 Sep 2017 09:03:33 -0700 (PDT) Original-Received: from logos.localdomain (pool-173-67-36-61.bltmmd.fios.verizon.net. [173.67.36.61]) by smtp.gmail.com with ESMTPSA id t184sm4197263qkc.74.2017.09.30.09.03.32 (version=TLS1_2 cipher=ECDHE-RSA-CHACHA20-POLY1305 bits=256/256); Sat, 30 Sep 2017 09:03:32 -0700 (PDT) Content-Disposition: inline In-Reply-To: <838tgw42ol.fsf@gnu.org> X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 208.118.235.43 X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.org gmane.emacs.bugs:137691 Archived-At: On 30/09/17 at 06:38pm, Eli Zaretskii wrote: > > Date: Sat, 30 Sep 2017 10:55:25 -0400 > > From: Mark Oteiza > > Cc: 22689@debbugs.gnu.org > > > > > Btw, on Windows, a long is a 32-bit type, so I think we need > > > to check against ULONG_LONG_MAX as well. > > > > I tried implementing your comments (and added a test). I don't know > > what to do in the #else for ULONG_LONG_MAX. > > Same as you do for ULONG_MAX, I think. so the following? else if (v <= ULONG_MAX || v <= ULONG_LONG_MAX) XSETINT (res, logcount64 (v));