Re: [Emacs-diffs] master 551594e: Add indent spec to easy-mmode macros

Re: [Emacs-diffs] master 551594e: Add indent spec to easy-mmode macros

[Stefan Monnier]

>     Add indent spec to easy-mmode macros
>     Ideally these macros should expand to the proper code instead of
>     relegating all the work to a function call.

Not sure why this comment is in the commit message, but FWIW, I tend to
disagree: it's usually preferable to keep the macro part to a minimum
(handling the syntax), and to keep as much as possible in functions.

There's no hard&fast rule, tho.


        Stefan

Re: [Emacs-diffs] master 551594e: Add indent spec to easy-mmode macros

[Mark Oteiza]

On 28/09/17 at 08:38am, Stefan Monnier wrote:
> >     Ideally these macros should expand to the proper code instead of
> >     relegating all the work to a function call.
> 
> FWIW, I tend to
> disagree: it's usually preferable to keep the macro part to a minimum
> (handling the syntax), and to keep as much as possible in functions.

I see, thanks.  I tend towards macros that expand to efficient code and
eliminate runtime dependencies; however, like all things it's a trade
off, be it code size, macroexpansion speed, etc.

Re: [Emacs-diffs] master 551594e: Add indent spec to easy-mmode macros

[Stefan Monnier]

> I see, thanks.  I tend towards macros that expand to efficient code and
> eliminate runtime dependencies; however, like all things it's a trade
> off, be it code size, macroexpansion speed, etc.

Part of the issue for me is to hardcode a particular behavior.
Going through a function makes it much easier to change the behavior
after the file has been compiled.


        Stefan