From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!.POSTED!not-for-mail From: Alan Third Newsgroups: gmane.emacs.bugs Subject: bug#28571: 25.3; Compile error on macOS Sierra Date: Sun, 24 Sep 2017 13:09:25 +0100 Message-ID: <20170924120925.GC30865@breton.holly.idiocy.org> References: <20170923193130.GB6576@breton.holly.idiocy.org> <20170924110658.GA30865@breton.holly.idiocy.org> NNTP-Posting-Host: blaine.gmane.org Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit X-Trace: blaine.gmane.org 1506255013 5832 195.159.176.226 (24 Sep 2017 12:10:13 GMT) X-Complaints-To: usenet@blaine.gmane.org NNTP-Posting-Date: Sun, 24 Sep 2017 12:10:13 +0000 (UTC) User-Agent: Mutt/1.9.0 (2017-09-02) Cc: 28571@debbugs.gnu.org To: Philipp Stephani Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Sun Sep 24 14:10:07 2017 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane.org Original-Received: from lists.gnu.org ([208.118.235.17]) by blaine.gmane.org with esmtp (Exim 4.84_2) (envelope-from ) id 1dw5ja-0000sh-RA for geb-bug-gnu-emacs@m.gmane.org; Sun, 24 Sep 2017 14:10:07 +0200 Original-Received: from localhost ([::1]:37952 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1dw5je-0007lF-Ud for geb-bug-gnu-emacs@m.gmane.org; Sun, 24 Sep 2017 08:10:10 -0400 Original-Received: from eggs.gnu.org ([2001:4830:134:3::10]:35920) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1dw5jZ-0007l6-JM for bug-gnu-emacs@gnu.org; Sun, 24 Sep 2017 08:10:06 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1dw5jW-0001DD-Ck for bug-gnu-emacs@gnu.org; Sun, 24 Sep 2017 08:10:05 -0400 Original-Received: from debbugs.gnu.org ([208.118.235.43]:46596) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1dw5jW-0001D3-7w for bug-gnu-emacs@gnu.org; Sun, 24 Sep 2017 08:10:02 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1dw5jV-0007mj-VB for bug-gnu-emacs@gnu.org; Sun, 24 Sep 2017 08:10:01 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Alan Third Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Sun, 24 Sep 2017 12:10:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 28571 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: Original-Received: via spool by 28571-submit@debbugs.gnu.org id=B28571.150625498429897 (code B ref 28571); Sun, 24 Sep 2017 12:10:01 +0000 Original-Received: (at 28571) by debbugs.gnu.org; 24 Sep 2017 12:09:44 +0000 Original-Received: from localhost ([127.0.0.1]:55277 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1dw5j9-0007m5-TV for submit@debbugs.gnu.org; Sun, 24 Sep 2017 08:09:44 -0400 Original-Received: from mail-wm0-f42.google.com ([74.125.82.42]:48942) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1dw5j3-0007lo-Bp for 28571@debbugs.gnu.org; Sun, 24 Sep 2017 08:09:37 -0400 Original-Received: by mail-wm0-f42.google.com with SMTP id m127so12929343wmm.3 for <28571@debbugs.gnu.org>; Sun, 24 Sep 2017 05:09:33 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=googlemail.com; s=20161025; h=sender:date:from:to:cc:subject:message-id:references:mime-version :content-disposition:content-transfer-encoding:in-reply-to :user-agent; bh=oTCm3aOr60QhDG6/aH+dQpxYrJxfAO5CetJHnme8F5Q=; b=N9JgkJgWOKcWsT2WJAVQ7q5hkpYZHOf3vneIpD5eZFfMJhmCFbZ1mHhRMWlzw4QeLi ykNSMUMGkiIQ62V0FskOXqbZt3C/kFheA4x8Y6qsKOZ8CMFgXemGGE2rUQc0+e2seuYL ol+CSmlY79nUd+30mki8Vahd+mk3T2ipt7qOkCbio2KwbiTRBWPh3mWd2sCsuDTuBVcs HM/8bHFZwDP/eiOuGqiLj2tf0Z2TgG6D0K/uzNjcuJ6txzfWTDnQODOjZe/2lnX/OCFq B8VayQRFKoTHoDPj/Qlr8oaYoOjBwPEq6BMY8LYzZ8Srb/Ep1xtDR/xH8+twZbq0Ao0E xYFw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:sender:date:from:to:cc:subject:message-id :references:mime-version:content-disposition :content-transfer-encoding:in-reply-to:user-agent; bh=oTCm3aOr60QhDG6/aH+dQpxYrJxfAO5CetJHnme8F5Q=; b=bUMQPgwUBlpRDNYq5eW932MwxWOnGb0aQegtjfVZie1kw4yqLrHcufM8W8EOMhJ3YB 8Sfu40o2TlReaGtZnbbtLgKRgVJC0iS3C3/EHc6wvEtS2R2VxAFLiYTTbHChyCf6e6kw CJ0uAJ+XQnbVmxQNMEt+i7kcnJb0MWiuUHg5pczE1PrSOuLVqKR/VStrqDPKpPx+S7bA ozuPPdZJYx5lwUwdxDhbYGgMTOefjwYibszcCq+p/dxUubPsUgMEVfxNNEdpjsA7uujV E4utuVYyfWIUQxOcazfvDbzURAreTP4//D/E9QwLhItdJbMbWp4SjmgNsgg2NE6Av9Kp M1sw== X-Gm-Message-State: AHPjjUjR/BqRDYhQLpLWO6mDV0qYZlcjdQTy7HwMynhVJhjTC9mrsBMM PjLSqbPT15z6o1/CA1dEIe4= X-Google-Smtp-Source: AOwi7QBxkOAhD9Xs8Rk2lmnr+M0b1NyJw6WglL+uUjF1IzCO+5sCpRZF2FEudKqgNMD7keTrrWeNgw== X-Received: by 10.28.218.146 with SMTP id r140mr7212117wmg.14.1506254967696; Sun, 24 Sep 2017 05:09:27 -0700 (PDT) Original-Received: from breton.holly.idiocy.org (ip6-2001-08b0-03f8-8129-b188-2706-1206-0eea.holly.idiocy.org. [2001:8b0:3f8:8129:b188:2706:1206:eea]) by smtp.gmail.com with ESMTPSA id p78sm4421058wma.11.2017.09.24.05.09.26 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Sun, 24 Sep 2017 05:09:27 -0700 (PDT) Content-Disposition: inline In-Reply-To: X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 208.118.235.43 X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.org gmane.emacs.bugs:137334 Archived-At: On Sun, Sep 24, 2017 at 11:23:47AM +0000, Philipp Stephani wrote: > Alan Third schrieb am So., 24. Sep. 2017 um 13:07 Uhr: > > > On Sun, Sep 24, 2017 at 07:49:55AM +0000, Philipp Stephani wrote: > > > So I think the functions are there, but the compilation > > > shouldn't use them since they would make the binary incompatible > > > with old versions of macOS. > > > > I agree. I’ve attached a patch that should sort it. > > > > Thanks, the patch works, but you also need to #undef HAVE_UTIMENSAT. > However, I'm wondering whether that's the right way to solve it. It > means we're making some of the checks manual that have previously > been automated, which implies that we need to recheck in the future > whether the checks are still appropriate etc. Wouldn't it be better > to modify configure.ac so that it doesn't detect these functions as > present in the first place if we don't want to use them? I can’t alter the checks directly as they’re part of gnulib (I think). We’d have to suppress them. But that would be done by putting in a simple check, ‘is this macOS? If yes, don’t use these functions’, which is, IMO, no different than what the patch does. We could get the gnulib people to fix them, but even then we’d still want to just suppress them as we don’t want to use these functions on macOS even if they are available due to cross‐version concerns. If you just think the logic should be in configure.ac rather than conf_post.h, then I think we might need to get help with how to suppress or ignore the checks. Unless you know how. -- Alan Third