From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!.POSTED!not-for-mail From: Alan Third Newsgroups: gmane.emacs.bugs Subject: bug#28512: 26.0.60; undecorated frames on macOS 10.13 do not resize properly Date: Sat, 23 Sep 2017 20:11:44 +0100 Message-ID: <20170923191144.GA6576@breton.holly.idiocy.org> References: <20170919213413.GA2032@breton.holly.idiocy.org> NNTP-Posting-Host: blaine.gmane.org Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit X-Trace: blaine.gmane.org 1506193934 32094 195.159.176.226 (23 Sep 2017 19:12:14 GMT) X-Complaints-To: usenet@blaine.gmane.org NNTP-Posting-Date: Sat, 23 Sep 2017 19:12:14 +0000 (UTC) User-Agent: Mutt/1.9.0 (2017-09-02) Cc: 28512@debbugs.gnu.org To: Aaron Jensen Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Sat Sep 23 21:12:08 2017 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane.org Original-Received: from lists.gnu.org ([208.118.235.17]) by blaine.gmane.org with esmtp (Exim 4.84_2) (envelope-from ) id 1dvpqQ-0007ki-KK for geb-bug-gnu-emacs@m.gmane.org; Sat, 23 Sep 2017 21:12:06 +0200 Original-Received: from localhost ([::1]:35846 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1dvpqW-00062l-D9 for geb-bug-gnu-emacs@m.gmane.org; Sat, 23 Sep 2017 15:12:12 -0400 Original-Received: from eggs.gnu.org ([2001:4830:134:3::10]:37689) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1dvpqQ-00062f-Mx for bug-gnu-emacs@gnu.org; Sat, 23 Sep 2017 15:12:07 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1dvpqN-000746-64 for bug-gnu-emacs@gnu.org; Sat, 23 Sep 2017 15:12:06 -0400 Original-Received: from debbugs.gnu.org ([208.118.235.43]:46229) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1dvpqM-00073l-Tb for bug-gnu-emacs@gnu.org; Sat, 23 Sep 2017 15:12:02 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1dvpqM-00057L-9g for bug-gnu-emacs@gnu.org; Sat, 23 Sep 2017 15:12:02 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Alan Third Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Sat, 23 Sep 2017 19:12:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 28512 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: Original-Received: via spool by 28512-submit@debbugs.gnu.org id=B28512.150619391519656 (code B ref 28512); Sat, 23 Sep 2017 19:12:02 +0000 Original-Received: (at 28512) by debbugs.gnu.org; 23 Sep 2017 19:11:55 +0000 Original-Received: from localhost ([127.0.0.1]:54910 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1dvpqF-00056y-AZ for submit@debbugs.gnu.org; Sat, 23 Sep 2017 15:11:55 -0400 Original-Received: from mail-wr0-f178.google.com ([209.85.128.178]:48638) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1dvpqD-00056h-GN for 28512@debbugs.gnu.org; Sat, 23 Sep 2017 15:11:53 -0400 Original-Received: by mail-wr0-f178.google.com with SMTP id 108so2857314wra.5 for <28512@debbugs.gnu.org>; Sat, 23 Sep 2017 12:11:53 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=googlemail.com; s=20161025; h=sender:date:from:to:cc:subject:message-id:references:mime-version :content-disposition:content-transfer-encoding:in-reply-to :user-agent; bh=aoSUQLiLR49a77Y1yjS8axrBzL1EXbP2MQkRkDpagk4=; b=dnPoZuwIQ0tcKcCR0kcRiNiQDR/EKTYc0OZkN0kAS+kUuhSkZjxfx113Q/TNXkc3gN 8zeH7DPX8NAt6qRP7zZeY4U98L2kDkjZZtQ+cNzrZA0jxhIbIcNWYFcM4wgHM35c1sZZ DCY5bt84DTZXktIchpq18VVKqiu/ZIN0qosYuAzTfWZEgnbYGN2BvVvb2MYrfaMhUJ+b JUROHocIcZ+/9zxezqSHVDNhOTpMM1Lr4LfibUV7hDBf28ioJwOFlEGtzET1yIsfbKrN ocAUcHSJ/8+nFTf4r4UFD8mO6KvmHc/V7ZpF8RJUtQ21LJuKmUxe1oiQFKbqtLDj75co fnMA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:sender:date:from:to:cc:subject:message-id :references:mime-version:content-disposition :content-transfer-encoding:in-reply-to:user-agent; bh=aoSUQLiLR49a77Y1yjS8axrBzL1EXbP2MQkRkDpagk4=; b=QbkDF6tZxXsgwAGiJqD5yweJQ+JLbvgAZsLr6zGXf65Tdx19JaWf8zAi/0PnH/RSDx u4ERWfd1GBFTKbu9zahAA7pptTXmtGrMtTJD53Ti6D4dPbKzftXvTOE4t5cAK1hpn6oJ HnaD50fkbqhQwKKvjSW3t+GR0GdGzPfQQBnR6sT/uOSEEgO2ZYqLPZDUO1Dyje9+A4ra fG7htADa9S8t6jGNNS5J98En7pkZiujxv5gr4v7V7mdtm44GxLlZGP27w3EaenbIg09M ekus66W+RPmEL53A3HBZKohSrby1pGqygs3QsVF59TWEBQJLolUL1fXfl5nMnvvIZdll 8fXQ== X-Gm-Message-State: AHPjjUgZZNv647r2MWx1ByCRyjnJDRAe9WyjmpQgN5T8QFVAsXQHhKQm Ofxe8Mnn6tT8qQAmCRLhuGQ= X-Google-Smtp-Source: AOwi7QAUEGv8ZK6D2AI69gBPAkYA3YqK65Lki0gu/fdIxPpL9hwMi1hrPsTXekO7zS4PedFkeq8ing== X-Received: by 10.223.133.65 with SMTP id 59mr2383939wrh.233.1506193907846; Sat, 23 Sep 2017 12:11:47 -0700 (PDT) Original-Received: from breton.holly.idiocy.org (ip6-2001-08b0-03f8-8129-b188-2706-1206-0eea.holly.idiocy.org. [2001:8b0:3f8:8129:b188:2706:1206:eea]) by smtp.gmail.com with ESMTPSA id q19sm3222811wrb.17.2017.09.23.12.11.46 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Sat, 23 Sep 2017 12:11:46 -0700 (PDT) Content-Disposition: inline In-Reply-To: X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 208.118.235.43 X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.org gmane.emacs.bugs:137314 Archived-At: On Sat, Sep 23, 2017 at 07:31:50AM -0700, Aaron Jensen wrote: > On Tue, Sep 19, 2017 at 2:44 PM, Aaron Jensen wrote: > > If you can reproduce on 10.12, it may be a recent regression > > because I hadn’t ever noticed it and I’ve been using it on 10.12 > > for a month or two now at least. I’ve fixed it, and I doubt it’s a regression because I can’t see how it could have ever worked. When creating a frame, sometimes the toolbar takes a while to draw and we have to wait for it before we can do things like resize windows (or else we get an annoying series of window resizes). (It’s just occurred to me, while typing this out, that the whole way we’re handling this is just broken. It should probably be completely redone.) Undecorated frames, like fullscreen windows, don’t have toolbars, so the code always sees it as zero size and therefore never stops waiting for it to draw. This means it will never resize. Of course, the actual NSWindow *does* resize, it’s just Emacs that doesn’t. This is clearly broken. I’ve added a check for whether the window is undecorated, the same as we check if it’s fullscreen. > Also, there looks like there was an issue with creating a new > undecorated frame, it was not resizable but should be: Although this maybe isn’t actually a bug (and undecorated windows being resizable is), I’ve made it consistent by doing what you suggest. > Also, I'm getting occasional build failures on my 10.12 machine on > emacs-26. Any idea what would cause this: > > ./Contents/PkgInfo: Can't create 'Contents/PkgInfo' > > ./Contents/Resources/Credits.html: Can't create > 'Contents/Resources/Credits.html' > > ./Contents/Resources/Emacs.icns: Can't create 'Contents/Resources/Emacs.icns' > > ./Contents/Resources/English.lproj/InfoPlist.strings: Can't create > 'Contents/Resources/English.lproj/InfoPlist.strings' Is it a permissions issue on your Emacs.app directory? -- Alan Third