From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!.POSTED!not-for-mail From: Mark Oteiza Newsgroups: gmane.emacs.devel Subject: Re: Emacs 26.1 release branch created Date: Fri, 22 Sep 2017 16:05:03 -0400 Message-ID: <20170922200503.u6ipjtezrsoth4xx@logos.localdomain> References: <83377mls4d.fsf@gnu.org> <87bmmazt77.fsf@udel.edu> <83zi9ukbj3.fsf@gnu.org> <20170916145112.GA22458@holos.localdomain> <83wp4yk7ve.fsf@gnu.org> <20170922165941.sirfk6qzfvdfw4i2@logos.localdomain> <83zi9mbj2g.fsf@gnu.org> NNTP-Posting-Host: blaine.gmane.org Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii X-Trace: blaine.gmane.org 1506110718 8944 195.159.176.226 (22 Sep 2017 20:05:18 GMT) X-Complaints-To: usenet@blaine.gmane.org NNTP-Posting-Date: Fri, 22 Sep 2017 20:05:18 +0000 (UTC) User-Agent: NeoMutt/20170912-13-728bb5 Cc: emacs-devel@gnu.org To: Eli Zaretskii Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Fri Sep 22 22:05:13 2017 Return-path: Envelope-to: ged-emacs-devel@m.gmane.org Original-Received: from lists.gnu.org ([208.118.235.17]) by blaine.gmane.org with esmtp (Exim 4.84_2) (envelope-from ) id 1dvUCF-0001nM-VX for ged-emacs-devel@m.gmane.org; Fri, 22 Sep 2017 22:05:12 +0200 Original-Received: from localhost ([::1]:60823 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1dvUCK-0000wg-9o for ged-emacs-devel@m.gmane.org; Fri, 22 Sep 2017 16:05:16 -0400 Original-Received: from eggs.gnu.org ([2001:4830:134:3::10]:58609) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1dvUCD-0000um-IE for emacs-devel@gnu.org; Fri, 22 Sep 2017 16:05:10 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1dvUC9-0001Lp-ER for emacs-devel@gnu.org; Fri, 22 Sep 2017 16:05:09 -0400 Original-Received: from mail-qk0-x229.google.com ([2607:f8b0:400d:c09::229]:43083) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1dvUC9-0001LV-73 for emacs-devel@gnu.org; Fri, 22 Sep 2017 16:05:05 -0400 Original-Received: by mail-qk0-x229.google.com with SMTP id j5so2106226qkd.0 for ; Fri, 22 Sep 2017 13:05:05 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=udel-edu.20150623.gappssmtp.com; s=20150623; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to:user-agent; bh=kBWeWLIaCekOugT9phIo72jWd3ARJuK4B84PjQbSFPo=; b=1ADbkdBiPTUPNtPhwgFRxF4Ssxs9Hx5cQFvUJFbTDUUoBC31Mds7yLygmyuYIqR5JW jaQwk3JH0apOOjKibynnuyXFxUuzOu7WZbCKXGTnGQ7lyumhNza5xT8R/cv3xR78NWI+ UMWk1gt9dli3h9KBOY1zZiNUxKqWZBgu1mCYL6aF9zqtRWruDyihF/XKl3MS9XddI+mM 67wGhIFRri97S0dhhKK+zZfcVs9MxFSqNXZKXcl12AlgHRDZGr3GX3tUFIXhCMsUWlml 02qkkdvo24hAgIjrEE+rcHcXvbS2HSIc/VyAUP+NodVfzvoOmdvptTuDci4NeiXtAgVG W1Vw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to:user-agent; bh=kBWeWLIaCekOugT9phIo72jWd3ARJuK4B84PjQbSFPo=; b=bhUFyWua21cZuwjtTGEZd09x2MrUUbWZzc6mD5iQ5gjOcrYHXPTIOj0zi6Ml4x6LOQ FEUKNnAKmnrC7gNyj1qOR0GFF20v3ijS51mQ2wu6AczV5XE4ijZhIE1LvJf5VwJUNQaa NI7jDgizaR86ioqHIFNo/7oCyMzwix+pJ1l19wvw1Z9eyPU7GYrppPNsNqcJ7Ckc3sDG R3Dc7+rboxPJhDX7vUqmyZOtZDmMlrhf2g8adKa9jbkH2f3f76T6fQYrPmWxcpSjPb1l vCihSCQMzCff/3fm+uifVrslaiwlhAiGK1WWM7iR4pc5GpbD3/nerx7JJh6WBXWBkILY nfBA== X-Gm-Message-State: AHPjjUh5D8pwYjJa6Hdmr7fk/YwQkQ+2VOJSdgIWzTyOVNB6JZvBdWXJ jwdt/RM4IRVzM6/EDh3Qu/vONnrPoIk= X-Google-Smtp-Source: AOwi7QDAJiIkwkkyvUATricESXhqzQe5Ti8p0EVeVDkoWqxS1CKdVvCYg9tGD7qgSasEjvveSETN0A== X-Received: by 10.55.215.205 with SMTP id t74mr413310qkt.327.1506110704457; Fri, 22 Sep 2017 13:05:04 -0700 (PDT) Original-Received: from logos.localdomain (pool-173-67-36-61.bltmmd.fios.verizon.net. [173.67.36.61]) by smtp.gmail.com with ESMTPSA id j19sm495128qtc.41.2017.09.22.13.05.03 (version=TLS1_2 cipher=ECDHE-RSA-CHACHA20-POLY1305 bits=256/256); Fri, 22 Sep 2017 13:05:03 -0700 (PDT) Content-Disposition: inline In-Reply-To: <83zi9mbj2g.fsf@gnu.org> X-detected-operating-system: by eggs.gnu.org: Genre and OS details not recognized. X-Received-From: 2607:f8b0:400d:c09::229 X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Original-Sender: "Emacs-devel" Xref: news.gmane.org gmane.emacs.devel:218707 Archived-At: On 22/09/17 at 07:59pm, Eli Zaretskii wrote: > > Date: Fri, 22 Sep 2017 12:59:41 -0400 > > From: Mark Oteiza > > Cc: emacs-devel@gnu.org > > > > I ended up going back on what I said in d24ec5854 after thinking about what > > I wanted to add, how the API should look, and going through some iterations > > adding those functions. I think I'll leave it at those three functions for > > emacs-26. > > > > In the interest of reducing the amount of (duplicated) code, especially as more > > Lisp functions are added, I propose the following. I followed from your code > > and from how it's done in xml.c, not sure if you have a particular reason for > > doing it one way or the other. > > Hmm... I'm probably missing something, because I don't understand the > rationale and the intent of your changes. You introduce a static > function lcms2_available_p that is not used anywhere else in the file? Oops, all the instances of replacing #ifdef'd code with init_lcms_functions were meant to instead be calling lcms_available_p. Hopefully that makes the intent clear. > And you removed lcms2-available-p without which Lisp code cannot know > at run time whether lcms2 support is available or not? Where does > this lead? I don't think having it in Lisp is necessary--isn't it essentially the same as (featurep 'lcms2)?