all messages for Emacs-related lists mirrored at yhetil.org
 help / color / mirror / code / Atom feed
From: Alan Third <alan@idiocy.org>
To: "Charles A. Roelli" <charles@aurox.ch>
Cc: homeros.misasa@gmail.com, emacs-devel@gnu.org
Subject: Re: Smoother macOS touchpad scrolling
Date: Tue, 19 Sep 2017 20:12:03 +0100	[thread overview]
Message-ID: <20170919191203.GA50068@breton.holly.idiocy.org> (raw)
In-Reply-To: <m2fubjn4j1.fsf@aurox.ch>

On Mon, Sep 18, 2017 at 10:19:30PM +0200, Charles A. Roelli wrote:
> Yes, it returns nil.  I think this check (or maybe a function that
> returns the appkit version as an integer) could be added to ns-win.el.

I’m leaving it as an inline check at the moment as we only have a
single use of it just now. If you’re aware of other places it could be
useful, please let me know.

> > (let ((appkit-version (progn
> >                         (string-match "^appkit-\\([^\s-]*\\)" ns-version-string)
> >                         (match-string 1 ns-version-string))))
> >   (when (and (featurep 'cocoa) (>= (string-to-number appkit-version) 1138))
> >     (setq mouse-wheel-scroll-amount '(1 ((shift) . 5) ((control))))
> >     (put 'mouse-wheel-scroll-amount 'customized-value
> >          (list (custom-quote (symbol-value 'mouse-wheel-scroll-amount))))
> >     
> >     (setq mouse-wheel-progressive-speed nil)
> >     (put 'mouse-wheel-progressive-speed 'customized-value
> >          (list (custom-quote (symbol-value 'mouse-wheel-progressive-speed))))))

I’ve pushed (roughly) this to Emacs 26. See below.

> We could also make the defcustoms in mwheel.el look something like
> this:
> 
> (defcustom mouse-wheel-scroll-amount
>   (cond
>    ((and (featurep 'cocoa) (>= (ns-appkit-version) 1138))
>      '(1 ((shift) . 5) ((control) . nil)))
>    (t '(5 ((shift) . 1) ((control) . nil)))) ...
> 
> instead of:
> 
> (defcustom mouse-wheel-scroll-amount '(5 ((shift) . 1) ((control) . nil)) ...
> 
> Then in ns-win.el we could do:
> 
> (custom-reevaluate-setting 'mouse-wheel-scroll-amount)

I tried this but it just set mouse-wheel-scroll-amount to nil. It
seems that custom-reevaluate-setting uses the :set function, which is
already in use for mouse-wheel-scroll-amount.

Since I want this in Emacs 26 I figured it’s better to go with an ugly
method that works for now, and figure out a neater solution later.

>      Then it sets the user option to that value (using the option’s
>      ‘:set’ property if that is defined).
        ^^^^

> I /think/ this is the right thing to do, but if any Customize experts
> can weigh in, that would be great.

Please do.
-- 
Alan Third



      reply	other threads:[~2017-09-19 19:12 UTC|newest]

Thread overview: 17+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2017-09-08 18:46 Smoother macOS touchpad scrolling Alan Third
2017-09-08 22:21 ` Tak Kunihiro
2017-09-09  8:18   ` Alan Third
2017-09-10  1:20     ` Tak Kunihiro
2017-09-10  8:37       ` Alan Third
2017-09-11 18:09         ` Alan Third
2017-09-12  1:54           ` James Nguyen
2017-09-12 17:03             ` Alan Third
2017-09-12 23:13           ` Tak Kunihiro
2017-09-13 16:26             ` Better macOS scrolling (was: Smoother macOS touchpad scrolling) Alan Third
2017-09-13 22:52               ` Better macOS scrolling Tak Kunihiro
2017-09-16 22:33         ` Smoother macOS touchpad scrolling Alan Third
2017-09-18 18:10           ` Charles A. Roelli
2017-09-18 18:57             ` Charles A. Roelli
2017-09-18 19:03             ` Alan Third
2017-09-18 20:19               ` Charles A. Roelli
2017-09-19 19:12                 ` Alan Third [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20170919191203.GA50068@breton.holly.idiocy.org \
    --to=alan@idiocy.org \
    --cc=charles@aurox.ch \
    --cc=emacs-devel@gnu.org \
    --cc=homeros.misasa@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this external index

	https://git.savannah.gnu.org/cgit/emacs.git
	https://git.savannah.gnu.org/cgit/emacs/org-mode.git

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.