From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!.POSTED!not-for-mail From: Vasilij Schneidermann Newsgroups: gmane.emacs.bugs Subject: bug#28402: 25.2; shr.el uses shr-tag-img despite set shr-external-rendering-functions Date: Wed, 13 Sep 2017 19:22:32 +0200 Message-ID: <20170913172232.7jwwomyfmy567nrx@odonien.localdomain> References: <83poaxrzl1.fsf@gnu.org> NNTP-Posting-Host: blaine.gmane.org Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8 X-Trace: blaine.gmane.org 1505323390 31073 195.159.176.226 (13 Sep 2017 17:23:10 GMT) X-Complaints-To: usenet@blaine.gmane.org NNTP-Posting-Date: Wed, 13 Sep 2017 17:23:10 +0000 (UTC) User-Agent: NeoMutt/20170714-155-820ab5 (1.8.3) Cc: larsi@gnus.org, 28402@debbugs.gnu.org To: Eli Zaretskii Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Wed Sep 13 19:23:06 2017 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane.org Original-Received: from lists.gnu.org ([208.118.235.17]) by blaine.gmane.org with esmtp (Exim 4.84_2) (envelope-from ) id 1dsBNS-0007yd-0V for geb-bug-gnu-emacs@m.gmane.org; Wed, 13 Sep 2017 19:23:06 +0200 Original-Received: from localhost ([::1]:43792 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1dsBNZ-0004MM-DB for geb-bug-gnu-emacs@m.gmane.org; Wed, 13 Sep 2017 13:23:13 -0400 Original-Received: from eggs.gnu.org ([2001:4830:134:3::10]:36763) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1dsBNU-0004Lk-1c for bug-gnu-emacs@gnu.org; Wed, 13 Sep 2017 13:23:08 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1dsBNO-0003ay-Fl for bug-gnu-emacs@gnu.org; Wed, 13 Sep 2017 13:23:08 -0400 Original-Received: from debbugs.gnu.org ([208.118.235.43]:58182) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1dsBNO-0003ap-Bh for bug-gnu-emacs@gnu.org; Wed, 13 Sep 2017 13:23:02 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1dsBNO-0002hE-2V for bug-gnu-emacs@gnu.org; Wed, 13 Sep 2017 13:23:02 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Vasilij Schneidermann Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Wed, 13 Sep 2017 17:23:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 28402 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: Original-Received: via spool by 28402-submit@debbugs.gnu.org id=B28402.150532336310327 (code B ref 28402); Wed, 13 Sep 2017 17:23:02 +0000 Original-Received: (at 28402) by debbugs.gnu.org; 13 Sep 2017 17:22:43 +0000 Original-Received: from localhost ([127.0.0.1]:38629 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1dsBN4-0002gU-Qz for submit@debbugs.gnu.org; Wed, 13 Sep 2017 13:22:43 -0400 Original-Received: from mail-wm0-f51.google.com ([74.125.82.51]:45575) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1dsBN2-0002gH-Ri for 28402@debbugs.gnu.org; Wed, 13 Sep 2017 13:22:41 -0400 Original-Received: by mail-wm0-f51.google.com with SMTP id g206so12289318wme.0 for <28402@debbugs.gnu.org>; Wed, 13 Sep 2017 10:22:40 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to:user-agent; bh=ZklBU+Ak0SwBR38+8n8gGvzA8LRS3g6Jjl/zI8EsAqY=; b=cOYfym4vLKEezfGpLSGx1IK4PC3MOBhs1jNt48jpLbgok/RGwoka5DSUkHO3Wa5xJ+ 8OWyrxN7eAdw3NKcGIZujtrjvynAKdKwgfkW8XjrDyLlf7dEKEnQnp0fSBQ/Vt0Wfoys QfKQkUlqQLLFwRcPzjOlfKshccfA+FY8u8sEAb1AISb0dakm3U/R7eBBsskufkjERStD 5VB+KHPhmh8rYqbEzuC0x7RwAEUS0ikfp3fK/h2HB/o6/b4G1lNnNpOipJMnWFs+yLS6 llh0keIbwKL8GZZH1K140OaDrxSsLHPmFDwRxXTCid9VTFV5eo9etzy++ZrCV5qslW0y Gjpg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to:user-agent; bh=ZklBU+Ak0SwBR38+8n8gGvzA8LRS3g6Jjl/zI8EsAqY=; b=IPJ9vCnjSvJ3KO7Ez0b7vyDHm9hSv8/9nI+37i2mwYWLYY15tDV1+zLOogcgjldSKj UK7RAwDqOwTtWn5BtNbfmDUHEI8NSBCbQ2uECWqGsyBVkO05yPyUlk4ZFLLkXsWLqL4g lW5LbpMkhoHqHvZF9EL2yJJtBSnakF8nq/Otvr44O8pfEEMxXE7GfLJ4d8tXnMDVAE5A J63Pw1vOfDpKKJMFytXHe1g4BYZQ97azT1k2qAOzvIx2R1so2Jxb5IIu4zGUIdO23TXG gFY/45mSnLjDzFzHqFOFhQCW9GqkPYDSzuKvYazYQE1r3XwoRl8gTW1o4HKF2qn7ruwg xR5w== X-Gm-Message-State: AHPjjUihrcUtfKyVXTD04BE8f8ceJcGn4fv/YlxDF7ZiVnpPSaTrLJis YbrZGI+cPb87vp6awnk= X-Google-Smtp-Source: AOwi7QDFStpKN2ZhHCq42bs53o5iatI5knahi/CS+6AS4OH07LUNNYZ6JOHH3cLkr5xrSkUdlmwonQ== X-Received: by 10.80.182.7 with SMTP id b7mr642595ede.61.1505323355177; Wed, 13 Sep 2017 10:22:35 -0700 (PDT) Original-Received: from localhost (dslb-092-072-006-014.092.072.pools.vodafone-ip.de. [92.72.6.14]) by smtp.gmail.com with ESMTPSA id h33sm6597516edh.70.2017.09.13.10.22.33 (version=TLS1_2 cipher=ECDHE-RSA-CHACHA20-POLY1305 bits=256/256); Wed, 13 Sep 2017 10:22:34 -0700 (PDT) Content-Disposition: inline In-Reply-To: <83poaxrzl1.fsf@gnu.org> X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 208.118.235.43 X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.org gmane.emacs.bugs:136899 Archived-At: > From a cursory look into shr.el, it looks like > shr-external-rendering-functions were introduced to support some > specific eww.el needs, not as a general lever for tweaking shr.el from > outside it. That's why only a handful of functions honor that > variable. I suspected as much. > Would you like to submit a patch that would make all shr-tag-* > functions consult that variable first? Before doing that I'd like to get a confirmation from the author whether it's intended for shr-external-rendering-functions to become public API and whether it should work globally, hence why I included them in the CC.