From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!.POSTED!not-for-mail From: Winston Newsgroups: gmane.emacs.bugs Subject: bug#28403: 25.2; find-tag works, but xref-find-definitions Date: Sun, 10 Sep 2017 10:52 EDT Message-ID: <201709101452.v8AEqhOw018098@psr.com> References: <201709092240.v89MeFUo014854@psr.com> NNTP-Posting-Host: blaine.gmane.org X-Trace: blaine.gmane.org 1505055201 20737 195.159.176.226 (10 Sep 2017 14:53:21 GMT) X-Complaints-To: usenet@blaine.gmane.org NNTP-Posting-Date: Sun, 10 Sep 2017 14:53:21 +0000 (UTC) To: Dmitry Gutov , 28403@debbugs.gnu.org Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Sun Sep 10 16:53:17 2017 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane.org Original-Received: from lists.gnu.org ([208.118.235.17]) by blaine.gmane.org with esmtp (Exim 4.84_2) (envelope-from ) id 1dr3bd-0004jB-Tu for geb-bug-gnu-emacs@m.gmane.org; Sun, 10 Sep 2017 16:53:06 +0200 Original-Received: from localhost ([::1]:53242 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1dr3bl-0004fu-7E for geb-bug-gnu-emacs@m.gmane.org; Sun, 10 Sep 2017 10:53:13 -0400 Original-Received: from eggs.gnu.org ([2001:4830:134:3::10]:48528) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1dr3bf-0004fi-1y for bug-gnu-emacs@gnu.org; Sun, 10 Sep 2017 10:53:07 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1dr3ba-00073E-6A for bug-gnu-emacs@gnu.org; Sun, 10 Sep 2017 10:53:07 -0400 Original-Received: from debbugs.gnu.org ([208.118.235.43]:50816) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1dr3ba-00072z-2D for bug-gnu-emacs@gnu.org; Sun, 10 Sep 2017 10:53:02 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1dr3bZ-00014B-Lx for bug-gnu-emacs@gnu.org; Sun, 10 Sep 2017 10:53:01 -0400 X-Loop: help-debbugs@gnu.org In-Reply-To: <201709092240.v89MeFUo014854@psr.com> Resent-From: Winston Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Sun, 10 Sep 2017 14:53:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 28403 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: Original-Received: via spool by 28403-submit@debbugs.gnu.org id=B28403.15050551644074 (code B ref 28403); Sun, 10 Sep 2017 14:53:01 +0000 Original-Received: (at 28403) by debbugs.gnu.org; 10 Sep 2017 14:52:44 +0000 Original-Received: from localhost ([127.0.0.1]:59497 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1dr3bI-00013e-FW for submit@debbugs.gnu.org; Sun, 10 Sep 2017 10:52:44 -0400 Original-Received: from mail.psr.com ([67.212.42.216]:22951 helo=psr.com) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1dr3bG-00013R-Ep for 28403@debbugs.gnu.org; Sun, 10 Sep 2017 10:52:43 -0400 Original-Received: from psr.com (localhost [127.0.0.1]) by psr.com (8.15.2/8.15.2) with ESMTPS id v8AEqhgl018099 (version=TLSv1.2 cipher=DHE-RSA-AES256-GCM-SHA384 bits=256 verify=NO); Sun, 10 Sep 2017 10:52:43 -0400 (EDT) (envelope-from wbe@psr.com) Original-Received: (from wbe@localhost) by psr.com (8.15.2/8.15.2/Submit) id v8AEqhOw018098; Sun, 10 Sep 2017 10:52:43 -0400 (EDT) (envelope-from wbe) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 208.118.235.43 X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.org gmane.emacs.bugs:136730 Archived-At: Dmitry kindly replied: > find-tag just falls back to full text search, which > xref-find-definitions doesn't, by default. > > Because false positives will be more noticeable and annoying in its UI, > compared to find-tag's. and previously replied: >>> Try adding `tag-symbol-match-p' to >>> etags-xref-find-definitions-tag-order. This example should work >>> then, but you'll get more false positives (like treating return >>> types as function names). to which I'd replied: >> Noted for future reference... >> >> Since doing that doesn't change what etags writes to TAGS, I'm not >> sure how that elisp change would result in function return types being >> matched as function names, but no matter. > Have you even tried this? As my reply indicated, I had not, mainly because of your warning that that solution would cause false positives. However, I just tried it now, and, at least initially, it seems to do fine, so I'm now willing to switch over. If you haven't already done so, it's probably worth documenting this solution somewhere so that others converting from find-tag can find this fix via search (Google or otherwise). Thanks! I'll now consider this bug solved. -WBE