From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!.POSTED!not-for-mail From: Mark Oteiza Newsgroups: gmane.emacs.devel Subject: Re: [Emacs-diffs] master da3e101: ; Try not to affect match data Date: Fri, 8 Sep 2017 20:35:29 -0400 Message-ID: <20170909003529.GA1124@holos.localdomain> References: <20170906152101.24092.40365@vcs0.savannah.gnu.org> <20170906152102.0B61C20E37@vcs0.savannah.gnu.org> NNTP-Posting-Host: blaine.gmane.org Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii; format=flowed X-Trace: blaine.gmane.org 1504917359 25171 195.159.176.226 (9 Sep 2017 00:35:59 GMT) X-Complaints-To: usenet@blaine.gmane.org NNTP-Posting-Date: Sat, 9 Sep 2017 00:35:59 +0000 (UTC) User-Agent: Mutt/1.9.0 (2017-09-02) Cc: emacs-devel@gnu.org To: Stefan Monnier Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Sat Sep 09 02:35:53 2017 Return-path: Envelope-to: ged-emacs-devel@m.gmane.org Original-Received: from lists.gnu.org ([208.118.235.17]) by blaine.gmane.org with esmtp (Exim 4.84_2) (envelope-from ) id 1dqTkM-0005pq-R4 for ged-emacs-devel@m.gmane.org; Sat, 09 Sep 2017 02:35:42 +0200 Original-Received: from localhost ([::1]:47759 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1dqTkT-0001t8-UN for ged-emacs-devel@m.gmane.org; Fri, 08 Sep 2017 20:35:49 -0400 Original-Received: from eggs.gnu.org ([2001:4830:134:3::10]:34976) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1dqTkG-0001sl-5d for emacs-devel@gnu.org; Fri, 08 Sep 2017 20:35:37 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1dqTkC-0005Kf-UJ for emacs-devel@gnu.org; Fri, 08 Sep 2017 20:35:36 -0400 Original-Received: from mail-qk0-x235.google.com ([2607:f8b0:400d:c09::235]:33246) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1dqTkC-0005It-Ox for emacs-devel@gnu.org; Fri, 08 Sep 2017 20:35:32 -0400 Original-Received: by mail-qk0-x235.google.com with SMTP id o129so9937718qkd.0 for ; Fri, 08 Sep 2017 17:35:31 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=udel-edu.20150623.gappssmtp.com; s=20150623; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to:user-agent; bh=WsliXiNO90YQ+b4rCeyVyCpoQLgl34NWwbG4zAOS1Sc=; b=Wwp17AX3NyHZjEBQVqK69IgqGOUxFXTaNNTb0NhupOOWixJ6TF4Hb0OQQTuA6fxG4r vQUQyRPy1BRqjGXql8Kx4oiCJpDPtHG3qyjJCgR5g1vuKH40jc67cg3tPA4Seec5+bP/ 4TkvxZaZRK3+g9P/ahb6GnnrHCi/otFI9OEZ4haqZlyyjx1M/iIjEAHWnU3LqgUvEWn4 UH/nto+wfy6FrO7FuNuxJIPUZkjw0LAVnbpDFgvBHtVCDaftdQ6nXDrrjmUfCieSoLPd N/4MgY9keuIqWZOuPAztwLTC9+w0BOPjXFNU1zNArP22i7EEK5cqAJKiJ+mdNwsJiWrR /n6g== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to:user-agent; bh=WsliXiNO90YQ+b4rCeyVyCpoQLgl34NWwbG4zAOS1Sc=; b=qvhrBsDffkxixKcj4nRLRbE65jO8VuNdOK47toOEiFZQ7QQBbKZaJGRn8tCNGFdH4k B+5Bp0ehA/n4DSph/iG7AGXV7LCVicw77I7Nvqq4JSpiDwvSVj25sViWh22Cr4Zsp2H1 ROley45SS0S/uvOyPh5Bz60gItSnvuK2kAv33/0TiJyPFt4Ku8AlOzZIHT9H6O/LBCcN I7knusR7Umb7cP1mLmfkiNUlvlTo7a2NrxeUvf9FX6CuHbKEADTg4YGmRnIMryYzgmEc KHsmEZfSjngS1BzrMqTpgd1IEDSX7dVuP58YZibzOxZD7u5ABlP3kYq35WnG6qcJcMXd p4eA== X-Gm-Message-State: AHPjjUgaF6brtLZ1NjAnOhSfTY9Kld1WsUif2RTUZTxoZT7lpfase7HG B+Uo/Tl0XznwKxQsKnhWIA== X-Google-Smtp-Source: AOwi7QB9iPJ3dY+r0WrgIbheeC3qYWF8EqwOzpCaRP8sCAJFV6a7SgEg5SN3wWgbh2meWacy6A0XwQ== X-Received: by 10.55.49.9 with SMTP id x9mr6451342qkx.89.1504917330529; Fri, 08 Sep 2017 17:35:30 -0700 (PDT) Original-Received: from holos.localdomain (pool-173-67-36-61.bltmmd.fios.verizon.net. [173.67.36.61]) by smtp.gmail.com with ESMTPSA id f48sm2176243qtc.49.2017.09.08.17.35.29 (version=TLS1_2 cipher=ECDHE-RSA-CHACHA20-POLY1305 bits=256/256); Fri, 08 Sep 2017 17:35:29 -0700 (PDT) Original-Received: by holos.localdomain (Postfix, from userid 1000) id 5914068E62; Fri, 8 Sep 2017 20:35:29 -0400 (EDT) Content-Disposition: inline In-Reply-To: X-detected-operating-system: by eggs.gnu.org: Genre and OS details not recognized. X-Received-From: 2607:f8b0:400d:c09::235 X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Original-Sender: "Emacs-devel" Xref: news.gmane.org gmane.emacs.devel:218041 Archived-At: On 07/09/17 at 08:16pm, Stefan Monnier wrote: >> ; Try not to affect match data >> * lisp/xdg.el (xdg-user-dir): Use save-match-data. > >Why does it matter? Given the general way we handle match-data, >I think it's a bug for Elisp code to assume that something like >xdg-user-dir won't affect the match data. I guess it doesn't--I can take it out. >PS: And I just saw that the code says > > "Return the path of user directory referred to by NAME." > > which is wrong since the GNU convention is to use "path" only for > lists of directories (as in $PATH, $MANPATH, load-path, ...), so it > should say something like "file name" or just "Return the directory > referred to by NAME" OK, I'll reword it, thanks.